From: Leo Famulari <leo@famulari.name>
To: Alex Griffin <a@ajgrf.com>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 1/3] gnu: Add utfcpp.
Date: Sat, 7 May 2016 18:19:23 -0400 [thread overview]
Message-ID: <20160507221923.GA16050@jasmine> (raw)
In-Reply-To: <1462646181.1130095.601018617.5F6ADC8F@webmail.messagingengine.com>
On Sat, May 07, 2016 at 01:36:21PM -0500, Alex Griffin wrote:
> This is a dependency of ledger. It's bundled in ledger's source but I
> think it's better to unbundle it. It's a bit unusual in that the headers
> contain the whole source.
> * gnu/packages/unicode.scm: New file.
Not a bad idea for a new module, but I wonder if you considered any of
the existing modules? Are none of them appropriate?
> +(define-public utfcpp
I'm curious — are there any significant differences between this and the
bundled library?
> + (uri
> + (string-append "mirror://sourceforge/project/utfcpp/utf8cpp_2x/Release%20"
> + version "/utf8_v"
> + (string-map (lambda (x) (if (eq? x #\.) #\_ x)) version)
> + ".zip"))
Can you make sure these lines are < 80 characters?
Otherwise, LGTM!
next prev parent reply other threads:[~2016-05-07 22:19 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-07 18:36 [PATCH 1/3] gnu: Add utfcpp Alex Griffin
2016-05-07 22:19 ` Leo Famulari [this message]
2016-05-08 2:10 ` Alex Griffin
2016-05-08 8:13 ` Alex Kost
2016-05-08 14:43 ` Alex Griffin
2016-05-08 19:42 ` Alex Kost
2016-05-09 3:31 ` Leo Famulari
2016-05-09 8:02 ` Alex Kost
2016-05-10 23:31 ` Alex Griffin
2016-05-12 10:02 ` Alex Kost
2016-05-08 16:12 ` Ludovic Courtès
2016-05-08 19:22 ` Alex Kost
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160507221923.GA16050@jasmine \
--to=leo@famulari.name \
--cc=a@ajgrf.com \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.