[PATCH] gnu: Add moc.

[PATCH] gnu: Add moc.

[Kei Yamashita]

[-- Attachment #1.1: Type: text/plain, Size: 73 bytes --]

Everything works on my end. Would someone else like to test this patch?

[-- Attachment #1.2: 0001-gnu-Add-moc.patch --]
[-- Type: application/octet-stream, Size: 2833 bytes --]

From ae471073e1ee18d80879b7a2380fa792e28c1d69 Mon Sep 17 00:00:00 2001
From: Kei Yamashita <kei@openmailbox.org>
Date: Mon, 2 May 2016 15:48:50 -0400
Subject: [PATCH] gnu: Add moc.

* gnu/packages/music.scm (moc): Add variable.
---
 gnu/packages/music.scm | 45 +++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 45 insertions(+)

diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
index 95f52c5..2a3642a 100644
--- a/gnu/packages/music.scm
+++ b/gnu/packages/music.scm
@@ -45,8 +45,10 @@
   #:use-module (gnu packages check)
   #:use-module (gnu packages compression)
   #:use-module (gnu packages curl)
+  #:use-module (gnu packages cyrus-sasl)
   #:use-module (gnu packages docbook)
   #:use-module (gnu packages doxygen)
+  #:use-module (gnu packages file)
   #:use-module (gnu packages flex)
   #:use-module (gnu packages fltk)
   #:use-module (gnu packages fonts)
@@ -84,6 +86,7 @@
   #:use-module (gnu packages tcl)
   #:use-module (gnu packages texinfo)
   #:use-module (gnu packages texlive)
+  #:use-module (gnu packages tls)
   #:use-module (gnu packages video)
   #:use-module (gnu packages web)
   #:use-module (gnu packages wxwidgets)
@@ -1474,3 +1477,45 @@ for improved Amiga ProTracker 2/3 compatibility.")
     (home-page "http://milkytracker.org/")
     ;; 'src/milkyplay' is under Modified BSD, the rest is under GPL3 or later.
     (license (list license:bsd-3 license:gpl3+))))
+
+(define-public moc
+  (package
+    (name "moc")
+    (version "2.5.1")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append "http://ftp.daper.net/pub/soft/"
+                                  name "/stable/"
+                                  name "-" version ".tar.bz2"))
+              (sha256
+               (base32
+                "1wn4za08z64bhsgfhr9c0crfyvy8c3b6a337wx7gz19am5srqh8v"))))
+    (build-system gnu-build-system)
+    (inputs
+     `(("alsa-lib" ,alsa-lib)
+       ("curl" ,curl)
+       ("file" ,file)
+       ("jack" ,jack-1)
+       ("libid3tag" ,libid3tag)
+       ("libltdl" ,libltdl)
+       ("libmad" ,libmad)
+       ("openssl" ,openssl)
+       ("sasl" ,cyrus-sasl)
+       ("zlib" ,zlib)))
+    (native-inputs
+     `(("faad2" ,faad2)
+       ("ffmpeg" ,ffmpeg)
+       ("libmodplug" ,libmodplug)
+       ("libmpcdec" ,libmpcdec)
+       ("ncurses" ,ncurses)
+       ("pkg-config" ,pkg-config)
+       ("speex" ,speex)
+       ("taglib" ,taglib)
+       ("wavpack" ,wavpack)))
+    (synopsis "Console audio player designed to be powerful and easy to use")
+    (description
+     "Music on Console is a console audio player with an interface similar to
+Midnight Commander.  It supports many file formats, including most audio formats
+recognized by FFMpeg.")
+    (home-page "http://moc.daper.net")
+    (license license:gpl2+)))
-- 
2.7.4


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

Re: [PATCH] gnu: Add moc.

[Leo Famulari]

On Mon, May 02, 2016 at 04:24:14PM -0400, Kei Yamashita wrote:
> Everything works on my end. Would someone else like to test this patch?

It works for me!

But, aside from pkg-config, why are those libraries native-inputs rather
than regular inputs? They package seems to work when they are regular
inputs.

Native inputs are typically things that need to run at build-time, so
they must be built for the "native" architecture of the builder. This
matters when cross-compiling.

Also, is it really defined by its similarity to Midnight Commander? If
so, can you say what Midnight Commander is in the description?

Finally, your attached patch had a MIME type of
application/octet-stream, so it was rather challenging to work with. I'm
not sure if that's a shortcoming of my setup or yours...

That's why I haven't quoted it in my reply.

Re: [PATCH] gnu: Add moc.

[Alex Kost]

Leo Famulari (2016-05-06 22:06 +0300) wrote:

> Finally, your attached patch had a MIME type of
> application/octet-stream, so it was rather challenging to work with. I'm
> not sure if that's a shortcoming of my setup or yours...

Hm, it's probably yours.  With Gnus I see it as "text/x-patch" and I
have no problems with this patch.

-- 
Alex

Re: [PATCH] gnu: Add moc.

[Kei Yamashita]

[-- Attachment #1.1: Type: text/plain, Size: 881 bytes --]

> But, aside from pkg-config, why are those libraries native-inputs
> rather than regular inputs? They package seems to work when they are
> regular inputs.
> 

I misunderstood the meaning of the format of the Arch Linux packages
webpage. I usually reference pages from different Unix-like systems to
find dependencies needed for a program.

> Also, is it really defined by its similarity to Midnight Commander? If
> so, can you say what Midnight Commander is in the description?
> 

It's not quite defined by its similarity to Midnight Commander, though
it was mentioned on MOC's about page. That piece can be omitted.

> Finally, your attached patch had a MIME type of
> application/octet-stream

My mail client (Claws Mail) seems to do this automatically. Try the
attached (and corrected) patch. I've attached it explicitly with a MIME
type of text/plain.

[-- Attachment #1.2: 0001-gnu-Add-moc.patch --]
[-- Type: text/plain, Size: 2864 bytes --]

From c9b9fe73c79cfdb892587cfea33798a694cff374 Mon Sep 17 00:00:00 2001
From: Kei Yamashita <kei@openmailbox.org>
Date: Fri, 6 May 2016 18:57:42 -0400
Subject: [PATCH] gnu: Add moc.

* gnu/packages/music.scm (moc): New variable.
---
 gnu/packages/music.scm | 44 ++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 44 insertions(+)

diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
index 4946024..91fa1e2 100644
--- a/gnu/packages/music.scm
+++ b/gnu/packages/music.scm
@@ -45,8 +45,10 @@
   #:use-module (gnu packages check)
   #:use-module (gnu packages compression)
   #:use-module (gnu packages curl)
+  #:use-module (gnu packages cyrus-sasl)
   #:use-module (gnu packages docbook)
   #:use-module (gnu packages doxygen)
+  #:use-module (gnu packages file)
   #:use-module (gnu packages flex)
   #:use-module (gnu packages fltk)
   #:use-module (gnu packages fonts)
@@ -84,6 +86,7 @@
   #:use-module (gnu packages tcl)
   #:use-module (gnu packages texinfo)
   #:use-module (gnu packages texlive)
+  #:use-module (gnu packages tls)
   #:use-module (gnu packages video)
   #:use-module (gnu packages web)
   #:use-module (gnu packages wxwidgets)
@@ -1547,3 +1550,44 @@ for improved Amiga ProTracker 2/3 compatibility.")
     (home-page "http://milkytracker.org/")
     ;; 'src/milkyplay' is under Modified BSD, the rest is under GPL3 or later.
     (license (list license:bsd-3 license:gpl3+))))
+
+(define-public moc
+  (package
+    (name "moc")
+    (version "2.5.1")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append "http://ftp.daper.net/pub/soft/"
+                                  name "/stable/"
+                                  name "-" version ".tar.bz2"))
+              (sha256
+               (base32
+                "1wn4za08z64bhsgfhr9c0crfyvy8c3b6a337wx7gz19am5srqh8v"))))
+    (build-system gnu-build-system)
+    (inputs
+     `(("alsa-lib" ,alsa-lib)
+       ("curl" ,curl)
+       ("faad2" ,faad2)
+       ("ffmpeg" ,ffmpeg)
+       ("file" ,file)
+       ("jack" ,jack-1)
+       ("libid3tag" ,libid3tag)
+       ("libltdl" ,libltdl)
+       ("libmodplug" ,libmodplug)
+       ("libmpcdec" ,libmpcdec)
+       ("libmad" ,libmad)
+       ("ncurses" ,ncurses)
+       ("openssl" ,openssl)
+       ("sasl" ,cyrus-sasl)
+       ("speex" ,speex)
+       ("taglib" ,taglib)
+       ("wavpack" ,wavpack)
+       ("zlib" ,zlib)))
+    (native-inputs
+     `(("pkg-config" ,pkg-config)))
+    (synopsis "Console audio player designed to be powerful and easy to use")
+    (description
+     "Music on Console is a console audio player that supports many file
+formats, including most audio formats recognized by FFMpeg.")
+    (home-page "http://moc.daper.net")
+    (license license:gpl2+)))
-- 
2.7.4


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

Re: [PATCH] gnu: Add moc.

[Leo Famulari]

On Fri, May 06, 2016 at 07:03:31PM -0400, Kei Yamashita wrote:
> > Finally, your attached patch had a MIME type of
> > application/octet-stream
> 
> My mail client (Claws Mail) seems to do this automatically. Try the
> attached (and corrected) patch. I've attached it explicitly with a MIME
> type of text/plain.

Well, as Alex said, it might be a problem on my end. I'm going to get
more familiar with how mutt does MIME.

> From c9b9fe73c79cfdb892587cfea33798a694cff374 Mon Sep 17 00:00:00 2001
> From: Kei Yamashita <kei@openmailbox.org>
> Date: Fri, 6 May 2016 18:57:42 -0400
> Subject: [PATCH] gnu: Add moc.
> 
> * gnu/packages/music.scm (moc): New variable.

Applied as 13416a10afd. Thanks for working on this!