From mboxrd@z Thu Jan 1 00:00:00 1970 From: Efraim Flashner Subject: Re: [PATCH] Connman Date: Thu, 5 May 2016 09:31:37 +0300 Message-ID: <20160505063137.GA31911@debian-netbook> References: <20160420224145.GA8585@debian-netbook> <87fuu99wgq.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="wac7ysb48OaltWcw" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:47188) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ayCpS-0004oD-Bp for guix-devel@gnu.org; Thu, 05 May 2016 02:32:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ayCpG-00011g-2H for guix-devel@gnu.org; Thu, 05 May 2016 02:32:00 -0400 Content-Disposition: inline In-Reply-To: <87fuu99wgq.fsf@gnu.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Ludovic =?utf-8?Q?Court=C3=A8s?= Cc: guix-devel@gnu.org --wac7ysb48OaltWcw Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Apr 26, 2016 at 12:04:21AM +0200, Ludovic Court=C3=A8s wrote: > Efraim Flashner skribis: >=20 > > I think I've finally gotten connman working, with a service. I haven't > > added an entry to doc/guix.texi yet, and for some reason when I started > > the patch I stuck it in wicd.scm. I've also attached the OS config I > > used while testing. >=20 > Neat! >=20 > > From efe1f20ecb23fc4ba2da647152c9f2a2e96293be Mon Sep 17 00:00:00 2001 > > From: Efraim Flashner > > Date: Thu, 19 Apr 2016 17:25:41 +0200 > > Subject: [PATCH 1/2] gnu: Add connman. > > > > * gnu/packages/wicd.scm (connman): New variable. >=20 > I think it should go in some other file, possibly connman.scm=E2=80=94wha= tever > you deem appropriate, but probably not wicd.scm. :-) agreed :) >=20 > > +(define-public connman > > + (package > > + (name "connman") > > + (version "1.32") > > + (source > > + (origin > > + (method url-fetch) > > + (uri (string-append "https://www.kernel.org/pub/linux/network/= connman/" >=20 > Use mirror://kernel.org/=E2=80=A6 >=20 > > + (string-append > > + "--with-dbusconfdir=3D" (assoc-ref %outputs "out") "/etc= ") > > + (string-append > > + "--with-dbusdatadir=3D" (assoc-ref %outputs "out") "/sha= re")))) >=20 > I suppose this populates $out/etc/dbus-1 and $out/share/dbus-1, which is > where our D-Bus service looks for its XML thingies? it turns out it is >=20 > > + (synopsis "Connection Manager daemon") >=20 > =E2=80=9CConnection management daemon=E2=80=9D >=20 > > + (description "The Linux Connection Manager project provides a daem= on for >=20 > s/The Linux Connection Manager project/Connman/ >=20 > > +managing Internet connections within embedded devices running the Linux > > +operating system. >=20 > s/within =E2=80=A6 system// >=20 > > + (license gpl2))) >=20 > v2-only? I thought this was strange and I took another look at the website and the code and it turns out it is gpl2 only. >=20 > > From 2e99131f5b455ceb7c70c33eb4c89134caa755bb Mon Sep 17 00:00:00 2001 > > From: Efraim Flashner > > Date: Thu, 19 Apr 2016 22:10:11 +0200 > > Subject: [PATCH 2/2] services: Add connman-service. > > > > * gnu/services/networking.scm (connman-service): New procedure. > > (connman-service-type, %connman-activation): New variables. > > (connman-shepherd-service): New procedure. >=20 > [...] >=20 > > +(define %connman-activation > > + ;; Activation gexp for Connman. > > + #~(begin > > + (use-modules (guix build utils)) > > + (mkdir-p "/etc/connman/") >=20 > Is an empty /etc/connman really needed? It turns out no. I left /var/lib/connman-vpn because although I didn't write a service for the vpn, the directory would be needed. >=20 > > +(define* (connman-service #:key (connman connman)) > > + "Return a service that runs Connman, a network connection manager. = This >=20 > s/Connman/@uref{http://=E2=80=A6, Connman}/ @uref or @url? wicd uses @url >=20 > > +service adds the @var{connman} package to the global profile, providing > > +several the @command{connmanctl} command to interact with the daemon a= nd > > +configure networking." >=20 > Could you add this documentation to guix.texi? Much less scary than I thought it was going to be >=20 > Otherwise LGTM! >=20 > How does Connman compare to Wicd, and to NetworkManager? Its hard for me to say, Debian is stuck with 1.22 from forever ago, but =66rom playing around it seems almost as featureful as Network Manager while being out of the way like wicd, and has better integration into enlightenment than either one. >=20 > Thank you! >=20 > Ludo=E2=80=99. --=20 Efraim Flashner =D7=90=D7=A4=D7=A8=D7=99=D7=9D = =D7=A4=D7=9C=D7=A9=D7=A0=D7=A8 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --wac7ysb48OaltWcw Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCgAGBQJXKujGAAoJEPTB05F+rO6TTB4P/ippbO4ykzD+reJ0vjoMBxuJ mvPwc7aiL9QDAYDNqc06ZQW1eX7YQELlrQ7f0wTfW3yPHrw1iAaUhibfWfNysjQA WaWBDL5inqv/9EU8NQIFlLJ2zUjNJlj5uVz34S6azgGdrJttDSqg8bMHc0tELlaT I2vnQFHvwLrcf6GZKKna5fWr0M8lfwz6thBI5vCpw2ebgDTBSdn5cbCV7TxLBJew WPUZ+UJT8rI5cpth6rSdcTjmDSQaTlFFwG7eYp6x8BGvFEEqjr33fT5+tMM/nFj+ dA8XpqJ8jQZ34ICGbZz6nMjOhy+8xUW5Z5RiM+0MSkuSenxO4BM0EewDJSTNzyul u/5XJ4aYQ4zflaqcTn8SGGxHfSr7XRP6ctk63oCKJKdEs0GlvCPpPvfhV7E1n/Q5 QSaY7sTGmrw/4KeLNwdh+FEC/3Zl4dh6WC1qGipVUvm4b4SEwiU5/s0P5XZbqTDX yxvTLlxU926FUPgYPoE+w9Rtoclid7vdRq2tL71ge/2L9Tqy877HJFjRLMa67rSU 4AQ/OeKwQa8z+sgB+23sF9JtHlLLVpru3xrwswTUBT5zb4zENsXAjP2ducMiZm1F oMVn9GRFx7Ptko54l7Dxpj/qe5zJuBEDIb8SCvXF2HXvqKhNpnjEWGi4NAJJryCZ R8AE36wPV5ZjKVVVrF4E =kn7B -----END PGP SIGNATURE----- --wac7ysb48OaltWcw--