Re: [PATCH] gnu: Add 4store.

[Leo Famulari <leo@famulari.name>]

On Wed, Apr 27, 2016 at 12:47:40AM +0200, Roel Janssen wrote:
> * gnu/packages/databases.scm (4store): New variable.
> * gnu/packages/patches/4store-fix-buildsystem.patch: New file.
> * gnu/local.mk (dist_patch_DATA): Add patch file entry.

Applied as 4c6aa73b8f9.

Thanks for your work on this!

> Leo Famulari writes:
> > On Tue, Mar 29, 2016 at 08:54:40AM +0200, Roel Janssen wrote:
> >> Leo Famulari writes:
> >> > Why use this commit instead of the last release?
> >> 
> >> I like especially these subtle changes/fixes:
> >> - run-time configurable HTTP log directory:
> >>   commit 1725502cf01130ee80cf9b72249bbfc0f61f17fb
> >> - Fix for potential pointer arithmetic error:
> >>   commit 6e2b4a70d4934484706a67b688ac30f3ca7baf98
> >
> > It's true, those are nice changes to have. But then again, most of our
> > packages have some nice changes between the latest release and HEAD.
> >
> > The best solution would be for 4store to issue a new release, especially
> > if that pointer arithmetic issue is a real problem. Can you ask them if
> > they are planning a new release soon?
> 
> Right.  I think it's too soon for a new release, as there are many
> outstanding bugs to be fixed.  I reverted the version of my patch to the
> latest official release.

Okay, that makes sense. I tend to push back on packaging version control
snapshots, partially in an effort to prod upstream authors to release
with their bug fixes. But, if it's not time to release, it's not time to
release.

Maybe letting them know that we've packaged 4store will encourage them
:)

I thought about this case some more, and if you think there are some bug
fixes that should be applied to our package in the form of patches, that
works for me.

> I also changed the home-page link because 4store.org is still down and
> it doesn't look like that is going to change any time soon.

Okay.

> I attached a new patch that should be fine.  When I applied the patch
> myself I got two warnings about trailing whitespace.  I tried a modified
> patch without spaces after the make target names, but it failed to apply
> the patch when building 4store.  Therefore, I left the whitespace as is,
> and I think we should leave the warnings be.

I usually ignore those warnings in patch files.

> Thanks for your time and effort!

Likewise!