From mboxrd@z Thu Jan 1 00:00:00 1970 From: John Darrington Subject: Re: [PATCH 06/10] gnu: Add libiconv. Date: Sun, 1 May 2016 19:43:10 +0200 Message-ID: <20160501174310.GA6578@jocasta.intra> References: <1461942751-23883-1-git-send-email-janneke@gnu.org> <1461942751-23883-6-git-send-email-janneke@gnu.org> <9b320678-3af9-22c5-ead5-23126e43f57c@gmail.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="LQksG6bCIzRHxTLp" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:39926) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1awvPh-0003zW-55 for guix-devel@gnu.org; Sun, 01 May 2016 13:44:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1awvPV-0007qE-3X for guix-devel@gnu.org; Sun, 01 May 2016 13:44:07 -0400 Content-Disposition: inline In-Reply-To: <9b320678-3af9-22c5-ead5-23126e43f57c@gmail.com> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Manolis Ragkousis Cc: guix-devel@gnu.org --LQksG6bCIzRHxTLp Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, May 01, 2016 at 08:07:56PM +0300, Manolis Ragkousis wrote: ?????????????????? Jan, =20 On 04/29/2016 06:12 PM, Jan Nieuwenhuizen wrote: > + #:use-module (guix build-system trivial) > + #:export (glibc > + libiconv-if-needed)) =20 The #:export (glibc...) part only exists in wip-hurd so we need to remove this in order for your patch to apply on master. =20 > +(define-public libiconv > + (package > + (name "libiconv") > + (version "1.14") > + (source (origin > + (method url-fetch) > + (uri (string-append > + "mirror://gnu/libiconv/libiconv-" > + version ".tar.gz")) > + (sha256 > + (base32 > + "04q6lgl3kglmmhw59igq1n7v3rp1rpkypl366cy1k1yn2znlvckj= ")))) > + (build-system gnu-build-system) > + (synopsis "Character set conversion library") > + (description > + "libiconv provides an implementation of the iconv function for= systems > +that lack it. iconv is used to convert between character encodings= in a > +program. It supports a wide variety of different encodings.") > + (home-page "http://www.gnu.org/software/libiconv/") > + (license lgpl3+))) =20 Maybe we should break this patch into two different ones, one for the libiconv package description and one for the libiconv-if-needed. The first will go to master and the second to core-updates. WDYT? =20 > + > +(define* (libiconv-if-needed #:optional (target (%current-target-sy= stem))) > + (if (mingw-target? target) > + `(("libiconv" ,libiconv)) > + '())) > + =20 I am sorry for my ignorance but why is libiconv needed when targeting = mingw? =20 Because Microsoft does not implement iconv, and presumably this package nee= ds it. J' --=20 Avoid eavesdropping. Send strong encryted email. PGP Public key ID: 1024D/2DE827B3=20 fingerprint =3D 8797 A26D 0854 2EAB 0285 A290 8A67 719C 2DE8 27B3 See http://sks-keyservers.net or any PGP keyserver for public key. --LQksG6bCIzRHxTLp Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlcmQC4ACgkQimdxnC3oJ7M5dgCghTlrpBgByZ+NbGfK9dh6M1fc QiQAn1fA0wO9G7mw6mwYR3ebZ4Lwajj6 =9odF -----END PGP SIGNATURE----- --LQksG6bCIzRHxTLp--