From: Kei Yamashita <kei@openmailbox.org>
To: leo@famulari.name
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] Add thinkfan.
Date: Sun, 1 May 2016 17:24:53 -0400 [thread overview]
Message-ID: <20160501172453.5d9f2327@openmailbox.org> (raw)
In-Reply-To: <20160501211418.GA10221@jasmine>
On Sun, 1 May 2016 17:14:18 -0400
Leo Famulari <leo@famulari.name> wrote:
> On Sun, May 01, 2016 at 01:05:59AM +0200, Nicolas Goaziou wrote:
> > * gnu/packages/linux.scm (thinkfan): New variable.
>
> Thanks!
>
> > + (arguments
> > + `(#:tests? #f ;no test target
> > + #:configure-flags
> > + `("-DUSE_ATASMART:BOOL=ON")))
>
> Can you add a brief comment explaining this flag?
>
> Also, can you add a phase that installs the "rcscripts"? They will be
> useful for Guix users on foreign distros.
>
> I'm not sure where to install them. Since they will probably have to
> be copied or symlinked out of ~/.guix-profile anyways, how about
> installing them into 'share/misc'?
>
> I'm open to better ideas!
>
> > + (synopsis "Simple fan control program")
>
> Is it specific to ThinkPads? If so, can you change the synopsis to
> "Simple fan control program for ThinkPads" and mention the limitation
> in the description?
>
It would be helpful if you told the user where and how to install each
script for each of the major distribution families, similar to how Guix
does this for SystemD and Upstart systems[1].
[1]
https://gnu.org/software/guix/manual/html_node/Binary-Installation.html
next prev parent reply other threads:[~2016-05-01 21:25 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-30 23:05 [PATCH] Add thinkfan Nicolas Goaziou
2016-05-01 21:14 ` Leo Famulari
2016-05-01 21:24 ` Kei Yamashita [this message]
2016-05-03 22:12 ` Nicolas Goaziou
2016-05-06 18:13 ` Leo Famulari
2016-05-06 23:42 ` Nicolas Goaziou
2016-05-07 2:58 ` Leo Famulari
2016-05-07 9:47 ` Nicolas Goaziou
2016-05-09 8:31 ` Ludovic Courtès
2016-05-10 19:25 ` Nicolas Goaziou
2016-05-11 15:57 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160501172453.5d9f2327@openmailbox.org \
--to=kei@openmailbox.org \
--cc=guix-devel@gnu.org \
--cc=leo@famulari.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.