Re: [PATCH 09/10] gnu: Add python-cliff.

[Leo Famulari <leo@famulari.name>]

On Fri, Apr 29, 2016 at 04:21:02PM +0200, Cyril Roelandt wrote:
> * gnu/packages/openstack.scm (python-cliff, python2-cliff): New variables.
> * gnu/packages/patches/python-cliff-remove-unicodecsv.patch: New file.
> * gnu/local.mk: Add it here.

Can you mention (dist_patch_DATA)?

> +    (native-inputs
> +      `(("python-coverage" ,python-coverage)
> +        ("python-httplib2" ,python-httplib2)
> +        ("python-mock" ,python-mock)
> +        ("python-oslosphinx" ,python-oslosphinx)
> +        ("python-pbr" ,python-pbr)
> +        ("python-setuptools" ,python-setuptools)

Did you try putting setuptools in the python-2 variant?

> diff --git a/gnu/packages/patches/python-cliff-remove-unicodecsv.patch b/gnu/packages/patches/python-cliff-remove-unicodecsv.patch

Can you add a couple lines explaining the patch for future readers?

> new file mode 100644
> index 0000000..99b4aa2
> --- /dev/null
> +++ b/gnu/packages/patches/python-cliff-remove-unicodecsv.patch
> @@ -0,0 +1,11 @@
> +diff --git a/requirements.txt b/requirements.txt
> +index f334651..c16761e 100644
> +--- a/requirements.txt
> ++++ b/requirements.txt
> +@@ -7,5 +7,5 @@ PrettyTable<0.8,>=0.7 # BSD
> + pyparsing>=2.0.1 # MIT
> + six>=1.9.0 # MIT
> + stevedore>=1.5.0 # Apache-2.0
> +-unicodecsv>=0.8.0 # BSD
> ++unicodecsv>=0.8.0;python_version<='2.7'# BSD
> + PyYAML>=3.1.0 # MIT
> -- 
> 2.6.2
> 
>