From mboxrd@z Thu Jan  1 00:00:00 1970
From: Leo Famulari <leo@famulari.name>
Subject: Re: [PATCH] tar bombs and muscle
Date: Fri, 29 Apr 2016 22:13:53 -0400
Message-ID: <20160430021353.GC13826@jasmine>
References: <569AEE9B.6070709@uq.edu.au>
	<20160116222954.6ae74288@openmailbox.org>
	<571C0D71.5000209@uq.edu.au>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45900)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1awKQA-0004KK-4m
	for guix-devel@gnu.org; Fri, 29 Apr 2016 22:14:20 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1awKPy-0001C5-JP
	for guix-devel@gnu.org; Fri, 29 Apr 2016 22:14:08 -0400
Received: from out5-smtp.messagingengine.com ([66.111.4.29]:38687)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1awKPw-00018H-BM
	for guix-devel@gnu.org; Fri, 29 Apr 2016 22:14:02 -0400
Content-Disposition: inline
In-Reply-To: <571C0D71.5000209@uq.edu.au>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Ben Woodcroft <b.woodcroft@uq.edu.au>
Cc: "guix-devel@gnu.org" <guix-devel@gnu.org>, Mathieu Lirzin <mthl@openmailbox.org>

On Sun, Apr 24, 2016 at 10:04:01AM +1000, Ben Woodcroft wrote:
> * gnu/packages/bioinformatics.scm (muscle): New variable.

> +              (file-name (string-append name "-" version ".tar.gz"))

Once fetched, the source code is a directory rather than a tarball, so
I think it's best to omit the last component of the string.

> +         (replace 'install
> +           (lambda* (#:key outputs #:allow-other-keys)
> +             (let* ((out (assoc-ref outputs "out"))
> +                    (bin (string-append out "/bin")))
> +               (install-file "muscle" bin)))))))

It only creates the one executable?

> +    (license license:public-domain)))

Wow, they really don't make it easy to find this information. Can you
add a comment saying that it's in 'usage.cpp'? Unless I missed something
obvious...

Otherwise, looks good to me!