From mboxrd@z Thu Jan 1 00:00:00 1970 From: Efraim Flashner Subject: Re: [PATCH 0/2] New pinentries Date: Thu, 28 Apr 2016 04:59:43 +0300 Message-ID: <20160428015943.GA17619@debian-netbook> References: <1461679399-32659-1-git-send-email-efraim@flashner.co.il> <20160426171309.GA13138@jasmine> <20160426210059.GA15624@debian-netbook> <20160427170549.GB13823@jasmine> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="IS0zKkzwUGydFO0o" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:39818) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1avbF9-0006MV-Fc for guix-devel@gnu.org; Wed, 27 Apr 2016 21:59:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1avbF6-0005gP-9K for guix-devel@gnu.org; Wed, 27 Apr 2016 21:59:51 -0400 Received: from flashner.co.il ([178.62.234.194]:55731) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1avbF5-0005g5-VY for guix-devel@gnu.org; Wed, 27 Apr 2016 21:59:48 -0400 Content-Disposition: inline In-Reply-To: <20160427170549.GB13823@jasmine> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Leo Famulari Cc: guix-devel@gnu.org --IS0zKkzwUGydFO0o Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Apr 27, 2016 at 01:05:49PM -0400, Leo Famulari wrote: > On Wed, Apr 27, 2016 at 12:00:59AM +0300, Efraim Flashner wrote: > > On Tue, Apr 26, 2016 at 01:13:09PM -0400, Leo Famulari wrote: > > > On Tue, Apr 26, 2016 at 04:33:16PM +0200, Ricardo Wurmus wrote: > > > >=20 > > > > Hi Efraim, > > > >=20 > > > > > On a whim I removed gtk2 and glib from pinentry and the size of t= he closure > > > > > dropped from 700 MiB to 100 MiB. While I was at it I built a vers= ion with > > > > > qt5, if someone wanted it to match a future kde/qt-based desktop.= I couldn't > > > > > get a gtk3 version building, but I didn't try too hard. > > > > > > > > > > Efraim Flashner (2): > > > > > gnu: Add minimal pinentry. > > > > > gnu: Add pinentry-qt. > > > > > > > > > > gnu/packages/gnupg.scm | 34 +++++++++++++++++++++++++++++----- > > > > > 1 file changed, 29 insertions(+), 5 deletions(-) > > > >=20 > > > > These both look good to me. I think our policy requires to split t= he > > > > first patch in two, one to reduce pinentry, the other to add > > > > pinentry-gtk2, but I=E2=80=99m not sure. > > >=20 > > > I had the same thought, but it would mean we have a commit in our > > > history where we *don't* have the GTK pinentry. I think we should avo= id > > > that. > >=20 > > I thought about that too. With the patches I have we'll have people who > > have pinentry installed who suddenly find that they don't have a gtk-2 > > pop-up anymore. I suppose another option would be to leave pinentry its > > name and call the curses-only pinentry pinentry-curses or > > pinentry-minimal or pinentry-tty. >=20 > Good point. That would be a poor experience for our users. >=20 > Although I would prefer if the console-based pinentry was called > pinentry, I'd rather not change the meaning of the existing variable for > a program that is so important. >=20 > So, pinentry-tty or pinentry-curses makes sense to me. I'll double-check the descriptions to add that the gtk/qt versions also have the curses interface, don't want people to think they need pinentry-curses and pinentry-gtk. >=20 > > In terms of the commit order, maybe one to rename pinentry->pinentry-gtk > > and a second to add pinentry? >=20 > Since I think it's best if users of 'pinentry' don't experience any > disruption, perhaps we could add a variable pinentry-gtk that inherits > from pinentry? Maybe eventually we could deprecate 'pinentry'. I like that idea. --=20 Efraim Flashner =D7=90=D7=A4=D7=A8=D7=99=D7=9D = =D7=A4=D7=9C=D7=A9=D7=A0=D7=A8 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --IS0zKkzwUGydFO0o Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCgAGBQJXIW6LAAoJEPTB05F+rO6Tq3oP/0AooF5JNjbv+SVFChmZT3KE 9tSA2+WRipveGSaC/nNWO6dqk00ml/LppAJt4FAwHTDsmdBcoWgPRJCNYMcoh0Pc PTAdHOfdHS/OZzNRFNcuZQiXIaLkZzvAa5JpzC7/aNS6wjVm2U9Uft+YKisRpJxN 5kTs2yRsOuMtV72eXeAIE/7qMSt0zW3EXliHhaEVaKo12NvciOKzW5UHhPa9QRZB HImCvOUMWOot/lD9LzsAJiF2k9uIynYNfVZnGmZZtMdMCkP8ctyKUFu0SOqejEze F8gHGqC1RSbiGJqdN4C6pXkbADOQjW6kcgMJvFABN2DLmTPdXFlubdZ7G7DCKss7 gEu/Dluxuo18aG6EtUjAWXC/2Hz5phQDCC53Tpb5lIyoY/kmYypLtpJZIa1M8ztH 3spQEwSk4NmTfbMWHG4DnhG4XdLZ7uLyC7i2O2LOg4/AlPGpQyXOyYZZFkzTmAw1 nm2GUrPrm9jPXL0qK1Tt9YXSpi0nKc+QjqAisn9LsvbCbj0fpgjzwWVERojzqpYO aJ3Ph/v9B+VKhlMCJAZhTHirMoAZUOde8obGJLfHkkvcE3tlYCoBaIvAp/q7qw4g 2E/a7zDC/P+Cvsake4DSHnlEv8XaHwFs3HOb/Q9hU9HxaVsNijbh4yP8FOUSq6Xp v08wa2HQO45u3epxnBng =VvPM -----END PGP SIGNATURE----- --IS0zKkzwUGydFO0o--