From: Eric Bavier <ericbavier@openmailbox.org>
To: Cyril Roelandt <tipecaml@gmail.com>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] guix: use '@' in package-full-name instead of '-'
Date: Wed, 27 Apr 2016 22:03:16 -0500 [thread overview]
Message-ID: <20160427220316.1d009150@openmailbox.org> (raw)
In-Reply-To: <1461810323-21018-1-git-send-email-tipecaml@gmail.com>
On Thu, 28 Apr 2016 04:25:23 +0200
Cyril Roelandt <tipecaml@gmail.com> wrote:
> * guix/packages.scm (package-full-name): Use '@' instead of '-'.
> ---
> guix/packages.scm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/guix/packages.scm b/guix/packages.scm
> index d62d1f3..e33791e 100644
> --- a/guix/packages.scm
> +++ b/guix/packages.scm
> @@ -346,7 +346,7 @@ name of its URI."
>
> (define (package-full-name package)
> "Return the full name of PACKAGE--i.e., `NAME-VERSION'."
Could you replace the '-' here too? --------------^
> - (string-append (package-name package) "-" (package-version package)))
> + (string-append (package-name package) "@" (package-version package)))
>
> (define (%standard-patch-inputs)
> (let* ((canonical (module-ref (resolve-interface '(gnu packages base))
LGTM!
`~Eric
next prev parent reply other threads:[~2016-04-28 3:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-28 2:25 [PATCH] guix: use '@' in package-full-name instead of '-' Cyril Roelandt
2016-04-28 3:03 ` Eric Bavier [this message]
2016-04-28 8:23 ` Mathieu Lirzin
2016-04-28 12:07 ` Ludovic Courtès
2016-04-28 8:46 ` Alex Kost
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160427220316.1d009150@openmailbox.org \
--to=ericbavier@openmailbox.org \
--cc=guix-devel@gnu.org \
--cc=tipecaml@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.