From mboxrd@z Thu Jan  1 00:00:00 1970
From: Leo Famulari <leo@famulari.name>
Subject: Re: [PATCH 1/2] gnu: Add minimal pinentry.
Date: Wed, 27 Apr 2016 13:06:37 -0400
Message-ID: <20160427170637.GC13823@jasmine>
References: <1461679399-32659-1-git-send-email-efraim@flashner.co.il>
	<1461679399-32659-2-git-send-email-efraim@flashner.co.il>
	<20160426171440.GB13138@jasmine>
	<20160426210247.GB15624@debian-netbook>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58077)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1avSvA-0006YQ-Hk
	for guix-devel@gnu.org; Wed, 27 Apr 2016 13:06:44 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1avSv5-00070W-II
	for guix-devel@gnu.org; Wed, 27 Apr 2016 13:06:40 -0400
Received: from out1-smtp.messagingengine.com ([66.111.4.25]:35364)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1avSv5-00070O-Ed
	for guix-devel@gnu.org; Wed, 27 Apr 2016 13:06:35 -0400
Received: from compute6.internal (compute6.nyi.internal [10.202.2.46])
	by mailout.nyi.internal (Postfix) with ESMTP id 4D4E320D41
	for <guix-devel@gnu.org>; Wed, 27 Apr 2016 13:06:35 -0400 (EDT)
Content-Disposition: inline
In-Reply-To: <20160426210247.GB15624@debian-netbook>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Efraim Flashner <efraim@flashner.co.il>
Cc: guix-devel@gnu.org

On Wed, Apr 27, 2016 at 12:02:47AM +0300, Efraim Flashner wrote:
> On Tue, Apr 26, 2016 at 01:14:40PM -0400, Leo Famulari wrote:
> > On Tue, Apr 26, 2016 at 05:03:18PM +0300, Efraim Flashner wrote:
> > > * gnu/packages/gnupg.scm (pinentry): Rename pinentry-gtk, inherit from
> > > pinentry.
> > > [arguments]: Add pinentry-tty flag.
> > > [inputs]: Use gtk+-2, glib for pinentry-gtk2 only.
> > > [description]: Modify description based on inputs.
> > > ---
> > >  gnu/packages/gnupg.scm | 22 +++++++++++++++++-----
> > >  1 file changed, 17 insertions(+), 5 deletions(-)
> > > 
> > > diff --git a/gnu/packages/gnupg.scm b/gnu/packages/gnupg.scm
> > > index d447007..71f6ece 100644
> > > --- a/gnu/packages/gnupg.scm
> > > +++ b/gnu/packages/gnupg.scm
> > > @@ -580,21 +580,33 @@ including tools for signing keys, keyring analysis, and party preparation.
> > >                 (base32
> > >                  "1cp7wjqr6nx31mdclr61s2h84ijqjl0ph99kgj4vyawpjj1j1633"))))
> > >      (build-system gnu-build-system)
> > > +    (arguments
> > > +     `(#:configure-flags '("--enable-pinentry-tty")))
> > 
> > Won't pinentry-gtk2 get configured with this? Can you change
> > pinentry-gtk2 so that it doesn't get this flag?
> 
> It will get the flag the way its currently configured, but pinentry-gtk2
> will still be the default method. The real difference (if I understand
> it correctly) is that now if you ssh into the box and you trigger
> pinentry it should now work.

Ah, that sounds good! I've never used pinentry on a remote box but I can
see it being annoying if one's preferred pinentry did not work at all on
the console.