From mboxrd@z Thu Jan 1 00:00:00 1970 From: Efraim Flashner Subject: Re: [PATCH 0/2] New pinentries Date: Wed, 27 Apr 2016 00:00:59 +0300 Message-ID: <20160426210059.GA15624@debian-netbook> References: <1461679399-32659-1-git-send-email-efraim@flashner.co.il> <20160426171309.GA13138@jasmine> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="UugvWAfsgieZRqgk" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:60098) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1avA6l-00072Y-BY for guix-devel@gnu.org; Tue, 26 Apr 2016 17:01:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1avA6g-00038N-DR for guix-devel@gnu.org; Tue, 26 Apr 2016 17:01:23 -0400 Received: from flashner.co.il ([178.62.234.194]:50092) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1avA6g-000384-7i for guix-devel@gnu.org; Tue, 26 Apr 2016 17:01:18 -0400 Content-Disposition: inline In-Reply-To: <20160426171309.GA13138@jasmine> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Leo Famulari Cc: guix-devel@gnu.org --UugvWAfsgieZRqgk Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Apr 26, 2016 at 01:13:09PM -0400, Leo Famulari wrote: > On Tue, Apr 26, 2016 at 04:33:16PM +0200, Ricardo Wurmus wrote: > >=20 > > Hi Efraim, > >=20 > > > On a whim I removed gtk2 and glib from pinentry and the size of the c= losure > > > dropped from 700 MiB to 100 MiB. While I was at it I built a version = with > > > qt5, if someone wanted it to match a future kde/qt-based desktop. I c= ouldn't > > > get a gtk3 version building, but I didn't try too hard. > > > > > > Efraim Flashner (2): > > > gnu: Add minimal pinentry. > > > gnu: Add pinentry-qt. > > > > > > gnu/packages/gnupg.scm | 34 +++++++++++++++++++++++++++++----- > > > 1 file changed, 29 insertions(+), 5 deletions(-) > >=20 > > These both look good to me. I think our policy requires to split the > > first patch in two, one to reduce pinentry, the other to add > > pinentry-gtk2, but I=E2=80=99m not sure. >=20 > I had the same thought, but it would mean we have a commit in our > history where we *don't* have the GTK pinentry. I think we should avoid > that. I thought about that too. With the patches I have we'll have people who have pinentry installed who suddenly find that they don't have a gtk-2 pop-up anymore. I suppose another option would be to leave pinentry its name and call the curses-only pinentry pinentry-curses or pinentry-minimal or pinentry-tty. In terms of the commit order, maybe one to rename pinentry->pinentry-gtk and a second to add pinentry? --=20 Efraim Flashner =D7=90=D7=A4=D7=A8=D7=99=D7=9D = =D7=A4=D7=9C=D7=A9=D7=A0=D7=A8 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --UugvWAfsgieZRqgk Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCgAGBQJXH9cHAAoJEPTB05F+rO6TehoP/1VZjzcCjNyICB+bJTVbxzK8 WyC/WBSRCVU8FOzKQ3uTM8joGyztpRsrQl/iQxBgFFFsJPJ9WtrdDMIrVT9XsTgg TIRpiCoVw/d1G11n0zYkTIiJMR5gprZlIgBU2ykdH/XLaxRnZVQZy97q4sGKvzHC yXvRQfdPykhVLJQng5UyPHPU59vR1dKr9FrlyS98eFOej1chAYDAMmNeQJvP+uG+ 0jXeEi96jVXmdv1tDnLjQxLFN4x3GF9lvbLt/Q/pCSPVQh9MX/br1nN74/T6hFKB Dt1tKFBvuqby7Nhs+Mj9Xyxb9i1WdetqTKPYQ1H3Es/AUu1JZoCc++U3avxZhuRx nAlrO8CAqG9iewd/U9KxlwUAkyi7Nca5KFGW0qJLJIRTJTiG9UmHIGWbLS3DIIaZ LlHA365iMuY242s1f8O4vE+GD08pWPk4o0+C0DWX1BG4hStcj6Q/aXzy1Xp6Ceik fvEYdNvMFR1+BTnbv/lF0GJ0EVjV0k1xuCjXRVAfq3oEHmOvRUha2l02yF2DdwqF OIo7wnw5i6a1B4oafocnuEzQFy3fc7LVBzZUobF+PznDldTjxWRRYuXyLVsaLdJN +PxXII+M3hLBkWv7Rg4Rmnj4s/nvjzStXY78cVkFefrb1eGuZ20HO5Ndtr/E5g5C Zp4HN9WAf2yNj3hjrgdG =O9sq -----END PGP SIGNATURE----- --UugvWAfsgieZRqgk--