From mboxrd@z Thu Jan 1 00:00:00 1970 From: Leo Famulari Subject: Re: [PATCH 0/2] New pinentries Date: Tue, 26 Apr 2016 13:13:09 -0400 Message-ID: <20160426171309.GA13138@jasmine> References: <1461679399-32659-1-git-send-email-efraim@flashner.co.il> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:55501) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1av6Y2-0006hK-Fr for guix-devel@gnu.org; Tue, 26 Apr 2016 13:13:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1av6Xw-0005br-Ld for guix-devel@gnu.org; Tue, 26 Apr 2016 13:13:18 -0400 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:60443) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1av6Xw-0005bY-H1 for guix-devel@gnu.org; Tue, 26 Apr 2016 13:13:12 -0400 Content-Disposition: inline In-Reply-To: List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Ricardo Wurmus Cc: guix-devel@gnu.org On Tue, Apr 26, 2016 at 04:33:16PM +0200, Ricardo Wurmus wrote: > > Hi Efraim, > > > On a whim I removed gtk2 and glib from pinentry and the size of the closure > > dropped from 700 MiB to 100 MiB. While I was at it I built a version with > > qt5, if someone wanted it to match a future kde/qt-based desktop. I couldn't > > get a gtk3 version building, but I didn't try too hard. > > > > Efraim Flashner (2): > > gnu: Add minimal pinentry. > > gnu: Add pinentry-qt. > > > > gnu/packages/gnupg.scm | 34 +++++++++++++++++++++++++++++----- > > 1 file changed, 29 insertions(+), 5 deletions(-) > > These both look good to me. I think our policy requires to split the > first patch in two, one to reduce pinentry, the other to add > pinentry-gtk2, but I’m not sure. I had the same thought, but it would mean we have a commit in our history where we *don't* have the GTK pinentry. I think we should avoid that.