From: Leo Famulari <leo@famulari.name>
To: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 0/2] New pinentries
Date: Tue, 26 Apr 2016 13:13:09 -0400 [thread overview]
Message-ID: <20160426171309.GA13138@jasmine> (raw)
In-Reply-To: <idj1t5s8moj.fsf@bimsb-sys02.mdc-berlin.net>
On Tue, Apr 26, 2016 at 04:33:16PM +0200, Ricardo Wurmus wrote:
>
> Hi Efraim,
>
> > On a whim I removed gtk2 and glib from pinentry and the size of the closure
> > dropped from 700 MiB to 100 MiB. While I was at it I built a version with
> > qt5, if someone wanted it to match a future kde/qt-based desktop. I couldn't
> > get a gtk3 version building, but I didn't try too hard.
> >
> > Efraim Flashner (2):
> > gnu: Add minimal pinentry.
> > gnu: Add pinentry-qt.
> >
> > gnu/packages/gnupg.scm | 34 +++++++++++++++++++++++++++++-----
> > 1 file changed, 29 insertions(+), 5 deletions(-)
>
> These both look good to me. I think our policy requires to split the
> first patch in two, one to reduce pinentry, the other to add
> pinentry-gtk2, but I’m not sure.
I had the same thought, but it would mean we have a commit in our
history where we *don't* have the GTK pinentry. I think we should avoid
that.
next prev parent reply other threads:[~2016-04-26 17:13 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-26 14:03 [PATCH 0/2] New pinentries Efraim Flashner
2016-04-26 14:03 ` [PATCH 1/2] gnu: Add minimal pinentry Efraim Flashner
2016-04-26 17:14 ` Leo Famulari
2016-04-26 21:02 ` Efraim Flashner
2016-04-27 17:06 ` Leo Famulari
2016-04-26 14:03 ` [PATCH 2/2] gnu: Add pinentry-qt Efraim Flashner
2016-04-26 17:15 ` Leo Famulari
2016-04-26 14:33 ` [PATCH 0/2] New pinentries Ricardo Wurmus
2016-04-26 17:13 ` Leo Famulari [this message]
2016-04-26 21:00 ` Efraim Flashner
2016-04-27 17:05 ` Leo Famulari
2016-04-28 1:59 ` Efraim Flashner
2016-04-28 2:49 ` Efraim Flashner
2016-04-29 5:42 ` Leo Famulari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160426171309.GA13138@jasmine \
--to=leo@famulari.name \
--cc=guix-devel@gnu.org \
--cc=ricardo.wurmus@mdc-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.