From mboxrd@z Thu Jan  1 00:00:00 1970
From: Leo Famulari <leo@famulari.name>
Subject: Re: [PATCH v2 10/10] gnu: Add python-scikit-bio.
Date: Mon, 25 Apr 2016 14:47:04 -0400
Message-ID: <20160425184704.GM8957@jasmine>
References: <1461244921-7412-1-git-send-email-donttrustben@gmail.com>
	<1461503184-8841-1-git-send-email-donttrustben@gmail.com>
	<1461503184-8841-11-git-send-email-donttrustben@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56613)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1aulXJ-0001cC-3J
	for Guix-devel@gnu.org; Mon, 25 Apr 2016 14:47:10 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1aulXE-0003vr-8J
	for Guix-devel@gnu.org; Mon, 25 Apr 2016 14:47:09 -0400
Received: from out2-smtp.messagingengine.com ([66.111.4.26]:40041)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1aulXE-0003vf-4o
	for Guix-devel@gnu.org; Mon, 25 Apr 2016 14:47:04 -0400
Received: from compute2.internal (compute2.nyi.internal [10.202.2.42])
	by mailout.nyi.internal (Postfix) with ESMTP id ECC5428371
	for <Guix-devel@gnu.org>; Mon, 25 Apr 2016 14:47:03 -0400 (EDT)
Content-Disposition: inline
In-Reply-To: <1461503184-8841-11-git-send-email-donttrustben@gmail.com>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Ben Woodcroft <donttrustben@gmail.com>
Cc: Guix-devel@gnu.org

On Sun, Apr 24, 2016 at 11:06:24PM +1000, Ben Woodcroft wrote:
> * gnu/packages/python.scm (python-scikit-bio, python2-scikit-bio):
> New variables.

Thanks!

> +    (arguments
> +     `(#:phases
> +       (modify-phases %standard-phases
> +         ;; Install procedure installs extraneous binaries.
> +         (add-after 'install 'remove-extraneous-files
> +           (lambda* (#:key outputs #:allow-other-keys)
> +             (let* ((out (assoc-ref outputs "out"))
> +                    (bin (string-append out "/bin")))
> +               (delete-file-recursively bin))
> +             #t))

That's interesting. How are they extraneous? Would nobody want to use
them?

> +         ;; Tests are intended to be run using 'make test' not 'setup.py
> +         ;; test', but there are many test failures anyway
> +         ;; e.g. https://github.com/biocore/scikit-bio/issues/1308.  Run a
> +         ;; simple import test instead.
> +         (delete 'check)
> +         (add-after 'install 'check-after-install

Are the tests broken, or does scikit-bio simply not work with the
current version of pandas?

More context:
https://github.com/biocore/scikit-bio/pull/1325

> +(define-public python2-scikit-bio
> +  (let ((base (package-with-python2
> +               (strip-python2-variant python-scikit-bio))))
> +    (package
> +      (inherit base)
> +      (native-inputs
> +       (append (package-native-inputs base)
> +               `(("python2-setuptools" ,python2-setuptools)
> +                 ("python2-mock" ,python2-mock)))))))

Same suggestion as for python-natsort.