From mboxrd@z Thu Jan  1 00:00:00 1970
From: Leo Famulari <leo@famulari.name>
Subject: Re: [PATCH v2 09/10] gnu: Add python-natsort.
Date: Mon, 25 Apr 2016 14:41:41 -0400
Message-ID: <20160425184141.GL8957@jasmine>
References: <1461244921-7412-1-git-send-email-donttrustben@gmail.com>
	<1461503184-8841-1-git-send-email-donttrustben@gmail.com>
	<1461503184-8841-10-git-send-email-donttrustben@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56212)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1aulS6-0000x3-Hn
	for Guix-devel@gnu.org; Mon, 25 Apr 2016 14:41:47 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1aulS1-0006va-Iz
	for Guix-devel@gnu.org; Mon, 25 Apr 2016 14:41:46 -0400
Received: from out2-smtp.messagingengine.com ([66.111.4.26]:36774)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1aulS1-0006vD-Eg
	for Guix-devel@gnu.org; Mon, 25 Apr 2016 14:41:41 -0400
Content-Disposition: inline
In-Reply-To: <1461503184-8841-10-git-send-email-donttrustben@gmail.com>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Ben Woodcroft <donttrustben@gmail.com>
Cc: Guix-devel@gnu.org

On Sun, Apr 24, 2016 at 11:06:23PM +1000, Ben Woodcroft wrote:
> * gnu/packages/python.scm (python-natsort, python2-natsort): New
> variables.

Thanks!

> +    (synopsis "Sort lists naturally")

How about "Sort lists naturally rather than lexicographically"?

> +(define-public python2-natsort
> +  (let ((base (package-with-python2
> +               (strip-python2-variant python-natsort))))
> +    (package
> +      (inherit base)
> +      (native-inputs
> +       (append (package-native-inputs base)
> +               `(("python2-mock" ,python2-mock)
> +                 ("python2-pathlib" ,python2-pathlib)
> +                 ("python2-enum34" ,python2-enum34)
> +                 ("python2-setuptools" ,python2-setuptools)))))))

Is it possible to use the technique used in 59f151ec54? I think it's
best if all variants of this type are written the same way.