From mboxrd@z Thu Jan  1 00:00:00 1970
From: Leo Famulari <leo@famulari.name>
Subject: Re: [PATCH v2 04/10] gnu: Add python-pytest-flakes.
Date: Mon, 25 Apr 2016 14:34:55 -0400
Message-ID: <20160425183455.GI8957@jasmine>
References: <1461244921-7412-1-git-send-email-donttrustben@gmail.com>
	<1461503184-8841-1-git-send-email-donttrustben@gmail.com>
	<1461503184-8841-5-git-send-email-donttrustben@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55341)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1aulLW-0007lG-DN
	for Guix-devel@gnu.org; Mon, 25 Apr 2016 14:34:59 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1aulLT-0003sC-7O
	for Guix-devel@gnu.org; Mon, 25 Apr 2016 14:34:58 -0400
Received: from out2-smtp.messagingengine.com ([66.111.4.26]:51653)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1aulLT-0003s0-3s
	for Guix-devel@gnu.org; Mon, 25 Apr 2016 14:34:55 -0400
Content-Disposition: inline
In-Reply-To: <1461503184-8841-5-git-send-email-donttrustben@gmail.com>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Ben Woodcroft <donttrustben@gmail.com>
Cc: Guix-devel@gnu.org

On Sun, Apr 24, 2016 at 11:06:18PM +1000, Ben Woodcroft wrote:
> * gnu/packages/python.scm (python-pytest-flakes,
> python2-pytest-flakes): New variables.

Thanks!

> +    (arguments
> +     `(#:phases
> +       (modify-phases %standard-phases
> +         (add-after 'install 'post-install-check
> +           ;; 'setup.py test' does not run tests
> +           (lambda _
> +             (zero? (system* "py.test" "test_flakes.py")))))))

Does it work if you replace the check phase? Or does the check phase do
something worthwhile? Or do the tests only work after install? Can you
answer this in the code comment? ;)

> +    (native-inputs
> +     `(("python-pytest-pep8" ,python-pytest-pep8)))
> +    (propagated-inputs
> +     `(("python-pytest-cache" ,python-pytest-cache)
> +       ("python-pytest" ,python-pytest)
> +       ("python-pyflakes" ,python-pyflakes)))

I think this could get messy in practice. If, during the build of some
other package, multiple packages try to propagate pytest, we just have
to hope that whichever pytest passes the conflict resolution mechanism
works as expected.

Can you check if it still works when these are "regular" inputs?