From mboxrd@z Thu Jan  1 00:00:00 1970
From: Leo Famulari <leo@famulari.name>
Subject: Re: [PATCH 5/7] gnu: add python-maxminddb and python2-maxminddb
Date: Mon, 18 Apr 2016 16:14:48 -0400
Message-ID: <20160418201448.GB26231@jasmine>
References: <1460926257-25147-1-git-send-email-h.goebel@crazy-compilers.com>
	<1460926257-25147-6-git-send-email-h.goebel@crazy-compilers.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59161)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1asFYv-0001gF-Tl
	for guix-devel@gnu.org; Mon, 18 Apr 2016 16:14:26 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1asFYr-00054S-Rx
	for guix-devel@gnu.org; Mon, 18 Apr 2016 16:14:25 -0400
Received: from out2-smtp.messagingengine.com ([66.111.4.26]:38168)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1asFYr-00054D-Oh
	for guix-devel@gnu.org; Mon, 18 Apr 2016 16:14:21 -0400
Content-Disposition: inline
In-Reply-To: <1460926257-25147-6-git-send-email-h.goebel@crazy-compilers.com>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Hartmut Goebel <h.goebel@crazy-compilers.com>
Cc: guix-devel@gnu.org

On Sun, Apr 17, 2016 at 10:50:55PM +0200, Hartmut Goebel wrote:
> * gnu/packages/python.scm: (python-maxminddb) (python2-maxminddb):
>   New functions.

[...]

> +    (arguments
> +     ;; tests require a copy of the maxminddb which is not included
> +     `(#:tests? #f))

Should the maxminddb be packaged so that we can run the tests?

> +    (synopsis "Reader for the MaxMind DB format")
> +    (description "This is a Python module for reading MaxMind DB files.  The
> +module includes both a pure Python reader and an optional C extension.
> +
> +MaxMind DB is a binary file format that stores data indexed by IP address
> +subnets (IPv4 or IPv6).")

Can you explain to the reader what the purpose of the MaxMind DB is?

> +    (properties `((python2-variant . ,(delay python2-maxminddb))))))
> +
> +(define-public python2-maxminddb
> +  (let ((base (package-with-python2 (strip-python2-variant python-maxminddb))))
> +    (package (inherit base)
> +      (inputs
> +       `(("python2-ipaddr" ,python2-ipaddr)
> +         ,@(package-inputs base))))))

I see you already know to use the python2-variant system. Feel free to
move setuptools here if that works for python-maxminddb.