From mboxrd@z Thu Jan 1 00:00:00 1970 From: Leo Famulari Subject: Re: [PATCH 3/7] gnu: add python-selenium and python2-selenium Date: Mon, 18 Apr 2016 16:12:13 -0400 Message-ID: <20160418201213.GA26231@jasmine> References: <1460926257-25147-1-git-send-email-h.goebel@crazy-compilers.com> <1460926257-25147-4-git-send-email-h.goebel@crazy-compilers.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:58486) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1asFWS-0005F5-Bq for guix-devel@gnu.org; Mon, 18 Apr 2016 16:11:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1asFWO-000477-AW for guix-devel@gnu.org; Mon, 18 Apr 2016 16:11:52 -0400 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:45771) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1asFWO-000473-6p for guix-devel@gnu.org; Mon, 18 Apr 2016 16:11:48 -0400 Content-Disposition: inline In-Reply-To: <1460926257-25147-4-git-send-email-h.goebel@crazy-compilers.com> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Hartmut Goebel Cc: guix-devel@gnu.org On Sun, Apr 17, 2016 at 10:50:53PM +0200, Hartmut Goebel wrote: > * gnu/packages/python.scm (python-selenium) (python2-selenium): > New functions. We use the phrase "New variables" when adding new package definitions to an existing package module. > --- > gnu/packages/python.scm | 35 +++++++++++++++++++++++++++++++++++ > 1 file changed, 35 insertions(+) > > diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm > index b77ab15..d04c85c 100644 > --- a/gnu/packages/python.scm > +++ b/gnu/packages/python.scm > @@ -8788,3 +8788,38 @@ provides support for parsing, splitting and formatting SQL statements.") > > (define-public python2-sqlparse > (package-with-python2 python-sqlparse)) > + Extra blank line ^ > + (arguments > + ;; todo: enable the tests - may be very cumbersum > + `(#:tests? #f)) Can you say what the difficulty is? We prefer to run upstream tests when possible. > + (native-inputs > + `(("python-setuptools" ,python-setuptools))) Did you check if this is really needed? Usually, only the python-2 package variants require setuptools as an input. You can see commit 13f3ff35 for an example of how to do this. > + (home-page "http://www.seleniumhq.org/") > + (synopsis "Python bindings for Selenium") > + (description "Selenium automates browsers. That's it! What you do with > +that power is entirely up to you. Primarily, it is for automating web > +applications for testing purposes, but is certainly not limited to just that. > +Boring web-based administration tasks can (and should!) also be automated as > +well. > + > +Selenium has the support of some of the largest browser vendors who have > +taken (or are taking) steps to make Selenium a native part of their browser. > +It is also the core technology in countless other browser automation tools, > +APIs and frameworks.") A nit-pick, but it would be nice if this was a little less "conversational". That is, things like "That's it! What you do [...]" can be removed.