From mboxrd@z Thu Jan 1 00:00:00 1970 From: Leo Famulari Subject: Re: [PATCH 4/6] gnu: gnome-documents Date: Mon, 18 Apr 2016 14:44:57 -0400 Message-ID: <20160418184457.GA27770@jasmine> References: <77ce1f6925efaed801f9918af4a8834d@openmailbox.org> <87poudghfs.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:33045) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1asE9y-0000mu-Ns for guix-devel@gnu.org; Mon, 18 Apr 2016 14:44:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1asE9w-0003Wy-J2 for guix-devel@gnu.org; Mon, 18 Apr 2016 14:44:34 -0400 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:51375) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1asE9w-0003WZ-Go for guix-devel@gnu.org; Mon, 18 Apr 2016 14:44:32 -0400 Content-Disposition: inline In-Reply-To: List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: rennes@openmailbox.org Cc: guix-devel@gnu.org On Thu, Apr 14, 2016 at 10:35:00AM -0500, rennes@openmailbox.org wrote: > On 2016-03-29 14:25, ludo@gnu.org wrote: > >rennes@openmailbox.org skribis: > > > >>+ `(#:configure-flags > >>+ '("--with-ca-certificates=/etc/ssl/certs/ca-certificates.crt") > > > >AFAICS glib-networking uses GnuTLS, for which we already had such a > >setting (except that it can read all the .crt files from /etc/ssl/certs, > >not just one bundle.) > > I did more tests and remove this part. > > >>+ (modify-phases %standard-phases > >>+ (add-before 'check 'use-empty-ssl-cert-file > >>+ (lambda _ > >>+ ; Search for ca-certificates.crt files > >>+ ; during the check phase. > >>+ (setenv "SSL_CERT_FILE" "/dev/null") > > > >Does this really have an effect? This is the environment variable used > >by OpenSSL, but not GnuTLS. > > indeed, it works. > > Question, to which package module I can add the patch? I've moved it into web.scm, in the attached revision on your patch. I can apply it if you think it looks good. What do you think? I also reorganized the native-inputs a little bit, to put all the "check" dependencies together. By the way, thanks for working on this patch series, and SORRY for the slow review!