[PATCH] Add cabextract.

[PATCH] Add cabextract.

[Danny Milosavljevic]

Hi,

this patch adds cabextract, an extractor for CAB files. (libmspack is already in, but cabextract isn't)

  * gnu/packages/compression.scm (cabextract): New variable.
---
 b/gnu/packages/compression.scm |   23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/gnu/packages/compression.scm b/gnu/packages/compression.scm
index 938d4b8..9343e85 100644
--- a/gnu/packages/compression.scm
+++ b/gnu/packages/compression.scm
@@ -688,3 +688,26 @@ a collection of smaller blocks which makes random access to the original data
 possible and can compress in parallel.  This is especially useful for large
 tarballs.")
     (license license:bsd-2)))
+
+(define-public cabextract
+ (package
+   (name "cabextract")
+   (version "1.6")
+   (source (origin
+              (method url-fetch)
+              (uri (string-append
+                    "http://cabextract.org.uk/cabextract-" version ".tar.gz"))
+              (sha256
+               (base32
+                "1ysmmz25fjghq7mxb2anyyvr1ljxqxzi4piwjhk0sdamcnsn3rnf"))))
+    (build-system gnu-build-system)
+    (arguments '(#:configure-flags '("--with-external-libmspack")))
+    (native-inputs
+     `(("pkg-config" ,pkg-config)
+       ))
+    (inputs
+     `(("libmspack" ,libmspack)))
+    (home-page "http://www.cabextract.org.uk/")
+    (synopsis "CAB Extractor")
+    (description "cabextract extracts files from CAB archives.")
+    (license (list license:gpl2 license:gpl3))))

Re: [PATCH] Add cabextract.

[Ricardo Wurmus]

Danny Milosavljevic <dannym@scratchpost.org> writes:

> Hi,
>
> this patch adds cabextract, an extractor for CAB files. (libmspack is already in, but cabextract isn't)
>
>   * gnu/packages/compression.scm (cabextract): New variable.
> ---
>  b/gnu/packages/compression.scm |   23 +++++++++++++++++++++++
>  1 file changed, 23 insertions(+)
>
> diff --git a/gnu/packages/compression.scm b/gnu/packages/compression.scm
> index 938d4b8..9343e85 100644
> --- a/gnu/packages/compression.scm
> +++ b/gnu/packages/compression.scm
> @@ -688,3 +688,26 @@ a collection of smaller blocks which makes random access to the original data
>  possible and can compress in parallel.  This is especially useful for large
>  tarballs.")
>      (license license:bsd-2)))
> +
> +(define-public cabextract
> + (package
> +   (name "cabextract")
> +   (version "1.6")
> +   (source (origin
> +              (method url-fetch)
> +              (uri (string-append
> +                    "http://cabextract.org.uk/cabextract-" version ".tar.gz"))
> +              (sha256
> +               (base32
> +                "1ysmmz25fjghq7mxb2anyyvr1ljxqxzi4piwjhk0sdamcnsn3rnf"))))
> +    (build-system gnu-build-system)
> +    (arguments '(#:configure-flags '("--with-external-libmspack")))
> +    (native-inputs
> +     `(("pkg-config" ,pkg-config)
> +       ))

Please move these two closing parentheses to the previous line.

> +    (inputs
> +     `(("libmspack" ,libmspack)))
> +    (home-page "http://www.cabextract.org.uk/")
> +    (synopsis "CAB Extractor")
> +    (description "cabextract extracts files from CAB archives.")

Both synopsis and description are very terse.  For the synopsis
something like “Tool to unpack CAB archives” might be a little less
cryptic.  I don’t have any alternative for the description, but it would
be nice if it were a little less terse.

> +    (license (list license:gpl2 license:gpl3))))

Could you add a comment explaining what this means?  Are parts of the
code released under GPLv2 only?

~~ Ricardo

Re: [PATCH] Add cabextract.

[Leo Famulari]

On Sun, Apr 17, 2016 at 11:32:24AM +0200, Ricardo Wurmus wrote:
> Danny Milosavljevic <dannym@scratchpost.org> writes:
> > +    (synopsis "CAB Extractor")
> > +    (description "cabextract extracts files from CAB archives.")
> 
> Both synopsis and description are very terse.  For the synopsis
> something like “Tool to unpack CAB archives” might be a little less
> cryptic.  I don’t have any alternative for the description, but it would
> be nice if it were a little less terse.

The abbreviate CAB could be unpacked in the description.

[PATCHv2] Add cabextract.

[Danny Milosavljevic]

 * gnu/packages/compression.scm (cabextract): New variable.
---
 b/gnu/packages/compression.scm |   23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/gnu/packages/compression.scm b/gnu/packages/compression.scm
index de5d03a..cd89dfe 100644
--- a/gnu/packages/compression.scm
+++ b/gnu/packages/compression.scm
@@ -731,3 +731,26 @@ similar in speed to deflate but offers denser compression.  This package
 provides encoder and a decoder libraries: libbrotlienc and libbrotlidec,
 respectively, based on the reference implementation from Google.")
       (license license:expat))))
+
+(define-public cabextract
+ (package
+   (name "cabextract")
+   (version "1.6")
+   (source (origin
+              (method url-fetch)
+              (uri (string-append
+                    "http://cabextract.org.uk/cabextract-" version ".tar.gz"))
+              (sha256
+               (base32
+                "1ysmmz25fjghq7mxb2anyyvr1ljxqxzi4piwjhk0sdamcnsn3rnf"))))
+    (build-system gnu-build-system)
+    (arguments '(#:configure-flags '("--with-external-libmspack")))
+    (native-inputs
+     `(("pkg-config" ,pkg-config)))
+    (inputs
+     `(("libmspack" ,libmspack)))
+    (home-page "http://www.cabextract.org.uk/")
+    (synopsis "Tool to unpack Cabinet archives")
+    (description "Extracts files out of Microsoft Cabinet (.cab) archives")
+    ;; Some source files specify gpl2, however COPYING is gpl3.
+    (license (list license:gpl2 license:gpl3))))

Re: [PATCHv2] Add cabextract.

[John Darrington]

[-- Attachment #1: Type: text/plain, Size: 639 bytes --]

On Sun, Apr 17, 2016 at 02:31:25PM +0200, Danny Milosavljevic wrote:
     +    ;; Some source files specify gpl2, however COPYING is gpl3.
     +    (license (list license:gpl2 license:gpl3))))

That is a legally impossible.

Do those gpl2 files have the "or later" clause.  If so, then it should be gplv2+

If not, then this software may not be distributed.  To do so would violate GPLv2.


J'


-- 
Avoid eavesdropping.  Send strong encryted email.
PGP Public key ID: 1024D/2DE827B3 
fingerprint = 8797 A26D 0854 2EAB 0285  A290 8A67 719C 2DE8 27B3
See http://sks-keyservers.net or any PGP keyserver for public key.


[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

Re: [PATCHv2] Add cabextract.

[Danny Milosavljevic]

Hi,

the following files list GPL2 or later or LGPL 2 or later (mspack/ is not used, it's using the mspack package in guix):

($ grep -rEi '(any later version|license)' . |grep -v COPYING |grep -v mspack)

./getopt1.c:   modify it under the terms of the GNU Library General Public License as
./getopt1.c:   License, or (at your option) any later version.
./getopt1.c:   Library General Public License for more details.

^ this one is lgpl2+.

./md5.h:   under the terms of the GNU General Public License as published by the
...   Free Software Foundation; either version 2, or (at your option) any
./md5.h:   GNU General Public License for more details.
./md5.h:   You should have received a copy of the GNU General Public License

^ gpl2+

./fnmatch.c:	modify it under the terms of the GNU General Public License
./fnmatch.c:	of the License, or (at your option) any later version.
./fnmatch.c:	See the GNU General Public License for more details.
./fnmatch.c:	You should have received a copy of the GNU General Public License

^ gpl2+

./fnmatch_.h:under the terms of the GNU General Public License as published by the
./fnmatch_.h:GNU General Public License for more details.
./fnmatch_.h:You should have received a copy of the GNU General Public License

^ gpl2+

./md5.c:   under the terms of the GNU General Public License as published by the
./md5.c:   GNU General Public License for more details.
./md5.c:   You should have received a copy of the GNU General Public License

^ gpl2+

./src/cabinfo.c: * it under the terms of the GNU General Public License as published by
./src/cabinfo.c: * the Free Software Foundation; either version 2 of the License, or
./src/cabinfo.c: * (at your option) any later version.
./src/cabinfo.c: * GNU General Public License for more details.
./src/cabinfo.c: * You should have received a copy of the GNU General Public License

^ gpl2+

./src/cabextract.c: * it under the terms of the GNU General Public License as published by
./src/cabextract.c: * the Free Software Foundation; either version 2 of the License, or
./src/cabextract.c: * (at your option) any later version.
./src/cabextract.c: * GNU General Public License for more details.
./src/cabextract.c: * You should have received a copy of the GNU General Public License

^ gpl2+

./getopt.c:   modify it under the terms of the GNU Library General Public License as
./getopt.c:   License, or (at your option) any later version.
./getopt.c:   Library General Public License for more details.

^ lgpl2+

./getopt.h:   modify it under the terms of the GNU Library General Public License as
./getopt.h:   License, or (at your option) any later version.
./getopt.h:   Library General Public License for more details.

^ lgpl2+

./mktime.c:   under the terms of the GNU General Public License as published by the
./mktime.c:   GNU General Public License for more details.
./mktime.c:   You should have received a copy of the GNU General Public License

^ gpl2+

And as I said, COPYING is the gpl3. Hmm...

Re: [PATCHv2] Add cabextract.

[John Darrington]

[-- Attachment #1: Type: text/plain, Size: 754 bytes --]

On Sun, Apr 17, 2016 at 03:45:43PM +0200, Danny Milosavljevic wrote:
     Hi,
     
     the following files list GPL2 or later or LGPL 2 or later (mspack/ is not used, it's using the mspack package in guix):
     
     ($ grep -rEi '(any later version|license)' . |grep -v COPYING |grep -v mspack)
     
     And as I said, COPYING is the gpl3. Hmm...

So it would seem to me, that the only licence under which one can distribute the aggregated package
is GPLv3 (or later).  So that is what we should say.

J'

-- 
Avoid eavesdropping.  Send strong encryted email.
PGP Public key ID: 1024D/2DE827B3 
fingerprint = 8797 A26D 0854 2EAB 0285  A290 8A67 719C 2DE8 27B3
See http://sks-keyservers.net or any PGP keyserver for public key.


[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

[PATCH v3] Add cabextract.

[Danny Milosavljevic]

v3: License field fixed up to be gpl3+.

  * gnu/packages/compression.scm (cabextract): New variable.
---
 b/gnu/packages/compression.scm |   23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)
diff --git a/gnu/packages/compression.scm b/gnu/packages/compression.scm
index de5d03a..ea1e905 100644
--- a/gnu/packages/compression.scm
+++ b/gnu/packages/compression.scm
@@ -731,3 +731,26 @@ similar in speed to deflate but offers denser compression.  This package
 provides encoder and a decoder libraries: libbrotlienc and libbrotlidec,
 respectively, based on the reference implementation from Google.")
       (license license:expat))))
+
+(define-public cabextract
+ (package
+   (name "cabextract")
+   (version "1.6")
+   (source (origin
+              (method url-fetch)
+              (uri (string-append
+                    "http://cabextract.org.uk/cabextract-" version ".tar.gz"))
+              (sha256
+               (base32
+                "1ysmmz25fjghq7mxb2anyyvr1ljxqxzi4piwjhk0sdamcnsn3rnf"))))
+    (build-system gnu-build-system)
+    (arguments '(#:configure-flags '("--with-external-libmspack")))
+    (native-inputs
+     `(("pkg-config" ,pkg-config)))
+    (inputs
+     `(("libmspack" ,libmspack)))
+    (home-page "http://www.cabextract.org.uk/")
+    (synopsis "Tool to unpack Cabinet archives")
+    (description "Extracts files out of Microsoft Cabinet (.cab) archives")
+    ;; Some source files specify gpl2+, lgpl2+, however COPYING is gpl3.
+    (license license:gpl3+)))