mplayer version update

mplayer version update

[rain1]

[-- Attachment #1: Type: text/plain, Size: 153 bytes --]

In order to fix the compile error 
<http://hydra.gnu.org:3000/build/1115431> I have bumped the version of 
mplayer up to 1.3.0, the most modern version.

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-mplayer-Update-to-1.3.0.patch --]
[-- Type: text/x-diff; name=0001-gnu-mplayer-Update-to-1.3.0.patch, Size: 1126 bytes --]

From 423c2717e00577e865bf416598b5481bfa812564 Mon Sep 17 00:00:00 2001
From: Raymond Nicholson <rain1@openmailbox.org>
Date: Mon, 4 Apr 2016 21:20:11 +0100
Subject: [PATCH] gnu: mplayer: Update to 1.3.0.

* gnu/packages/video.scm (mplayer): Update to 1.3.0.
---
 gnu/packages/video.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm
index 494889a..8f93950 100644
--- a/gnu/packages/video.scm
+++ b/gnu/packages/video.scm
@@ -602,7 +602,7 @@ treaming protocols.")
 (define-public mplayer
   (package
     (name "mplayer")
-    (version "1.2.1")
+    (version "1.3.0")
     (source (origin
              (method url-fetch)
              (uri (string-append
@@ -610,7 +610,7 @@ treaming protocols.")
                    version ".tar.xz"))
              (sha256
               (base32
-               "0prbqnsl6s7fbpp6nc6babx7gzwdrhrhzf0cmp6xz6w9gl4sy6w3"))))
+               "0hwqn04bdknb2ic88xd75smffxx63scvz0zvwvjb56nqj9n89l1s"))))
     (build-system gnu-build-system)
     ;; FIXME: Add additional inputs once available.
     (native-inputs
-- 
2.7.3

Re: mplayer version update

[Mark H Weaver]

rain1@openmailbox.org writes:

> In order to fix the compile error
> <http://hydra.gnu.org:3000/build/1115431> I have bumped the version of
> mplayer up to 1.3.0, the most modern version.
>
> From 423c2717e00577e865bf416598b5481bfa812564 Mon Sep 17 00:00:00 2001
> From: Raymond Nicholson <rain1@openmailbox.org>
> Date: Mon, 4 Apr 2016 21:20:11 +0100
> Subject: [PATCH] gnu: mplayer: Update to 1.3.0.

Pushed, thanks!

     Mark

pcmanfm version update

[rain1]

[-- Attachment #1: Type: text/plain, Size: 145 bytes --]

pcmanfm (and its library libfm) were at version 1.2.3 from 2 years ago. 
This patch updates them to 1.2.4, the most recent version from February.

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-pcmanfm-Update-to-1.2.4.patch --]
[-- Type: text/x-diff; name=0001-gnu-pcmanfm-Update-to-1.2.4.patch, Size: 2028 bytes --]

From 437fee1d56001da92b5b9cd65811d65b1316aec2 Mon Sep 17 00:00:00 2001
From: Raymond Nicholson <rain1@openmailbox.org>
Date: Thu, 7 Apr 2016 21:07:59 +0100
Subject: [PATCH] gnu: pcmanfm: Update to 1.2.4.

* gnu/packages/lxde.scm (pcmanfm): Update to 1.2.4.
* gnu/packages/lxde.scm (libfm): Update to 1.2.4.
---
 gnu/packages/lxde.scm | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/gnu/packages/lxde.scm b/gnu/packages/lxde.scm
index fe71a17..7ce31ad 100644
--- a/gnu/packages/lxde.scm
+++ b/gnu/packages/lxde.scm
@@ -32,7 +32,7 @@
 (define-public libfm
   (package
     (name "libfm")
-    (version "1.2.3")
+    (version "1.2.4")
     (source (origin
               (method url-fetch)
               (uri (string-append "mirror://sourceforge/project/pcmanfm/"
@@ -40,7 +40,7 @@
                                   "%29/LibFM/" name "-" version ".tar.xz"))
               (sha256
                (base32
-                "1ygvw52262r3jp1f45m9cdpx5xgvd4rkyfszslfqvg2c99ig34n6"))))
+                "0bsh4p7h2glhxf1cc1lvbxyb4qy0y1zsnl9izf7vrldkikrgc13q"))))
     (build-system gnu-build-system)
     (inputs `(("glib" ,glib)
               ("gtk+" ,gtk+-2)))
@@ -189,7 +189,7 @@ speed up the access to freedesktop.org defined application menus.")
 (define-public pcmanfm
   (package
     (name "pcmanfm")
-    (version "1.2.3")
+    (version "1.2.4")
     (source (origin
               (method url-fetch)
               (uri (string-append "mirror://sourceforge/project/" name "/"
@@ -197,7 +197,7 @@ speed up the access to freedesktop.org defined application menus.")
                                   "%29/PCManFM/" name "-" version ".tar.xz"))
               (sha256
                (base32
-                "1033rw5jd7nlzbcdpx3bik7347kyh1sg1gkla424gq9vqqpxia6g"))))
+                "04z3vd9si24yi4c8calqncdpb9b6mbj4cs4f3fs86i6j05gvpk9q"))))
     (build-system gnu-build-system)
     ;; (#:configure-flags '("--sysconfdir=/etc")) suggested in README.
     (inputs `(("gtk+"   ,gtk+-2)
-- 
2.7.3

Re: pcmanfm version update

[Alex Kost]

rain1@openmailbox.org (2016-04-07 23:12 +0300) wrote:

> pcmanfm (and its library libfm) were at version 1.2.3 from 2 years
> ago. This patch updates them to 1.2.4, the most recent version from
> February.

> From 437fee1d56001da92b5b9cd65811d65b1316aec2 Mon Sep 17 00:00:00 2001
> From: Raymond Nicholson <rain1@openmailbox.org>
> Date: Thu, 7 Apr 2016 21:07:59 +0100
> Subject: [PATCH] gnu: pcmanfm: Update to 1.2.4.
>
> * gnu/packages/lxde.scm (pcmanfm): Update to 1.2.4.
> * gnu/packages/lxde.scm (libfm): Update to 1.2.4.
> ---
>  gnu/packages/lxde.scm | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)

Since these are 2 updates, could you send 2 patches for each package?
Thanks!

-- 
Alex

Re: pcmanfm version update

[Alex Kost]

Please keep guix-devel Cc-ed!

rain1@openmailbox.org (2016-04-09 15:43 +0300) wrote:

> On 2016-04-09 08:47, Alex Kost wrote:
>> rain1@openmailbox.org (2016-04-07 23:12 +0300) wrote:
>>
>>> pcmanfm (and its library libfm) were at version 1.2.3 from 2 years
>>> ago. This patch updates them to 1.2.4, the most recent version from
>>> February.
>>
>>> From 437fee1d56001da92b5b9cd65811d65b1316aec2 Mon Sep 17 00:00:00 2001
>>> From: Raymond Nicholson <rain1@openmailbox.org>
>>> Date: Thu, 7 Apr 2016 21:07:59 +0100
>>> Subject: [PATCH] gnu: pcmanfm: Update to 1.2.4.
>>>
>>> * gnu/packages/lxde.scm (pcmanfm): Update to 1.2.4.
>>> * gnu/packages/lxde.scm (libfm): Update to 1.2.4.
>>> ---
>>>  gnu/packages/lxde.scm | 8 ++++----
>>>  1 file changed, 4 insertions(+), 4 deletions(-)
>>
>> Since these are 2 updates, could you send 2 patches for each package?
>> Thanks!
>>
> I don't think that makes sense, libfm is part of pcmanfm.

But these are 2 different packages from 2 different sources, so I still
think it makes sense to update them in 2 commits.  I hope other people
tell what is preferable here on their opinions, thanks.

-- 
Alex

Re: pcmanfm version update

[Andreas Enge]

On Sat, Apr 09, 2016 at 07:37:13PM +0300, Alex Kost wrote:
> But these are 2 different packages from 2 different sources, so I still
> think it makes sense to update them in 2 commits.  I hope other people
> tell what is preferable here on their opinions, thanks.

Yes, we always work on one package at a time.

Andreas

Re: pcmanfm version update

[Efraim Flashner]

[-- Attachment #1: Type: text/plain, Size: 910 bytes --]

On Sat, Apr 09, 2016 at 07:19:58PM +0200, Andreas Enge wrote:
> On Sat, Apr 09, 2016 at 07:37:13PM +0300, Alex Kost wrote:
> > But these are 2 different packages from 2 different sources, so I still
> > think it makes sense to update them in 2 commits.  I hope other people
> > tell what is preferable here on their opinions, thanks.
> 
> Yes, we always work on one package at a time.
> 
> Andreas
> 

We do have some packages that have to be updated together, acme and
letsencrypt, python-cryptography and python-cryptography-vectors. But
those do have a commit message that they are updated together.

Does either libfm or pcmanfm build independant of the other being
upgraded?

-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: pcmanfm version update

[Mathieu Lirzin]

Efraim Flashner <efraim@flashner.co.il> writes:

> On Sat, Apr 09, 2016 at 07:19:58PM +0200, Andreas Enge wrote:
>> On Sat, Apr 09, 2016 at 07:37:13PM +0300, Alex Kost wrote:
>> > But these are 2 different packages from 2 different sources, so I still
>> > think it makes sense to update them in 2 commits.  I hope other people
>> > tell what is preferable here on their opinions, thanks.
>> 
>> Yes, we always work on one package at a time.
>> 
>> Andreas
>> 
>
> We do have some packages that have to be updated together, acme and
> letsencrypt, python-cryptography and python-cryptography-vectors. But
> those do have a commit message that they are updated together.
>
> Does either libfm or pcmanfm build independant of the other being
> upgraded?

They are independent.

-- 
Mathieu Lirzin

Re: pcmanfm version update

[Leo Famulari]

On Sat, Apr 09, 2016 at 10:59:03PM +0300, Efraim Flashner wrote:
> We do have some packages that have to be updated together, acme and
> letsencrypt, python-cryptography and python-cryptography-vectors. But
> those do have a commit message that they are updated together.

If those packages were updated separately, the build would break after
the first commit. Neither of those package pairs works if the versions
are not in sync [0].

In my opinion, that is a valid reason for updating multiple packages in
the same commit.

[0] It's a little more complicated than that. Python-acme does not
depend on letsencrypt, so it should still work if updated separately.
But we should not break letsencrypt if we can help it. Letsencrypt and
python-acme are developed in the same code base and are only separated
for distribution, AFAICT.

Re: pcmanfm version update

[Ludovic Courtès]

Leo Famulari <leo@famulari.name> skribis:

> On Sat, Apr 09, 2016 at 10:59:03PM +0300, Efraim Flashner wrote:
>> We do have some packages that have to be updated together, acme and
>> letsencrypt, python-cryptography and python-cryptography-vectors. But
>> those do have a commit message that they are updated together.
>
> If those packages were updated separately, the build would break after
> the first commit. Neither of those package pairs works if the versions
> are not in sync [0].
>
> In my opinion, that is a valid reason for updating multiple packages in
> the same commit.

If that is the case (I wouldn’t be surprised), I agree it’s a valid
reason.

Anyway, it’s no big deal, so we shouldn’t block otherwise
uncontroversial and non-disrupting patches for 1 week just because of
this IMO.

Thoughts?  Someone applies it?  :-)

Ludo’.

Re: pcmanfm version update

[Leo Famulari]

On Wed, Apr 13, 2016 at 11:31:02PM +0200, Ludovic Courtès wrote:
> Leo Famulari <leo@famulari.name> skribis:
> 
> > On Sat, Apr 09, 2016 at 10:59:03PM +0300, Efraim Flashner wrote:
> >> We do have some packages that have to be updated together, acme and
> >> letsencrypt, python-cryptography and python-cryptography-vectors. But
> >> those do have a commit message that they are updated together.

Python-cryptography-vectors is a test suite for python-cryptography
[0]. I think it wouldn't be wrong for them to be integrated into the
python-cryptography package if they are not used elsewhere.

> > If those packages were updated separately, the build would break after
> > the first commit. Neither of those package pairs works if the versions
> > are not in sync [0].
> >
> > In my opinion, that is a valid reason for updating multiple packages in
> > the same commit.
> 
> If that is the case (I wouldn’t be surprised), I agree it’s a valid
> reason.

I tried it, and pcmanfm 1.2.4 at least built successfully against libfm
1.2.3. But, pcmanfm only ran tests in the 'po' translations
directory, where they warn about use of a deprecated regex syntax.
 
> Anyway, it’s no big deal, so we shouldn’t block otherwise
> uncontroversial and non-disrupting patches for 1 week just because of
> this IMO.

True, we got sidetracked. Sorry for the delay, Raymond!

Applied as 58f738a1c8.

[0]
https://cryptography.io/en/latest/development/test-vectors/