From mboxrd@z Thu Jan 1 00:00:00 1970 From: Leo Famulari Subject: Re: [PATCH] gnu: Add gnome-sudoku and qqwing Date: Mon, 11 Apr 2016 00:44:08 -0400 Message-ID: <20160411044408.GA26072@jasmine> References: <75cba97de5a5a0c6ff4eb5af47ee72a2@openmailbox.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:48760) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1apTvh-0005xm-D3 for guix-devel@gnu.org; Mon, 11 Apr 2016 00:58:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1apTve-0004da-50 for guix-devel@gnu.org; Mon, 11 Apr 2016 00:58:29 -0400 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:54982) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1apTve-0004dW-0T for guix-devel@gnu.org; Mon, 11 Apr 2016 00:58:26 -0400 Content-Disposition: inline In-Reply-To: <75cba97de5a5a0c6ff4eb5af47ee72a2@openmailbox.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: kei@openmailbox.org Cc: guix-devel@gnu.org On Sun, Apr 10, 2016 at 11:23:51PM -0400, kei@openmailbox.org wrote: > I'm attempting something new with this patch. I want to add gnome-sudoku to > the tree, and it requires qqwing as a dependency. QQwing didn't seem to fit > in any other category so I put it in it's own file. > > Guidance would be appreciated! Thank you in advance. Thanks for trying something new :) I think they both would fit in games.scm. Can you put them there in a revised patch series? > * gnu/packages/qqwing.scm (qqwing): New variable. > * gnu/packages/gnome.scm (gnome-sudoku): New variable. We like to add packages as separate commits. Can you separate them in the revised patch series? Also, remember to add a copyright line for yourself at the top of the file. > +(define-public gnome-sudoku Okay with the changes requested above. > +(define-public qqwing [...] > + (uri (string-append > + "mirror://debian/pool/main/q/qqwing/" > + name "_" version ".orig.tar.gz")) Why download the source code from Debian instead of https://qqwing.com (which redirects to GitHub)? > + (synopsis "Software for working with sudoku puzzles.") Can you capitalize Sudoku here? Also be sure to run `guix lint` on these packages; the linter should complain about the period in the synopsis. > + (description > + "QQwing is software for generating and solving Sudoku puzzles.") Sometimes there isn't much to say. But can you try to add a little more here? You could look for inspiration in the man page.