From mboxrd@z Thu Jan  1 00:00:00 1970
From: Eric Bavier <ericbavier@openmailbox.org>
Subject: Re: [PATCH] gnu: fontforge: Update to 20160404.
Date: Thu, 7 Apr 2016 22:39:38 -0500
Message-ID: <20160407223938.1c517e1e@openmailbox.org>
References: <CALkz57FNn-wZiTJbFOv-x+=FnOQUe4nwPmAx5GChXXw_jFbj5g@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43343)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ericbavier@openmailbox.org>) id 1aoNH2-0003v9-EM
	for guix-devel@gnu.org; Thu, 07 Apr 2016 23:39:57 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ericbavier@openmailbox.org>) id 1aoNGz-00047B-84
	for guix-devel@gnu.org; Thu, 07 Apr 2016 23:39:56 -0400
Received: from mail2.openmailbox.org ([62.4.1.33]:35419)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ericbavier@openmailbox.org>) id 1aoNGy-000476-VN
	for guix-devel@gnu.org; Thu, 07 Apr 2016 23:39:53 -0400
In-Reply-To: <CALkz57FNn-wZiTJbFOv-x+=FnOQUe4nwPmAx5GChXXw_jFbj5g@mail.gmail.com>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: =?UTF-8?B?YWzDrXJpbw==?= eyng <alirioeyng@gmail.com>
Cc: guix-devel@gnu.org

On Thu, 7 Apr 2016 19:18:35 +0000
al=C3=ADrio eyng <alirioeyng@gmail.com> wrote:

> * gnu/packages/fontutils.scm (fontforge): Update to 20160404.
> [source](snippet): Remove tottf.c modification.
> ---
>  gnu/packages/fontutils.scm | 13 ++++---------
>  1 file changed, 4 insertions(+), 9 deletions(-)
>=20
> diff --git a/gnu/packages/fontutils.scm b/gnu/packages/fontutils.scm
> index ff10a4a..bb93421 100644
> --- a/gnu/packages/fontutils.scm
> +++ b/gnu/packages/fontutils.scm
> @@ -341,14 +341,14 @@ definitions.")
>  (define-public fontforge
>    (package
>     (name "fontforge")
> -   (version "20150824")
> +   (version "20160404")
>     (source (origin
>              (method url-fetch)
>              (uri (string-append
>                    "https://github.com/fontforge/fontforge/releases/downl=
oad/"
> -                  version "/fontforge-" version ".tar.gz"))
> +                  version "/fontforge-dist-" version ".tar.gz"))
>              (sha256 (base32
> -                     "0gfcm8yn1d30giqhdwbchnfnspcqypqdzrxlhqhwy1i18wgl0v=
2v"))
> +                     "1kavnhbkzc1hk6f39fynq9s0haama81ddrbld4b5x60d0dbaaw=
vc"))
>              (modules '((guix build utils)))
>              (snippet
>               '(begin
> @@ -359,12 +359,7 @@ definitions.")
>                   (("^FONTFORGE_MODTIME_STR=3D.*$")
>                    "FONTFORGE_MODTIME_STR=3D\"15:50 CET 19-Mar-2016\"\n")
>                   (("^FONTFORGE_VERSIONDATE=3D.*$")
> -                  "FONTFORGE_VERSIONDATE=3D\"20160319\"\n"))
> -
> -               ;; Make TTF builds bit-reproducible by clearing the times=
tamp
> -               ;; that goes in TTF files.
> -               (substitute* "fontforge/tottf.c"
> -                 (("cvt_unix_to_1904\\(now") "cvt_unix_to_1904(0"))))))
> +                  "FONTFORGE_VERSIONDATE=3D\"20160319\"\n"))))))

I'm glad they fixed the TTF reproducibility upstream.  Does
FONTFORGE_VERSIONDATE not need to be updated?

LGTM,
`~Eric