From mboxrd@z Thu Jan  1 00:00:00 1970
From: Leo Famulari <leo@famulari.name>
Subject: Re: [PATCH] gnu: Add macchanger.
Date: Thu, 7 Apr 2016 11:39:23 -0400
Message-ID: <20160407153923.GC18750@jasmine>
References: <1460026890-5027-1-git-send-email-jmd@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51810)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1aoC1Y-0007YO-RK
	for guix-devel@gnu.org; Thu, 07 Apr 2016 11:39:13 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1aoC1T-0006lB-SC
	for guix-devel@gnu.org; Thu, 07 Apr 2016 11:39:12 -0400
Received: from out5-smtp.messagingengine.com ([66.111.4.29]:51508)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1aoC1T-0006l1-Nf
	for guix-devel@gnu.org; Thu, 07 Apr 2016 11:39:07 -0400
Content-Disposition: inline
In-Reply-To: <1460026890-5027-1-git-send-email-jmd@gnu.org>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: John Darrington <jmd@gnu.org>
Cc: guix-devel@gnu.org

On Thu, Apr 07, 2016 at 01:01:30PM +0200, John Darrington wrote:
> * gnu/packages/networking.scm (macchanger): New variable.

Looks good, except for some extra whitespace and a missing copyright
line for you :)

> ---
>  gnu/packages/networking.scm | 22 ++++++++++++++++++++++
>  1 file changed, 22 insertions(+)
> 
> diff --git a/gnu/packages/networking.scm b/gnu/packages/networking.scm
> index a4f431a..20f7e73 100644
> --- a/gnu/packages/networking.scm
> +++ b/gnu/packages/networking.scm
> @@ -32,6 +32,28 @@
>    #:use-module (gnu packages pkg-config)
>    #:use-module (gnu packages compression))
>  
> +
  ^ Extraneous newline

> +(define-public macchanger
> +  (package
> +    (name "macchanger")
> +    (version "1.6.0")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append "mirror://gnu/"
> +                                  name "/" name "-" version ".tar.gz"))
> +              (sha256
> +               (base32
> +                "1xsiivjjyhqcs6dyjcshrnxlgypvyfzacjz7gcjgl88xiw9lylri"))))
> +    (build-system gnu-build-system)
> +    (home-page "http://www.gnu.org/software/macchanger")
> +    (synopsis "Display or change the MAC address of networking devices")
> +    (description "GNU MAC Changer is a utility for viewing and changing MAC
> +addresses of networking devices.  New addresses may be set explicitly or
> +randomly.  They can include MAC addresses of the same or other hardware vendors
> +or, more generally, MAC addresses of the same category of hardware.") 
                                                                        ^
									extraneous
									whitespace
> +    (license license:gpl2+)))
> +
> +
  ^ Extraneous newline

>  (define-public miredo
>    (package
>      (name "miredo")
> -- 
> 2.1.4
> 
>