From: Leo Famulari <leo@famulari.name>
To: John Darrington <jmd@gnu.org>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: Add macchanger.
Date: Thu, 7 Apr 2016 11:39:23 -0400 [thread overview]
Message-ID: <20160407153923.GC18750@jasmine> (raw)
In-Reply-To: <1460026890-5027-1-git-send-email-jmd@gnu.org>
On Thu, Apr 07, 2016 at 01:01:30PM +0200, John Darrington wrote:
> * gnu/packages/networking.scm (macchanger): New variable.
Looks good, except for some extra whitespace and a missing copyright
line for you :)
> ---
> gnu/packages/networking.scm | 22 ++++++++++++++++++++++
> 1 file changed, 22 insertions(+)
>
> diff --git a/gnu/packages/networking.scm b/gnu/packages/networking.scm
> index a4f431a..20f7e73 100644
> --- a/gnu/packages/networking.scm
> +++ b/gnu/packages/networking.scm
> @@ -32,6 +32,28 @@
> #:use-module (gnu packages pkg-config)
> #:use-module (gnu packages compression))
>
> +
^ Extraneous newline
> +(define-public macchanger
> + (package
> + (name "macchanger")
> + (version "1.6.0")
> + (source (origin
> + (method url-fetch)
> + (uri (string-append "mirror://gnu/"
> + name "/" name "-" version ".tar.gz"))
> + (sha256
> + (base32
> + "1xsiivjjyhqcs6dyjcshrnxlgypvyfzacjz7gcjgl88xiw9lylri"))))
> + (build-system gnu-build-system)
> + (home-page "http://www.gnu.org/software/macchanger")
> + (synopsis "Display or change the MAC address of networking devices")
> + (description "GNU MAC Changer is a utility for viewing and changing MAC
> +addresses of networking devices. New addresses may be set explicitly or
> +randomly. They can include MAC addresses of the same or other hardware vendors
> +or, more generally, MAC addresses of the same category of hardware.")
^
extraneous
whitespace
> + (license license:gpl2+)))
> +
> +
^ Extraneous newline
> (define-public miredo
> (package
> (name "miredo")
> --
> 2.1.4
>
>
prev parent reply other threads:[~2016-04-07 15:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-07 11:01 [PATCH] gnu: Add macchanger John Darrington
2016-04-07 15:39 ` Leo Famulari [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160407153923.GC18750@jasmine \
--to=leo@famulari.name \
--cc=guix-devel@gnu.org \
--cc=jmd@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.