From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Bavier Subject: Re: [PATCH 1/2] build: Move included files to subdirectories. Date: Sun, 3 Apr 2016 21:36:16 -0500 Message-ID: <20160403213616.52b60218@openmailbox.org> References: <1459700326-30016-1-git-send-email-mthl@gnu.org> <1459700326-30016-2-git-send-email-mthl@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:60956) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1amuNa-0006bN-4S for guix-devel@gnu.org; Sun, 03 Apr 2016 22:36:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1amuNW-0003XJ-F2 for guix-devel@gnu.org; Sun, 03 Apr 2016 22:36:38 -0400 Received: from smtp6.openmailbox.org ([62.4.1.40]:56609) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1amuNW-0003XE-9B for guix-devel@gnu.org; Sun, 03 Apr 2016 22:36:34 -0400 In-Reply-To: <1459700326-30016-2-git-send-email-mthl@gnu.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Mathieu Lirzin Cc: guix-devel@gnu.org On Sun, 3 Apr 2016 18:18:45 +0200 Mathieu Lirzin wrote: > This follows a convention used by some other GNU packages like Autoconf, > Bison, Coreutils, and Gnulib. > > * doc.am: Rename to ... > * doc/local.mk: ... this. > * emacs.am: Rename to ... > * emacs/local.mk: ... this. > * gnu-system.am: Rename to ... > * gnu/local.mk: ... this. > * daemon.am: Rename to ... > * nix/local.mk: ... this. > * Makefile.am: Adapt to them. > * doc/guix.texi (Porting to a New Platform): Adapt documentation. > * guix/config.scm.in (%state-directory, %config-directory): Adapt comments. > * emacs/guix-config.el.in (guix-config-state-directory): Likewise. > --- > Makefile.am | 8 +- > daemon.am | 226 ------------- > doc.am | 157 --------- > doc/guix.texi | 2 +- > doc/local.mk | 157 +++++++++ > emacs.am | 73 ---- > emacs/guix-config.el.in | 2 +- > emacs/local.mk | 73 ++++ > gnu-system.am | 883 ------------------------------------------------ > gnu/local.mk | 883 ++++++++++++++++++++++++++++++++++++++++++++++++ > guix/config.scm.in | 4 +- > nix/local.mk | 226 +++++++++++++ > 12 files changed, 1347 insertions(+), 1347 deletions(-) > delete mode 100644 daemon.am > delete mode 100644 doc.am > create mode 100644 doc/local.mk > delete mode 100644 emacs.am > create mode 100644 emacs/local.mk > delete mode 100644 gnu-system.am > create mode 100644 gnu/local.mk > create mode 100644 nix/local.mk > I don't prefer the "local.mk" convention. It becomes non-obvious that the file is input for Automake, and the name loses any descriptive power. Just my 2 cents. `~Eric