From mboxrd@z Thu Jan  1 00:00:00 1970
From: Leo Famulari <leo@famulari.name>
Subject: Re: [PATCH 2/3] gnu: util-linux: Add "static" output.
Date: Sun, 3 Apr 2016 15:21:37 -0400
Message-ID: <20160403192137.GA20109@jasmine>
References: <1459603774-9455-1-git-send-email-tobias.geerinckx.rice@gmail.com>
	<1459603774-9455-3-git-send-email-tobias.geerinckx.rice@gmail.com>
	<20160403005357.GF4959@jasmine> <57016102.2090500@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53614)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1amnag-0004FV-Gn
	for guix-devel@gnu.org; Sun, 03 Apr 2016 15:21:43 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1amnad-0004o4-9A
	for guix-devel@gnu.org; Sun, 03 Apr 2016 15:21:42 -0400
Received: from out3-smtp.messagingengine.com ([66.111.4.27]:48289)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1amnad-0004o0-2d
	for guix-devel@gnu.org; Sun, 03 Apr 2016 15:21:39 -0400
Content-Disposition: inline
In-Reply-To: <57016102.2090500@gmail.com>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Tobias Geerinckx-Rice <tobias.geerinckx.rice@gmail.com>
Cc: guix-devel@gnu.org

On Sun, Apr 03, 2016 at 08:29:22PM +0200, Tobias Geerinckx-Rice wrote:
> Hullo Leo,
> 
> Thanks, as always, for the review!
> 
> On 03/04/16 02:53, Leo Famulari wrote:
> > On Sat, Apr 02, 2016 at 03:29:33PM +0200, Tobias Geerinckx-Rice wrote:
> >> +                  (add-after
> >> +                   'install 'move-static-libraries
> > 
> > How about calling the phase 'install-static' as in your btrfs-progs
> > patch?
> 
> The two phases do subtly (?) different things. INSTALL-STATIC calls an
> additional ‘make install-static’ target that wouldn't be run otherwise.
> MOVE-STATIC-LIBRARIES moves some static files already installed to OUT
> by the default 'install phase to a different output, STATIC.
> 
> I don't think drawing explicit parallels between the two (by choosing
> identical names) makes anything any clearer, but have no strong feelings
> either way.

Okay, that makes sense.

> 
> Kind regards,
> 
> T G-R
>