From mboxrd@z Thu Jan  1 00:00:00 1970
From: Leo Famulari <leo@famulari.name>
Subject: Re: [v2 2/2] gnu: Add signify.
Date: Sat, 2 Apr 2016 13:22:37 -0400
Message-ID: <20160402172237.GB1481@jasmine>
References: <cover.1459560195.git.leo@famulari.name>
	<521584dad223b3cb86c5a11ec2107a8eddf6474b.1459560195.git.leo@famulari.name>
	<8760w0a1va.fsf@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33281)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1amPFx-0005gB-Rt
	for guix-devel@gnu.org; Sat, 02 Apr 2016 13:22:42 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1amPFu-0006qf-LG
	for guix-devel@gnu.org; Sat, 02 Apr 2016 13:22:41 -0400
Received: from out3-smtp.messagingengine.com ([66.111.4.27]:36862)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1amPFu-0006qb-HG
	for guix-devel@gnu.org; Sat, 02 Apr 2016 13:22:38 -0400
Received: from compute3.internal (compute3.nyi.internal [10.202.2.43])
	by mailout.nyi.internal (Postfix) with ESMTP id 6BADC2031C
	for <guix-devel@gnu.org>; Sat,  2 Apr 2016 13:22:38 -0400 (EDT)
Content-Disposition: inline
In-Reply-To: <8760w0a1va.fsf@gmail.com>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Alex Kost <alezost@gmail.com>
Cc: guix-devel@gnu.org

On Sat, Apr 02, 2016 at 10:47:21AM +0300, Alex Kost wrote:
> Leo Famulari (2016-04-02 04:24 +0300) wrote:
> 
> > * gnu/packages/crypto.scm (signify): New variable.
> > ---
> >  gnu/packages/crypto.scm | 35 +++++++++++++++++++++++++++++++++++
> >  1 file changed, 35 insertions(+)
> [...]
> > +(define-public signify
> > +  (package
> > +    (name "signify")
> > +    (version "17")
> > +    (source (origin
> > +              (method url-fetch)
> > +              (uri (string-append "https://github.com/aperezdc/signify/"
> > +                                  "archive/v" version ".tar.gz"))
> 
> Don't forget about "guix lint": you are missing (file-name ...) field here.
> 
> > +              (sha256
> > +               (base32
> > +                "0kfv2k1fqck31vwlnicavb0h541ilad9zd7j8zz8x2kx36wwqpr7"))))
> > +    (build-system gnu-build-system)
> > +    ;; TODO Build with libwaive (described in README.md), to implement something
> > +    ;; like OpenBSD's pledge().
> > +    (arguments
> > +     `(#:make-flags
> > +       (list "CC=gcc"
> > +             (string-append "PREFIX=" (assoc-ref %outputs "out")))
> > +       #:phases
> > +       (modify-phases %standard-phases
> > +         (delete 'configure)
> > +         (delete 'check)))) ; no test suite
> 
> I think it's better to add “#:tests? #f” to arguments instead, as we do
> for other packages.
> 
> > +    (native-inputs
> > +     `(("pkg-config" ,pkg-config)))
> > +    (inputs
> > +     `(("libbsd" ,libbsd)))
> > +    (synopsis "Create and verify cryptographic signatures")
> > +    (description "The signify utility creates and verifies cryptographic
> > +signatures using the elliptic curve Ed25519.")
> > +    (home-page "https://github.com/aperezdc/signify")
> > +    (license (list bsd-3 bsd-4 isc public-domain non-copyleft))))
> 
> The same note as for 'libbsd': non-copyleft is a procedure.

Thanks for the review! I've made all the requested changes.