From mboxrd@z Thu Jan 1 00:00:00 1970 From: Leo Famulari Subject: Re: [v2 1/2] gnu: Add libbsd. Date: Sat, 2 Apr 2016 13:21:35 -0400 Message-ID: <20160402172135.GA1481@jasmine> References: <877fgga1vh.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:33037) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1amPEy-0005QJ-CR for guix-devel@gnu.org; Sat, 02 Apr 2016 13:21:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1amPEv-0006fC-5o for guix-devel@gnu.org; Sat, 02 Apr 2016 13:21:40 -0400 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:40964) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1amPEu-0006f1-VO for guix-devel@gnu.org; Sat, 02 Apr 2016 13:21:37 -0400 Content-Disposition: inline In-Reply-To: <877fgga1vh.fsf@gmail.com> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Alex Kost Cc: guix-devel@gnu.org On Sat, Apr 02, 2016 at 10:47:14AM +0300, Alex Kost wrote: > Leo Famulari (2016-04-02 04:24 +0300) wrote: > > > * gnu/packages/libbsd.scm: New file. > > * gnu-system.am (GNU_SYSTEM_MODULES): Add it. > > --- > > gnu-system.am | 1 + > > gnu/packages/libbsd.scm | 43 +++++++++++++++++++++++++++++++++++++++++++ > > 2 files changed, 44 insertions(+) > > create mode 100644 gnu/packages/libbsd.scm > [...] > > +(define-public libbsd > > + (package > > + (name "libbsd") > > + (version "0.8.2") > > + (source (origin > > + (method url-fetch) > > + (uri (string-append "https://libbsd.freedesktop.org/releases/" > > + "libbsd-" version ".tar.xz")) > > + (sha256 > > + (base32 > > + "02i5brb2007sxq3mn862mr7yxxm0g6nj172417hjyvjax7549xmj")))) > > + (build-system gnu-build-system) > > + (synopsis "Utility functions from BSD systems") > > + (description "This library provides useful functions commonly found on BSD > > +systems, and lacking on others like GNU systems, thus making it easier to port > > +projects with strong BSD origins, without needing to embed the same code over > > +and over again on each project.") > > + (home-page "https://libbsd.freedesktop.org/wiki/") > > + (license (list bsd-2 bsd-3 bsd-4 bsd-style expat isc public-domain non-copyleft)))) > > Wow, a lot of licenses! "guix lint" reports: "invalid license field". > This happens because 'non-copyleft' is a procedure, not a license. Look > at other packages to see how it is used. Also, please don't make such > long lines. Overall it would be something like this: > > (license (list bsd-2 bsd-3 bsd-4 bsd-style expat isc public-domain > (non-copyleft "file://COPYING" > "See COPYING in the distribution."))) Ah, sorry for wasting your time by not linting! Thanks for the instructions. > The rest looks good to me, thanks! Okay!