From mboxrd@z Thu Jan 1 00:00:00 1970 From: Danny Milosavljevic Subject: Re: Patches to add s3cmd and python-magic Date: Mon, 28 Mar 2016 22:35:42 +0200 Message-ID: <20160328223542.5c66e67e@scratchpost.org> References: <87io071dqo.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:49144) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1akdt8-0000l7-ON for guix-devel@gnu.org; Mon, 28 Mar 2016 16:35:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1akdt4-00030R-LG for guix-devel@gnu.org; Mon, 28 Mar 2016 16:35:50 -0400 Received: from dd1012.kasserver.com ([85.13.128.8]:55969) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1akdt4-00030M-Ed for guix-devel@gnu.org; Mon, 28 Mar 2016 16:35:46 -0400 In-Reply-To: <87io071dqo.fsf@gmail.com> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Chris Marusich Cc: guix-devel@gnu.org > * Do I need to provide setuptools as a native input, or will it be > pulled in automatically? I think you need to provide it. Try removing it. Does your package still build? > * Does setuptools really need to be a native input, or can it be a > regular input? I understand that native inputs are important for > cross-compiling, but does this apply to a language like Python which > compiles to bytecode for a virtual machine? If it's used only at build time, it's a native input. If it's used at runtime, regular input (if possible). I don't think setuptools is running when s3cmd is running, so just have it as a native input. As for the cross-compiling, you're right, I don't think it's important in this case. However, I think for documentation purposes it would still be nice to see which of the things are required only for the build (the native inputs - after all, they wouldn't work at runtime in general). > * In the package definition for python2-s3cmd, should python2-magic be a > propagated input instead of a regular input? It seems to work as a > normal input, so I think the answer is "no", but I understand that > sometimes this matters for python packages. If it works as a regular input, that's even better, so keep it only as regular input. Unfortunately, that's very seldom. The propagated input would mean that when you ask for package A in your profile, you'd get package A and B in your profile, for your own good. When testing s3cmd, make sure that python2-magic is not in your profile (for example installed manually via guix package -i python2-magic).