From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kei Yamashita Subject: Re: [PATCH] Add MilkyTracker to Guix Date: Mon, 28 Mar 2016 15:31:44 -0400 Message-ID: <20160328153144.47e24e70@openmailbox.org> References: <6dae35698781717e6043be7086b6f63c@openmailbox.org> <20160327072337.GA13339@debian-netbook> <20160327230935.14e8ba5a@openmailbox.org> <87shzayj69.fsf@gmail.com> <87vb46ispl.fsf@elephly.net> <20160328133050.72048b52@openmailbox.org> <20160328133931.4307044a@openmailbox.org> <20160328134320.1e0a50ae@openmailbox.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:60885) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1akctU-0000rb-DD for guix-devel@gnu.org; Mon, 28 Mar 2016 15:32:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1akctQ-0002Ey-89 for guix-devel@gnu.org; Mon, 28 Mar 2016 15:32:08 -0400 Received: from smtp25.openmailbox.org ([62.4.1.59]:33266) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1akctP-00026u-VY for guix-devel@gnu.org; Mon, 28 Mar 2016 15:32:04 -0400 In-Reply-To: <20160328134320.1e0a50ae@openmailbox.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: guix-devel@gnu.org On Mon, 28 Mar 2016 13:43:20 -0400 Kei Yamashita wrote: > On Mon, 28 Mar 2016 13:39:31 -0400 > Kei Yamashita wrote: >=20 > > On Mon, 28 Mar 2016 13:30:50 -0400 > > Kei Yamashita wrote: > > =20 > > > On Mon, 28 Mar 2016 16:26:46 +0200 > > > Ricardo Wurmus wrote: > > > =20 > > > > Alex Kost writes: > > > > =20 > > > > > Kei Yamashita (2016-03-28 06:09 +0300) wrote: > > > > > =20 > > > > >> On Sun, 27 Mar 2016 10:23:37 +0300 > > > > >> Efraim Flashner wrote: =20 > > > > >>> On Fri, Mar 25, 2016 at 07:54:40PM -0400, > > > > >>> kei@openmailbox.org wrote: =20 > > > > > [...] =20 > > > > >>> > + (arguments > > > > >>> > + '(#:configure-flags `("--without-alsa" > > > > >>> > "--without-jack"))) =20 > > > > >>> > > > > >>> In addition to Nil's comments, I was wondering about the > > > > >>> configure flags. Wouldn't it make sense to have either alsa > > > > >>> or jack as an input? =20 > > > > >> > > > > >> Milkytracker works fine without it on my machine. I feel like > > > > >> it's a matter of allowing the user options or sticking to the > > > > >> minimal build. =20 > > > > > > > > > > In my understanding (I may be wrong) our policy is to provide > > > > > full-featured software, so the features shouldn't be disabled > > > > > without a reason. Sometimes we add minimal packages (e.g., > > > > > "bash-minimal", "cups-minimal") if they are needed, but this > > > > > is not such a case. > > > > > > > > > > So I think you should remove these --without-=E2=80=A6 flags. And > > > > > thanks for contributing! =20 > > > >=20 > > > > I agree. Also, JACK and ALSA are ubiquitous among Guix > > > > audio/music packages. When the programme comes with support for > > > > ALSA and JACK backends by default I think we should not disable > > > > it. > > > >=20 > > > > ~~ Ricardo > > > > =20 > > >=20 > > > Noted. New patch attached. =20 > >=20 > > Oh geez, that one doesn't build. Please use this patch instead. =20 >=20 > Oh, the embarassment. I promise that this one builds. Is anyone else having trouble with the ALSA support?