From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kei Yamashita Subject: Re: [PATCH] Add MilkyTracker to Guix Date: Mon, 28 Mar 2016 13:43:20 -0400 Message-ID: <20160328134320.1e0a50ae@openmailbox.org> References: <6dae35698781717e6043be7086b6f63c@openmailbox.org> <20160327072337.GA13339@debian-netbook> <20160327230935.14e8ba5a@openmailbox.org> <87shzayj69.fsf@gmail.com> <87vb46ispl.fsf@elephly.net> <20160328133050.72048b52@openmailbox.org> <20160328133931.4307044a@openmailbox.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="MP_/PAMVanWgPHMJAY6DrLbnWS7" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:54691) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1akbCV-0002xP-UV for guix-devel@gnu.org; Mon, 28 Mar 2016 13:43:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1akbCR-0007d9-Ex for guix-devel@gnu.org; Mon, 28 Mar 2016 13:43:39 -0400 Received: from smtp7.openmailbox.org ([62.4.1.41]:45772) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1akbCR-0007d1-6p for guix-devel@gnu.org; Mon, 28 Mar 2016 13:43:35 -0400 In-Reply-To: <20160328133931.4307044a@openmailbox.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: guix-devel@gnu.org --MP_/PAMVanWgPHMJAY6DrLbnWS7 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline On Mon, 28 Mar 2016 13:39:31 -0400 Kei Yamashita wrote: > On Mon, 28 Mar 2016 13:30:50 -0400 > Kei Yamashita wrote: >=20 > > On Mon, 28 Mar 2016 16:26:46 +0200 > > Ricardo Wurmus wrote: > >=20 > > > Alex Kost writes: > > > =20 > > > > Kei Yamashita (2016-03-28 06:09 +0300) wrote: > > > > =20 > > > >> On Sun, 27 Mar 2016 10:23:37 +0300 > > > >> Efraim Flashner wrote: =20 > > > >>> On Fri, Mar 25, 2016 at 07:54:40PM -0400, kei@openmailbox.org > > > >>> wrote: =20 > > > > [...] =20 > > > >>> > + (arguments > > > >>> > + '(#:configure-flags `("--without-alsa" > > > >>> > "--without-jack"))) =20 > > > >>> > > > >>> In addition to Nil's comments, I was wondering about the > > > >>> configure flags. Wouldn't it make sense to have either alsa or > > > >>> jack as an input? =20 > > > >> > > > >> Milkytracker works fine without it on my machine. I feel like > > > >> it's a matter of allowing the user options or sticking to the > > > >> minimal build. =20 > > > > > > > > In my understanding (I may be wrong) our policy is to provide > > > > full-featured software, so the features shouldn't be disabled > > > > without a reason. Sometimes we add minimal packages (e.g., > > > > "bash-minimal", "cups-minimal") if they are needed, but this is > > > > not such a case. > > > > > > > > So I think you should remove these --without-=E2=80=A6 flags. And > > > > thanks for contributing! =20 > > >=20 > > > I agree. Also, JACK and ALSA are ubiquitous among Guix > > > audio/music packages. When the programme comes with support for > > > ALSA and JACK backends by default I think we should not disable > > > it. > > >=20 > > > ~~ Ricardo > > > =20 > >=20 > > Noted. New patch attached. >=20 > Oh geez, that one doesn't build. Please use this patch instead. Oh, the embarassment. I promise that this one builds. --MP_/PAMVanWgPHMJAY6DrLbnWS7 Content-Type: application/octet-stream; name=0001-Define-MilkyTracker-in-music.scm.patch Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename=0001-Define-MilkyTracker-in-music.scm.patch RnJvbSA0NmI5N2I0MDkwMDBiNmNhYTI3ZjNhZDI3ZGY3YTQ0Y2E5ZTk1MTBjIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBLZWkgWWFtYXNoaXRhIDxrZWlAb3Blbm1haWxib3gub3JnPgpE YXRlOiBNb24sIDI4IE1hciAyMDE2IDEzOjM2OjI2IC0wNDAwClN1YmplY3Q6IFtQQVRDSF0gRGVm aW5lIE1pbGt5VHJhY2tlciBpbiBtdXNpYy5zY20KCi0tLQogZ251L3BhY2thZ2VzL211c2ljLnNj bSB8IDQyICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKystLS0tLS0tLQogMSBmaWxl IGNoYW5nZWQsIDM0IGluc2VydGlvbnMoKyksIDggZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEv Z251L3BhY2thZ2VzL211c2ljLnNjbSBiL2dudS9wYWNrYWdlcy9tdXNpYy5zY20KaW5kZXggYWRk YTE2YS4uMjM5NjRkNSAxMDA2NDQKLS0tIGEvZ251L3BhY2thZ2VzL211c2ljLnNjbQorKysgYi9n bnUvcGFja2FnZXMvbXVzaWMuc2NtCkBAIC03OCw2ICs3OCw3IEBACiAgICM6dXNlLW1vZHVsZSAo Z251IHBhY2thZ2VzIHJkZikKICAgIzp1c2UtbW9kdWxlIChnbnUgcGFja2FnZXMgcmVhZGxpbmUp CiAgICM6dXNlLW1vZHVsZSAoZ251IHBhY2thZ2VzIHJzeW5jKQorICAjOnVzZS1tb2R1bGUgKGdu dSBwYWNrYWdlcyBzZGwpCiAgICM6dXNlLW1vZHVsZSAoZ251IHBhY2thZ2VzIHRjbCkKICAgIzp1 c2UtbW9kdWxlIChnbnUgcGFja2FnZXMgdGV4aW5mbykKICAgIzp1c2UtbW9kdWxlIChnbnUgcGFj a2FnZXMgdGV4bGl2ZSkKQEAgLTEwNzEsMTQgKzEwNzIsMTQgQEAgY29tcHV0ZXIncyBrZXlib2Fy ZC4iKQogKGRlZmluZS1wdWJsaWMgcXRyYWN0b3IKICAgKHBhY2thZ2UKICAgICAobmFtZSAicXRy YWN0b3IiKQotICAgICh2ZXJzaW9uICIwLjcuNSIpCisgICAgKHZlcnNpb24gIjAuNy4zIikKICAg ICAoc291cmNlIChvcmlnaW4KICAgICAgICAgICAgICAgKG1ldGhvZCB1cmwtZmV0Y2gpCiAgICAg ICAgICAgICAgICh1cmkgKHN0cmluZy1hcHBlbmQgImh0dHA6Ly9kb3dubG9hZHMuc291cmNlZm9y Z2UubmV0L3F0cmFjdG9yLyIKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAicXRy YWN0b3ItIiB2ZXJzaW9uICIudGFyLmd6IikpCiAgICAgICAgICAgICAgIChzaGEyNTYKICAgICAg ICAgICAgICAgIChiYXNlMzIKLSAgICAgICAgICAgICAgICAiMGRycXpwMXJicW1xaXdkemM5bjMz MDd5OHJtODgyZmhhM2F3eTVxbHZpcjVtYTJtd2w4MCIpKSkpCisgICAgICAgICAgICAgICAgIjF2 eTQyOTdteXlxazBrNThuenliZ3Zna2xja2huZ3BkY25tcDk4azBycTk4ZGlyY2xibDciKSkpKQog ICAgIChidWlsZC1zeXN0ZW0gZ251LWJ1aWxkLXN5c3RlbSkKICAgICAoYXJndW1lbnRzIGAoIzp0 ZXN0cz8gI2YpKSA7IG5vICJjaGVjayIgdGFyZ2V0CiAgICAgKGlucHV0cwpAQCAtMTIwMSw4ICsx MjAyLDkgQEAgTXVzaWNCcmFpbnogZGF0YWJhc2UuIikKICAgICAoYnVpbGQtc3lzdGVtIHB5dGhv bi1idWlsZC1zeXN0ZW0pCiAgICAgKGhvbWUtcGFnZSAiaHR0cHM6Ly9naXRodWIuY29tL2VjaG9u ZXN0L3B5ZWNob25lc3QiKQogICAgIChzeW5vcHNpcyAiUHl0aG9uIGludGVyZmFjZSB0byBUaGUg RWNobyBOZXN0IEFQSXMiKQotICAgIChkZXNjcmlwdGlvbiAiUHllY2hvbmVzdCBpcyBhIFB5dGhv biBsaWJyYXJ5IGZvciB0aGUgRWNobyBOZXN0IEFQSS4gIFdpdGgKLVB5ZWNob25lc3QgeW91IGhh dmUgUHl0aG9uIGFjY2VzcyB0byB0aGUgZW50aXJlIHNldCBvZiBBUEkgbWV0aG9kcyBpbmNsdWRp bmc6CisgICAgKGRlc2NyaXB0aW9uICJQeWVjaG9uZXN0IGlzIGFuIG9wZW4gc291cmNlIFB5dGhv biBsaWJyYXJ5IGZvciB0aGUgRWNobyBOZXN0CitBUEkuICBXaXRoIFB5ZWNob25lc3QgeW91IGhh dmUgUHl0aG9uIGFjY2VzcyB0byB0aGUgZW50aXJlIHNldCBvZiBBUEkgbWV0aG9kcworaW5jbHVk aW5nOgogCiBAZW51bWVyYXRlCiBAaXRlbSBhcnRpc3QgLSBzZWFyY2ggZm9yIGFydGlzdHMgYnkg bmFtZSwgZGVzY3JpcHRpb24sIG9yIGF0dHJpYnV0ZSwgYW5kIGdldApAQCAtMTI3NCwxNiArMTI3 NiwxMyBAQCB3ZWJzaXRlcyBzdWNoIGFzIExpYnJlLmZtLiIpCiAgICAgICAgIzpwaGFzZXMKICAg ICAgICAobW9kaWZ5LXBoYXNlcyAlc3RhbmRhcmQtcGhhc2VzCiAgICAgICAgICAoYWRkLWFmdGVy ICd1bnBhY2sgJ3NldC1IT01FCi0gICAgICAgICAgIChsYW1iZGEgXyAoc2V0ZW52ICJIT01FIiAo c3RyaW5nLWFwcGVuZCAoZ2V0Y3dkKSAiL3RtcCIpKSkpCi0gICAgICAgICAocmVwbGFjZSAnY2hl Y2sKLSAgICAgICAgICAgKGxhbWJkYSBfICh6ZXJvPyAoc3lzdGVtKiAibm9zZXRlc3RzIiAiLXYi KSkpKSkpKQorICAgICAgICAgICAobGFtYmRhIF8gKHNldGVudiAiSE9NRSIgKHN0cmluZy1hcHBl bmQgKGdldGN3ZCkgIi90bXAiKSkpKSkpKQogICAgIChuYXRpdmUtaW5wdXRzCiAgICAgIGAoKCJw eXRob24yLWJlYXV0aWZ1bHNvdXA0IiAscHl0aG9uMi1iZWF1dGlmdWxzb3VwNCkKICAgICAgICAo InB5dGhvbjItZmxhc2siICxweXRob24yLWZsYXNrKQogICAgICAgICgicHl0aG9uMi1zZXR1cHRv b2xzIiAscHl0aG9uMi1zZXR1cHRvb2xzKQogICAgICAgICgicHl0aG9uMi1tb2NrIiAscHl0aG9u Mi1tb2NrKQogICAgICAgICgicHl0aG9uMi1tcGQyIiAscHl0aG9uMi1tcGQyKQotICAgICAgICgi cHl0aG9uMi1ub3NlIiAscHl0aG9uMi1ub3NlKQogICAgICAgICgicHl0aG9uMi1wYXRobGliIiAs cHl0aG9uMi1wYXRobGliKQogICAgICAgICgicHl0aG9uMi1weXhkZyIgLHB5dGhvbjItcHl4ZGcp CiAgICAgICAgKCJweXRob24yLXB5ZWNob25lc3QiICxweXRob24yLXB5ZWNob25lc3QpCkBAIC0x MzA2LDMgKzEzMDUsMzAgQEAgb25jZSBhbmQgZm9yIGFsbC4gIEl0IGNhdGFsb2dzIHlvdXIgY29s bGVjdGlvbiwgYXV0b21hdGljYWxseSBpbXByb3ZpbmcgaXRzCiBtZXRhZGF0YSBhcyBpdCBnb2Vz IHVzaW5nIHRoZSBNdXNpY0JyYWlueiBkYXRhYmFzZS4gIFRoZW4gaXQgcHJvdmlkZXMgYSB2YXJp ZXR5CiBvZiB0b29scyBmb3IgbWFuaXB1bGF0aW5nIGFuZCBhY2Nlc3NpbmcgeW91ciBtdXNpYy4i KQogICAgIChsaWNlbnNlIGxpY2Vuc2U6ZXhwYXQpKSkKKworKGRlZmluZS1wdWJsaWMgbWlsa3l0 cmFja2VyCisgIChwYWNrYWdlCisgICAgKG5hbWUgIm1pbGt5dHJhY2tlciIpCisgICAgKHZlcnNp b24gIjAuOTAuODYiKQorICAgIChzb3VyY2UgKG9yaWdpbgorCSAgICAgIChtZXRob2QgdXJsLWZl dGNoKQorCSAgICAgICh1cmkKKwkgICAgICAgKHN0cmluZy1hcHBlbmQgImh0dHA6Ly9taWxreXRy YWNrZXIub3JnL2ZpbGVzL21pbGt5dHJhY2tlci0iCisJCQkJICBuYW1lICItIiB2ZXJzaW9uICIu dGFyLmd6IikpCisgICAgICAgICAgICAgIChzaGEyNTYKKyAgICAgICAgICAgICAgIChiYXNlMzIK KyAgICAgICAgICAgICAgICAiMG1xamtodmp5cDVobnptMWxuM2IycWpjbHZpYXl4eWxjeW1sOTZw amR4Z2JhcWNxYTJ6eiIpKSkpCisgICAgKGJ1aWxkLXN5c3RlbSBnbnUtYnVpbGQtc3lzdGVtKQor ICAgIChpbnB1dHMKKyAgICAgYCgoImFsc2EtbGliIiwgYWxzYS1saWIpCisgICAgICAgKCJqYWNr IiwgamFjay0xKQorICAgICAgICgic2RsIiAsc2RsKQorICAgICAgICgiemxpYiIgLHpsaWIpKSkK KyAgICAoc3lub3BzaXMgIk11bHRpLXBsYXRmb3JtLCBzZWNvbmQgZ2VuZXJhdGlvbiBtdXNpYyB0 cmFja2VyIikKKyAgICAoZGVzY3JpcHRpb24gIk1pbGt5VHJhY2tlciBpcyBhIGZyZWUgc29mdHdh cmUsIG11bHRpLXBsYXRmb3JtIG11c2ljCithcHBsaWNhdGlvbiBmb3IgY3JlYXRpbmcgLk1PRCBh bmQgLlhNIG1vZHVsZSBmaWxlcy4gSXQgYXR0ZW1wdHMgdG8gcmVjcmVhdGUKK3RoZSBtb2R1bGUg cmVwbGF5IGFuZCB1c2VyIGV4cGVyaWVuY2Ugb2YgdGhlIHBvcHVsYXIgRE9TIHByb2dyYW0gRmFz dHRyYWNrZXIKK0lJLCB3aXRoIHNwZWNpYWwgcGxheWJhY2sgbW9kZXMgYXZhaWxhYmxlIGZvciBp bXByb3ZlZCBBbWlnYSBQcm9UcmFja2VyIDIvMworY29tcGF0aWJpbGl0eS4iKQorICAgIChob21l LXBhZ2UgImh0dHA6Ly9taWxreXRyYWNrZXIub3JnLyIpCisgICAgKGxpY2Vuc2UgbGljZW5zZTpn cGwzKSkpCi0tIAoyLjcuMwoK --MP_/PAMVanWgPHMJAY6DrLbnWS7--