From: Kei Yamashita <kei@openmailbox.org>
To: guix-devel@gnu.org
Subject: Re: [PATCH] Add MilkyTracker to Guix
Date: Mon, 28 Mar 2016 13:39:31 -0400 [thread overview]
Message-ID: <20160328133931.4307044a@openmailbox.org> (raw)
In-Reply-To: <20160328133050.72048b52@openmailbox.org>
[-- Attachment #1: Type: text/plain, Size: 1725 bytes --]
On Mon, 28 Mar 2016 13:30:50 -0400
Kei Yamashita <kei@openmailbox.org> wrote:
> On Mon, 28 Mar 2016 16:26:46 +0200
> Ricardo Wurmus <rekado@elephly.net> wrote:
>
> > Alex Kost <alezost@gmail.com> writes:
> >
> > > Kei Yamashita (2016-03-28 06:09 +0300) wrote:
> > >
> > >> On Sun, 27 Mar 2016 10:23:37 +0300
> > >> Efraim Flashner <efraim@flashner.co.il> wrote:
> > >>> On Fri, Mar 25, 2016 at 07:54:40PM -0400, kei@openmailbox.org
> > >>> wrote:
> > > [...]
> > >>> > + (arguments
> > >>> > + '(#:configure-flags `("--without-alsa"
> > >>> > "--without-jack")))
> > >>>
> > >>> In addition to Nil's comments, I was wondering about the
> > >>> configure flags. Wouldn't it make sense to have either alsa or
> > >>> jack as an input?
> > >>
> > >> Milkytracker works fine without it on my machine. I feel like
> > >> it's a matter of allowing the user options or sticking to the
> > >> minimal build.
> > >
> > > In my understanding (I may be wrong) our policy is to provide
> > > full-featured software, so the features shouldn't be disabled
> > > without a reason. Sometimes we add minimal packages (e.g.,
> > > "bash-minimal", "cups-minimal") if they are needed, but this is
> > > not such a case.
> > >
> > > So I think you should remove these --without-… flags. And thanks
> > > for contributing!
> >
> > I agree. Also, JACK and ALSA are ubiquitous among Guix audio/music
> > packages. When the programme comes with support for ALSA and JACK
> > backends by default I think we should not disable it.
> >
> > ~~ Ricardo
> >
>
> Noted. New patch attached.
Oh geez, that one doesn't build. Please use this patch instead.
[-- Attachment #2: 0001-Define-MilkyTracker-in-music.scm.patch --]
[-- Type: application/octet-stream, Size: 4122 bytes --]
From 46b97b409000b6caa27f3ad27df7a44ca9e9510c Mon Sep 17 00:00:00 2001
From: Kei Yamashita <kei@openmailbox.org>
Date: Mon, 28 Mar 2016 13:36:26 -0400
Subject: [PATCH] Define MilkyTracker in music.scm
---
gnu/packages/music.scm | 42 ++++++++++++++++++++++++++++++++++--------
1 file changed, 34 insertions(+), 8 deletions(-)
diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
index adda16a..23964d5 100644
--- a/gnu/packages/music.scm
+++ b/gnu/packages/music.scm
@@ -78,6 +78,7 @@
#:use-module (gnu packages rdf)
#:use-module (gnu packages readline)
#:use-module (gnu packages rsync)
+ #:use-module (gnu packages sdl)
#:use-module (gnu packages tcl)
#:use-module (gnu packages texinfo)
#:use-module (gnu packages texlive)
@@ -1071,14 +1072,14 @@ computer's keyboard.")
(define-public qtractor
(package
(name "qtractor")
- (version "0.7.5")
+ (version "0.7.3")
(source (origin
(method url-fetch)
(uri (string-append "http://downloads.sourceforge.net/qtractor/"
"qtractor-" version ".tar.gz"))
(sha256
(base32
- "0drqzp1rbqmqiwdzc9n3307y8rm882fha3awy5qlvir5ma2mwl80"))))
+ "1vy4297myyqk0k58nzybgvgklckhngpdcnmp98k0rq98dirclbl7"))))
(build-system gnu-build-system)
(arguments `(#:tests? #f)) ; no "check" target
(inputs
@@ -1201,8 +1202,9 @@ MusicBrainz database.")
(build-system python-build-system)
(home-page "https://github.com/echonest/pyechonest")
(synopsis "Python interface to The Echo Nest APIs")
- (description "Pyechonest is a Python library for the Echo Nest API. With
-Pyechonest you have Python access to the entire set of API methods including:
+ (description "Pyechonest is an open source Python library for the Echo Nest
+API. With Pyechonest you have Python access to the entire set of API methods
+including:
@enumerate
@item artist - search for artists by name, description, or attribute, and get
@@ -1274,16 +1276,13 @@ websites such as Libre.fm.")
#:phases
(modify-phases %standard-phases
(add-after 'unpack 'set-HOME
- (lambda _ (setenv "HOME" (string-append (getcwd) "/tmp"))))
- (replace 'check
- (lambda _ (zero? (system* "nosetests" "-v")))))))
+ (lambda _ (setenv "HOME" (string-append (getcwd) "/tmp")))))))
(native-inputs
`(("python2-beautifulsoup4" ,python2-beautifulsoup4)
("python2-flask" ,python2-flask)
("python2-setuptools" ,python2-setuptools)
("python2-mock" ,python2-mock)
("python2-mpd2" ,python2-mpd2)
- ("python2-nose" ,python2-nose)
("python2-pathlib" ,python2-pathlib)
("python2-pyxdg" ,python2-pyxdg)
("python2-pyechonest" ,python2-pyechonest)
@@ -1306,3 +1305,30 @@ once and for all. It catalogs your collection, automatically improving its
metadata as it goes using the MusicBrainz database. Then it provides a variety
of tools for manipulating and accessing your music.")
(license license:expat)))
+
+(define-public milkytracker
+ (package
+ (name "milkytracker")
+ (version "0.90.86")
+ (source (origin
+ (method url-fetch)
+ (uri
+ (string-append "http://milkytracker.org/files/milkytracker-"
+ name "-" version ".tar.gz"))
+ (sha256
+ (base32
+ "0mqjkhvjyp5hnzm1ln3b2qjclviayxylcyml96pjdxgbaqcqa2zz"))))
+ (build-system gnu-build-system)
+ (inputs
+ `(("alsa-lib", alsa-lib)
+ ("jack", jack-1)
+ ("sdl" ,sdl)
+ ("zlib" ,zlib)))
+ (synopsis "Multi-platform, second generation music tracker")
+ (description "MilkyTracker is a free software, multi-platform music
+application for creating .MOD and .XM module files. It attempts to recreate
+the module replay and user experience of the popular DOS program Fasttracker
+II, with special playback modes available for improved Amiga ProTracker 2/3
+compatibility.")
+ (home-page "http://milkytracker.org/")
+ (license license:gpl3)))
--
2.7.3
next prev parent reply other threads:[~2016-03-28 17:39 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-25 23:54 [PATCH] Add MilkyTracker to Guix kei
2016-03-26 10:11 ` Nils Gillmann
2016-03-27 7:23 ` Efraim Flashner
2016-03-28 3:09 ` Kei Yamashita
2016-03-28 10:46 ` Alex Kost
2016-03-28 14:26 ` Ricardo Wurmus
2016-03-28 17:30 ` Kei Yamashita
2016-03-28 17:39 ` Kei Yamashita [this message]
2016-03-28 17:43 ` Kei Yamashita
2016-03-28 19:31 ` Kei Yamashita
2016-03-29 9:52 ` Alex Kost
2016-03-30 2:24 ` Kei Yamashita
2016-03-30 2:36 ` Leo Famulari
2016-03-30 20:52 ` Alex Kost
2016-03-27 14:17 ` Nils Gillmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160328133931.4307044a@openmailbox.org \
--to=kei@openmailbox.org \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.