ffmpeg package update

ffmpeg package update

[rain1]

[-- Attachment #1: Type: text/plain, Size: 548 bytes --]

Hello,

Our ffmpeg package is old (version 2.8.6 but 3.0 is available now).

I noticed this because I found a segfault in a program that uses mpv: 
mkdir -p a ; mpv a. Updating ffmpeg fixes this.

Removed libquvi from it as that has been removed from mpv and is not 
being updated.

Changed a configure flag --disable-mipsdspr1 to --disable-mipsdsp - this 
is just a rename. You can read about this here 
<https://ffmpeg.org/pipermail/ffmpeg-devel/2015-November/183375.html> 
since it's just a rename I do not think this will break ffmpeg on MIPS.

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-packages-video.scm-Upgraded-version-supplied-new.patch --]
[-- Type: text/x-diff; name=0001-gnu-packages-video.scm-Upgraded-version-supplied-new.patch, Size: 2204 bytes --]

From d554b2aef830b6aaf53774f48b7fb7330ea03ee6 Mon Sep 17 00:00:00 2001
From: rain1 <rain1@openmailbox.org>
Date: Thu, 24 Mar 2016 16:24:03 +0000
Subject: [PATCH] * gnu/packages/video.scm: Upgraded version, supplied new hash
 and removed deprecated libquvi support. Renamed mipsdspr1 to mipsdsp.

---
 gnu/packages/video.scm | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm
index a870dd8..494889a 100644
--- a/gnu/packages/video.scm
+++ b/gnu/packages/video.scm
@@ -372,14 +372,14 @@ standards (MPEG-2, MPEG-4 ASP/H.263, MPEG-4 AVC/H.264, and VC-1/VMW3).")
 (define-public ffmpeg
   (package
     (name "ffmpeg")
-    (version "2.8.6")
+    (version "3.0")
     (source (origin
              (method url-fetch)
              (uri (string-append "https://ffmpeg.org/releases/ffmpeg-"
                                  version ".tar.xz"))
              (sha256
               (base32
-               "1yh7dvm7zwdlsspdaq524s5qaggma5md9h95qc4kvb5dmyyyvg15"))))
+               "0w74b165l4ry4y72f4xmgd357pvbc7yr61y313v3ai6787p2rwqj"))))
     (build-system gnu-build-system)
     (inputs
      `(("fontconfig" ,fontconfig)
@@ -392,7 +392,6 @@ standards (MPEG-2, MPEG-4 ASP/H.263, MPEG-4 AVC/H.264, and VC-1/VMW3).")
        ("libbluray" ,libbluray)
        ("libcaca" ,libcaca)
        ("libcdio-paranoia" ,libcdio-paranoia)
-       ("libquvi" ,libquvi)
        ("libtheora" ,libtheora)
        ("libvdpau" ,libvdpau)
        ("libvorbis" ,libvorbis)
@@ -480,7 +479,6 @@ standards (MPEG-2, MPEG-4 ASP/H.263, MPEG-4 AVC/H.264, and VC-1/VMW3).")
          "--enable-libmp3lame"
          "--enable-libopus"
          "--enable-libpulse"
-         "--enable-libquvi"
          "--enable-libsoxr"
          "--enable-libspeex"
          "--enable-libtheora"
@@ -498,7 +496,7 @@ standards (MPEG-2, MPEG-4 ASP/H.263, MPEG-4 AVC/H.264, and VC-1/VMW3).")
          ;; Runtime cpu detection is not implemented on
          ;; MIPS, so we disable some features.
          "--disable-mips32r2"
-         "--disable-mipsdspr1"
+         "--disable-mipsdsp"
          "--disable-mipsdspr2"
          "--disable-mipsfpu")
        #:phases
-- 
2.6.3

Re: ffmpeg package update

[Leo Famulari]

On Thu, Mar 24, 2016 at 04:58:43PM +0000, rain1@openmailbox.org wrote:
> Hello,
> 
> Our ffmpeg package is old (version 2.8.6 but 3.0 is available now).
> 
> I noticed this because I found a segfault in a program that uses mpv: mkdir
> -p a ; mpv a. Updating ffmpeg fixes this.

So, passing an empty directory to mpv causes a segmentation fault? Do
you know if it was fixed "deliberately" by ffmpeg (or mpv, not sure
which program is responsible here), or just as a side effect of some
other change? If the latter, they may be interested to know about the
bug.

> 
> Removed libquvi from it as that has been removed from mpv and is not being
> updated.

We like to commit unrelated changes separately. So, unless the removal
of libquvi is required to build version 3.0 of ffmpeg, I think it should
be done in a separate commit. Can you revise your patches?

Also, is libquvi causing some problem with our ffmpeg package? I don't
understand the reason for removing it; I'm not familiar with quvi at
all.

> 
> Changed a configure flag --disable-mipsdspr1 to --disable-mipsdsp - this is
> just a rename. You can read about this here
> <https://ffmpeg.org/pipermail/ffmpeg-devel/2015-November/183375.html> since
> it's just a rename I do not think this will break ffmpeg on MIPS.

Okay, thanks for the info.

Re: ffmpeg package update

[Leo Famulari]

On Thu, Mar 24, 2016 at 04:58:43PM +0000, rain1@openmailbox.org wrote:
> Hello,
> 
> Our ffmpeg package is old (version 2.8.6 but 3.0 is available now).
> 
> I noticed this because I found a segfault in a program that uses mpv: mkdir
> -p a ; mpv a. Updating ffmpeg fixes this.
> 
> Removed libquvi from it as that has been removed from mpv and is not being
> updated.

Upstream commit 2d40a09b6 removed support for libquvi:
https://github.com/FFmpeg/FFmpeg/commit/2d40a09b6e73230b160a505f01ed1acf169e1d9f

> 
> Changed a configure flag --disable-mipsdspr1 to --disable-mipsdsp - this is
> just a rename. You can read about this here
> <https://ffmpeg.org/pipermail/ffmpeg-devel/2015-November/183375.html> since
> it's just a rename I do not think this will break ffmpeg on MIPS.

$ guix refresh -l ffmpeg
Building the following 15 packages would ensure 20 dependent packages
are rebuilt: mplayer-1.2.1 emotion-generic-players-1.17.0 obs-0.13.2
mpv-0.16.0 cmus-2.7.1 pianobar-2015.11.22 mpd-0.19.12 kodi-16.0
gst-libav-1.6.3 blender-2.76b guile-gnunet-0.0.383eac2 gnunet-gtk-0.10.1
retroarch-1.3.1 audacity-2.1.0 synfigstudio-1.0.2

Does anyone want to check if some of those still work with this change,
or should we just apply the update?

Re: ffmpeg package update

[Efraim Flashner]

[-- Attachment #1: Type: text/plain, Size: 1163 bytes --]

On Sun, 27 Mar 2016 19:20:54 -0400
Leo Famulari <leo@famulari.name> wrote:

> On Thu, Mar 24, 2016 at 04:58:43PM +0000, rain1@openmailbox.org wrote:
>  [...]  
> 
> Upstream commit 2d40a09b6 removed support for libquvi:
> https://github.com/FFmpeg/FFmpeg/commit/2d40a09b6e73230b160a505f01ed1acf169e1d9f
> 
>  [...]  
> 
> $ guix refresh -l ffmpeg
> Building the following 15 packages would ensure 20 dependent packages
> are rebuilt: mplayer-1.2.1 emotion-generic-players-1.17.0 obs-0.13.2
> mpv-0.16.0 cmus-2.7.1 pianobar-2015.11.22 mpd-0.19.12 kodi-16.0
> gst-libav-1.6.3 blender-2.76b guile-gnunet-0.0.383eac2 gnunet-gtk-0.10.1
> retroarch-1.3.1 audacity-2.1.0 synfigstudio-1.0.2
> 
> Does anyone want to check if some of those still work with this change,
> or should we just apply the update?
> 

I can build out mpv to make sure it still works.

Rain1- looks like you forgot to add yourself to the copyright at the top

-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: ffmpeg package update

[Efraim Flashner]

[-- Attachment #1: Type: text/plain, Size: 1375 bytes --]

On Thu, 24 Mar 2016 16:58:43 +0000
rain1@openmailbox.org wrote:

> Hello,
> 
> Our ffmpeg package is old (version 2.8.6 but 3.0 is available now).
> 
> I noticed this because I found a segfault in a program that uses mpv: 
> mkdir -p a ; mpv a. Updating ffmpeg fixes this.
> 
> Removed libquvi from it as that has been removed from mpv and is not 
> being updated.
> 
> Changed a configure flag --disable-mipsdspr1 to --disable-mipsdsp - this 
> is just a rename. You can read about this here 
> <https://ffmpeg.org/pipermail/ffmpeg-devel/2015-November/183375.html> 
> since it's just a rename I do not think this will break ffmpeg on MIPS.

Like Leo said, patch looks good.

Don't forget to add yourself to the copyright line at the top :)

The commit message, it doesn't match up with the rest of the commit messages. There are many examples to copy from in the repo, and there's also the GNU manual here[0] which covers this also. Feel free to ask here or in irc if you need help with it, and can you send an updated patch?

Thanks!


[0] https://www.gnu.org/prep/standards/html_node/Style-of-Change-Logs.html#Style-of-Change-Logs

-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: ffmpeg package update

[Efraim Flashner]

[-- Attachment #1: Type: text/plain, Size: 3343 bytes --]

On Thu, Mar 24, 2016 at 04:58:43PM +0000, rain1@openmailbox.org wrote:
> Hello,
> 
> Our ffmpeg package is old (version 2.8.6 but 3.0 is available now).
> 
> I noticed this because I found a segfault in a program that uses mpv: mkdir
> -p a ; mpv a. Updating ffmpeg fixes this.
> 
> Removed libquvi from it as that has been removed from mpv and is not being
> updated.
> 
> Changed a configure flag --disable-mipsdspr1 to --disable-mipsdsp - this is
> just a rename. You can read about this here
> <https://ffmpeg.org/pipermail/ffmpeg-devel/2015-November/183375.html> since
> it's just a rename I do not think this will break ffmpeg on MIPS.

> From d554b2aef830b6aaf53774f48b7fb7330ea03ee6 Mon Sep 17 00:00:00 2001
> From: rain1 <rain1@openmailbox.org>
> Date: Thu, 24 Mar 2016 16:24:03 +0000
> Subject: [PATCH] * gnu/packages/video.scm: Upgraded version, supplied new hash
>  and removed deprecated libquvi support. Renamed mipsdspr1 to mipsdsp.
> 
> ---
>  gnu/packages/video.scm | 8 +++-----
>  1 file changed, 3 insertions(+), 5 deletions(-)
> 
> diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm
> index a870dd8..494889a 100644
> --- a/gnu/packages/video.scm
> +++ b/gnu/packages/video.scm
> @@ -372,14 +372,14 @@ standards (MPEG-2, MPEG-4 ASP/H.263, MPEG-4 AVC/H.264, and VC-1/VMW3).")
>  (define-public ffmpeg
>    (package
>      (name "ffmpeg")
> -    (version "2.8.6")
> +    (version "3.0")
>      (source (origin
>               (method url-fetch)
>               (uri (string-append "https://ffmpeg.org/releases/ffmpeg-"
>                                   version ".tar.xz"))
>               (sha256
>                (base32
> -               "1yh7dvm7zwdlsspdaq524s5qaggma5md9h95qc4kvb5dmyyyvg15"))))
> +               "0w74b165l4ry4y72f4xmgd357pvbc7yr61y313v3ai6787p2rwqj"))))
>      (build-system gnu-build-system)
>      (inputs
>       `(("fontconfig" ,fontconfig)
> @@ -392,7 +392,6 @@ standards (MPEG-2, MPEG-4 ASP/H.263, MPEG-4 AVC/H.264, and VC-1/VMW3).")
>         ("libbluray" ,libbluray)
>         ("libcaca" ,libcaca)
>         ("libcdio-paranoia" ,libcdio-paranoia)
> -       ("libquvi" ,libquvi)
>         ("libtheora" ,libtheora)
>         ("libvdpau" ,libvdpau)
>         ("libvorbis" ,libvorbis)
> @@ -480,7 +479,6 @@ standards (MPEG-2, MPEG-4 ASP/H.263, MPEG-4 AVC/H.264, and VC-1/VMW3).")
>           "--enable-libmp3lame"
>           "--enable-libopus"
>           "--enable-libpulse"
> -         "--enable-libquvi"
>           "--enable-libsoxr"
>           "--enable-libspeex"
>           "--enable-libtheora"
> @@ -498,7 +496,7 @@ standards (MPEG-2, MPEG-4 ASP/H.263, MPEG-4 AVC/H.264, and VC-1/VMW3).")
>           ;; Runtime cpu detection is not implemented on
>           ;; MIPS, so we disable some features.
>           "--disable-mips32r2"
> -         "--disable-mipsdspr1"
> +         "--disable-mipsdsp"
>           "--disable-mipsdspr2"
>           "--disable-mipsfpu")
>         #:phases
> -- 
> 2.6.3
> 

pushed in c5e1fcd0aea87e841a8484ce28679d11d602f137 with changes to the
commit message

-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]