From mboxrd@z Thu Jan  1 00:00:00 1970
From: Leo Famulari <leo@famulari.name>
Subject: Re: [PATCH] gnu: Add bash-tap.
Date: Fri, 18 Mar 2016 15:15:19 -0400
Message-ID: <20160318191519.GF9682@jasmine>
References: <8760wlrst0.fsf@gnu.org> <20160318184342.GB9682@jasmine>
	<20160318185339.GA20746@solar>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:57365)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1agzrn-0005pr-Pe
	for guix-devel@gnu.org; Fri, 18 Mar 2016 15:15:24 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1agzrk-00026r-Be
	for guix-devel@gnu.org; Fri, 18 Mar 2016 15:15:23 -0400
Received: from out2-smtp.messagingengine.com ([66.111.4.26]:58398)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1agzrk-00026e-2J
	for guix-devel@gnu.org; Fri, 18 Mar 2016 15:15:20 -0400
Content-Disposition: inline
In-Reply-To: <20160318185339.GA20746@solar>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Andreas Enge <andreas@enge.fr>
Cc: guix-devel@gnu.org

On Fri, Mar 18, 2016 at 07:53:39PM +0100, Andreas Enge wrote:
> On Fri, Mar 18, 2016 at 02:43:42PM -0400, Leo Famulari wrote:
> > Can someone with more experience take a look and apply the patch if it's
> > okay?
> 
> I had a look (without having much experience with the trivial build system),
> and it looks mostly clean. However, the package installs three bash scripts
> that start with "#!/bin/bash". This will not work on GuixSD, where only
> /bin/sh exists. It should be patched by adding bash as an input and
> substituting. Alternatively, you could use the gnu-build-system, delete most
> of the phases, set #:tests? to #f and add a custom install phase; then the
> patch-shebangs phase will do its magic.

Good catch!

I think using gnu-build-system is the way to go.

> 
> Andreas
>