From: Andreas Enge <andreas@enge.fr>
To: Leo Famulari <leo@famulari.name>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: Add bash-tap.
Date: Fri, 18 Mar 2016 19:53:39 +0100 [thread overview]
Message-ID: <20160318185339.GA20746@solar> (raw)
In-Reply-To: <20160318184342.GB9682@jasmine>
On Fri, Mar 18, 2016 at 02:43:42PM -0400, Leo Famulari wrote:
> Can someone with more experience take a look and apply the patch if it's
> okay?
I had a look (without having much experience with the trivial build system),
and it looks mostly clean. However, the package installs three bash scripts
that start with "#!/bin/bash". This will not work on GuixSD, where only
/bin/sh exists. It should be patched by adding bash as an input and
substituting. Alternatively, you could use the gnu-build-system, delete most
of the phases, set #:tests? to #f and add a custom install phase; then the
patch-shebangs phase will do its magic.
Andreas
next prev parent reply other threads:[~2016-03-18 18:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-17 16:08 [PATCH] gnu: Add bash-tap Roel Janssen
2016-03-18 18:43 ` Leo Famulari
2016-03-18 18:53 ` Andreas Enge [this message]
2016-03-18 19:15 ` Leo Famulari
2016-05-03 10:44 ` Roel Janssen
2016-05-06 18:07 ` Leo Famulari
2016-05-07 17:12 ` Roel Janssen
2016-03-18 20:49 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160318185339.GA20746@solar \
--to=andreas@enge.fr \
--cc=guix-devel@gnu.org \
--cc=leo@famulari.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.