From mboxrd@z Thu Jan  1 00:00:00 1970
From: Leo Famulari <leo@famulari.name>
Subject: Re: [PATCH] Add ustr.
Date: Fri, 18 Mar 2016 14:40:56 -0400
Message-ID: <20160318184056.GA9682@jasmine>
References: <idjshzpti8i.fsf@bimsb-sys02.mdc-berlin.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49146)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1agzKW-0000qh-AW
	for guix-devel@gnu.org; Fri, 18 Mar 2016 14:41:01 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1agzKT-0008WU-77
	for guix-devel@gnu.org; Fri, 18 Mar 2016 14:40:59 -0400
Received: from out2-smtp.messagingengine.com ([66.111.4.26]:48324)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1agzKT-0008WE-3R
	for guix-devel@gnu.org; Fri, 18 Mar 2016 14:40:57 -0400
Content-Disposition: inline
In-Reply-To: <idjshzpti8i.fsf@bimsb-sys02.mdc-berlin.net>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
Cc: guix-devel <guix-devel@gnu.org>

On Thu, Mar 17, 2016 at 01:13:33PM +0100, Ricardo Wurmus wrote:
> * gnu/packages/textutils.scm (ustr): New variable.

[...]

> +              (uri (string-append "http://www.and.org/ustr/" version
> +                                  "/ustr-" version ".tar.bz2"))


Wow, that is a nice domain name!

It looks like this directory only contains the current version of the
code, but I can't find an archive of old releases. How about mentioning
this in a comment, and (maybe) asking and.org to provide an archive?

> +              (sha256
> +               (base32
> +                "1i623ygdj7rkizj7985q9d6vj5amwg686aqb5j3ixpkqkyp6xbrx"))))
> +    (build-system gnu-build-system)
> +    (arguments
> +     `(#:make-flags
> +       (list "CC=gcc"
> +             "HIDE="

I read the Makefile's comment about this. ;)

> +             "LDCONFIG=echo"

Can you explain this one in a comment?

> +             (string-append "prefix=" (assoc-ref %outputs "out"))
> +             "all-shared")

[...]

> +    ;; Quoted from the home page: "The License for the code is MIT, new-BSD,
> +    ;; LGPL, etc. ... if you need another license to help compatibility, just
> +    ;; ask for it.  It's basically public domain, without all the legal
> +    ;; problems for everyone that trying to make something public domain
> +    ;; entails."
> +    (license license:public-domain)))

Sounds good to me. Hopefully there are no objections from the legal
experts!