From mboxrd@z Thu Jan 1 00:00:00 1970 From: Leo Famulari Subject: Re: [PATCH 5/6] gnu: Add borg. Date: Tue, 15 Mar 2016 05:18:45 -0400 Message-ID: <20160315091845.GA9602@jasmine> References: <14fe75ec9c8b651be6a5240dd5444e558615e1e1.1457998381.git.leo@famulari.name> <878u1k2jik.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:39456) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1afl7r-0004Cq-0P for guix-devel@gnu.org; Tue, 15 Mar 2016 05:18:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1afl7m-0003iU-LY for guix-devel@gnu.org; Tue, 15 Mar 2016 05:18:50 -0400 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:52346) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1afl7m-0003iO-DO for guix-devel@gnu.org; Tue, 15 Mar 2016 05:18:46 -0400 Content-Disposition: inline In-Reply-To: <878u1k2jik.fsf@gmail.com> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Alex Kost Cc: guix-devel@gnu.org On Tue, Mar 15, 2016 at 12:11:15PM +0300, Alex Kost wrote: > Leo Famulari (2016-03-15 02:34 +0300) wrote: > > > * gnu/packages/backup.scm (borg): New variable. > > --- > > gnu/packages/backup.scm | 53 ++++++++++++++++++++++++++++++++++++++++++++++++- > > 1 file changed, 52 insertions(+), 1 deletion(-) > [...] > > +(define-public borg > > + (package > > + (name "borg") > > + (version "1.0.0") > > + (source (origin > > + (method url-fetch) > > + (uri (pypi-uri "borgbackup" version)) > > + (sha256 > > + (base32 > > + "0wa6cvqs3rni5nwrgagigchcly8a53rxk56z0zn8iaii2cqrw2sh")))) > > + (build-system python-build-system) > > + (arguments > > + `(#:phases > > + (modify-phases %standard-phases > > + (add-before 'build 'set-openssl-prefix > > + (lambda* (#:key inputs #:allow-other-keys) > > + (setenv "BORG_OPENSSL_PREFIX" (assoc-ref inputs "openssl")) > > + #t)) > > + (add-before 'build 'set-lz4-prefix > > + (lambda* (#:key inputs #:allow-other-keys) > > + (setenv "BORG_LZ4_PREFIX" (assoc-ref inputs "lz4")) > > + #t)) > > Would it be better to make a single 'set-env' phase instead? Or better > yet, are these '..._PREFIX' variables used for make command? If so, > they should be specified in #:make-flags argument. Thank you, that makes the recipe shorter and clearer. > > > + (add-after 'install 'docs > > + (lambda* (#:key outputs #:allow-other-keys) > > + (let* ((out (assoc-ref outputs "out")) > > + (man (string-append out "/share/man/man1"))) > > + (and > > + (zero? (system* "make" "-C" "docs" "man")) > > + (install-file "docs/_build/man/borg.1" man))) > > Since 'install-file' does not specify a returned value, and we are not > really interested in the returned value, I think it is better to use > 'when' instead of 'and' here: > > (when (zero? (system* "make" "-C" "docs" "man")) > (install-file "docs/_build/man/borg.1" man)) Okay, that makes sense. > > > + #t))))) > > -- > Alex