From mboxrd@z Thu Jan  1 00:00:00 1970
From: Leo Famulari <leo@famulari.name>
Subject: Re: [PATCH 1/1] gnu: openexr: Disable broken test to fix build on
	i686.
Date: Fri, 11 Mar 2016 15:09:06 -0500
Message-ID: <20160311200906.GA2730@jasmine>
References: <cover.1457640278.git.leo@famulari.name>
	<cover.1457640278.git.leo@famulari.name>
	<8c8bd1a93437ee981f97979b7cd029800a746a03.1457640278.git.leo@famulari.name>
	<87mvq5yt3m.fsf@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47574)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1aeTN3-0007B4-4S
	for guix-devel@gnu.org; Fri, 11 Mar 2016 15:09:14 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1aeTN0-0008Qn-8A
	for guix-devel@gnu.org; Fri, 11 Mar 2016 15:09:13 -0500
Received: from out4-smtp.messagingengine.com ([66.111.4.28]:42271)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1aeTMy-0008QZ-To
	for guix-devel@gnu.org; Fri, 11 Mar 2016 15:09:10 -0500
Content-Disposition: inline
In-Reply-To: <87mvq5yt3m.fsf@gnu.org>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Ludovic =?iso-8859-1?Q?Court=E8s?= <ludo@gnu.org>
Cc: guix-devel@gnu.org

On Fri, Mar 11, 2016 at 03:41:49PM +0100, Ludovic Courtès wrote:
> Leo Famulari <leo@famulari.name> skribis:
> 
> > * gnu/packages/graphics.scm (openexr)[arguments]: New field.
> > ---
> >  gnu/packages/graphics.scm | 14 ++++++++++++++
> >  1 file changed, 14 insertions(+)
> >
> > diff --git a/gnu/packages/graphics.scm b/gnu/packages/graphics.scm
> > index c022d74..3c5ad72 100644
> > --- a/gnu/packages/graphics.scm
> > +++ b/gnu/packages/graphics.scm
> > @@ -206,6 +206,20 @@ exception-handling library.")
> >                     "\"/tmp/\"")))
> >                (patches (list (search-patch "openexr-missing-samples.patch")))))
> >      (build-system gnu-build-system)
> > +    (arguments
> > +     '(#:phases
> > +       (modify-phases %standard-phases
> > +         (add-after 'unpack 'disable-broken-test
> > +         ;; This test fails on i686. Upstream developers suggest that
> > +         ;; this test is broken on i686 and can be safely disabled:
> > +         ;; https://github.com/openexr/openexr/issues/67#issuecomment-21169748
> > +           (lambda _
> 
> Better to indent the comment with “(lambda” below.

Okay, pushed with that change!

> 
> Otherwise LGTM, thanks for fixing this!
> 
> Ludo’.