From: Leo Famulari <leo@famulari.name>
To: Rob Syme <rob.syme@gmail.com>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: Include CodingQuarry gene predictor
Date: Tue, 8 Mar 2016 18:39:37 -0500 [thread overview]
Message-ID: <20160308233937.GB24107@jasmine> (raw)
In-Reply-To: <CAEf4xgeu18CvOoO0cC3rm3q3TxtROEtt56iTr7gDDoG7sKuW9w@mail.gmail.com>
On Tue, Mar 08, 2016 at 05:13:34PM +0800, Rob Syme wrote:
Thank you for the patch!
> * gnu/packages/bioinformatics.scm: Add codingquarry package description
When adding packages, we have a preferred format for the commit message.
It's either the GNU changelog format or a slightly modified version (I'm
not sure). You can see a good example in commit 0e2f2aebed.
[...]
> + (delete 'check) ;; Don't run the 'make check' step of the
> gnu-build-system
When skippping the tests, we prefer to say why in the comment. It can be
as simple as "no test suite" if that is the case.
[...]
> + (native-inputs `(("python", python-2)))
If the software only works with Python 2, I prefer to say so in a
comment such as "Only Python 2 is supported." I don't think is official
policy but I find it a useful piece of information to leave for other
readers.
Can you submit a revised patch that addresses these issues?
next prev parent reply other threads:[~2016-03-08 23:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-08 9:13 [PATCH] gnu: Include CodingQuarry gene predictor Rob Syme
2016-03-08 23:39 ` Leo Famulari [this message]
2016-03-08 23:41 ` Rob Syme
2016-03-09 17:59 ` Andreas Enge
2016-03-11 3:55 ` Rob Syme
2016-03-16 8:50 ` Leo Famulari
2016-03-16 8:51 ` Rob Syme
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160308233937.GB24107@jasmine \
--to=leo@famulari.name \
--cc=guix-devel@gnu.org \
--cc=rob.syme@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.