From mboxrd@z Thu Jan 1 00:00:00 1970 From: Leo Famulari Subject: Re: [PATCH] gnu: simple-scan: Update to 3.19.91. Date: Tue, 8 Mar 2016 18:02:32 -0500 Message-ID: <20160308230232.GA24107@jasmine> References: <1457474675-21775-1-git-send-email-tobias.geerinckx.rice@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:56976) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1adQeG-0007Uh-Qu for guix-devel@gnu.org; Tue, 08 Mar 2016 18:02:41 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1adQeB-0006sJ-Qh for guix-devel@gnu.org; Tue, 08 Mar 2016 18:02:40 -0500 Received: from out5-smtp.messagingengine.com ([66.111.4.29]:56597) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1adQeB-0006rZ-KL for guix-devel@gnu.org; Tue, 08 Mar 2016 18:02:35 -0500 Content-Disposition: inline In-Reply-To: <1457474675-21775-1-git-send-email-tobias.geerinckx.rice@gmail.com> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Tobias Geerinckx-Rice Cc: guix-devel@gnu.org On Tue, Mar 08, 2016 at 11:04:35PM +0100, Tobias Geerinckx-Rice wrote: > * gnu/packages/gnome.scm (simple-scan): Update to 3.19.91. Thanks for your attention to this package! Except where necessary for the new version to work, it's best to do updates in a separate commit from other changes. I can apply the update myself if you say it's okay to do on its own, or feel free to submit a revised patch set. > [arguments]: Disable PackageKit support irrelevant for Guix. [...] > + (arguments > + '(#:configure-flags '("--disable-packagekit") > + #:phases > + (modify-phases %standard-phases > + (add-after 'unpack 'clean > + (lambda _ > + ;; Remove a left-over reference to PackageKit. > + (delete-file "src/ui.c")))))) Does 'src/ui.c' cause problems for us? I'd rather not make changes to upstream code except when necesssary [0], at least not without discussing it with upstream first. [0] For example, when fixing portability issues or deleting non-free and non-essential bundled components. The impact of the change should be well-understood by reviewers, at the very least ;)