From mboxrd@z Thu Jan 1 00:00:00 1970 From: Leo Famulari Subject: Re: [PATCH]: xfce4-power-manager: new variable Date: Mon, 7 Mar 2016 23:38:15 -0500 Message-ID: <20160308043815.GB11420@jasmine> References: <56604C07.2040900@gmx.net> <20151203190120.GA18176@jasmine> <87si02s91g.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="fUYQa+Pmc3FrFX/N" Content-Transfer-Encoding: 8bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:58158) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ad9PX-0006Le-6j for guix-devel@gnu.org; Mon, 07 Mar 2016 23:38:20 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ad9PS-0001dr-IP for guix-devel@gnu.org; Mon, 07 Mar 2016 23:38:19 -0500 Received: from out5-smtp.messagingengine.com ([66.111.4.29]:33041) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ad9PS-0001dk-DO for guix-devel@gnu.org; Mon, 07 Mar 2016 23:38:14 -0500 Content-Disposition: inline In-Reply-To: <87si02s91g.fsf@gnu.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Ludovic =?iso-8859-1?Q?Court=E8s?= Cc: guix-devel@gnu.org --fUYQa+Pmc3FrFX/N Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit On Mon, Mar 07, 2016 at 02:38:03PM +0100, Ludovic Courtès wrote: > Leo Famulari skribis: > > > On Thu, Dec 03, 2015 at 03:04:55PM +0100, Florian Paul Schmidt wrote: > >> Hi, > >> > >> attached is a patch for a first stab at packaging xfce4-power-manager. Since > >> I used a different package as a base for this one there might be some > >> unneeded inputs. I wonder if you guys have a tip for creating a little > >> scheme snippet that would try all combinations of inputs to determine the > >> minimal set for which ones the package build still succeeds? ;) [lazy flo] > > > > The potential issue with this approach is that a lot of software will > > build successfully even if some dependencies are missing. And then it > > will fail at runtime, sometimes only in certain scenarios. Not that I > > haven't thought about doing the same thing... :) > > > > Ideally each program would have a test suite that exercised every code > > path. Maybe AFL would be useful there? That sounds expensive but for > > very complex systems, it would be worth it, because in my limited > > experience packaging software, I have found that many upstream > > developers are not aware of the dependency graph of their software. It's > > fun to send them the output of "guix graph". > > Looks like the xfce4-power-manager patch fell through the cracks. Leo, > could you maybe do a final polishing pass and commit it? And here are the patches... --fUYQa+Pmc3FrFX/N Content-Type: text/x-diff; charset=iso-8859-1 Content-Disposition: attachment; filename="0001-gnu-Add-xfce4-power-manager.patch" Content-Transfer-Encoding: 8bit >From 2ef9d0fae7dd04cfb25691411b5afec76cb3eb5b Mon Sep 17 00:00:00 2001 From: Florian Paul Schmidt Date: Thu, 3 Dec 2015 14:57:10 +0100 Subject: [PATCH 1/2] gnu: Add xfce4-power-manager. * gnu/packages/xfce.scm (xfce4-power-manager): New variable. Signed-off-by: Leo Famulari --- gnu/packages/xfce.scm | 35 +++++++++++++++++++++++++++++++++++ 1 file changed, 35 insertions(+) diff --git a/gnu/packages/xfce.scm b/gnu/packages/xfce.scm index b627396..c1a4328 100644 --- a/gnu/packages/xfce.scm +++ b/gnu/packages/xfce.scm @@ -2,6 +2,7 @@ ;;; Copyright © 2014, 2015 Sou Bunnbu ;;; Copyright © 2014, 2015 Mark H Weaver ;;; Copyright © 2016 Andreas Enge +;;; Copyright © 2016 Florian Paul Schmidt ;;; ;;; This file is part of GNU Guix. ;;; @@ -721,3 +722,37 @@ on your desktop.") "Xfce is a lightweight desktop environment. It aims to be fast and low on system resources, while still being visually appealing and user friendly.") (license gpl2+))) + +(define-public xfce4-power-manager + (package + (name "xfce4-power-manager") + (version "1.4.3") + (source (origin + (method url-fetch) + (uri (string-append "http://archive.xfce.org/xfce/4.12" + "/src/" name "-" version ".tar.bz2")) + (sha256 + (base32 + "04909sfc2nrj2wg9cw6y9y2r9yrp3l3vc201sy1gaiap67fi33h1")))) + (build-system gnu-build-system) + (arguments + '(#:configure-flags '("--enable-gtk3"))) + (native-inputs + `(("pkg-config" ,pkg-config) + ("intltool" ,intltool))) + (inputs + `(("lbxrandr" ,libxrandr) + ("upower" ,upower) + ("libnotify" ,libnotify) + ("libxfce4ui" ,libxfce4ui))) + (home-page "http://www.xfce.org/") + (synopsis "Xfce Power Manager") + (description + "This is a power manager for the Xfce desktop. It manages the power +sources on the computer and the devices that can be controlled to reduce their +power consumption (such as LCD brightness level, monitor sleep, CPU frequency +scaling, etc). In addition, xfce4-power-manager provides a set of +freedesktop-compliant DBus interfaces to inform other applications about current +power level so that they can adjust their power consumption, and it provides the +inhibit interface which allows applications to prevent automatic sleep.") + (license gpl2+))) -- 2.6.3 --fUYQa+Pmc3FrFX/N Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="0002-gnu-xfce-Add-xfce4-power-manager.patch" >From 24d1a433fb793433fcea78cc115cb3d89bdd0ebe Mon Sep 17 00:00:00 2001 From: Leo Famulari Date: Mon, 7 Mar 2016 23:00:35 -0500 Subject: [PATCH 2/2] gnu: xfce: Add xfce4-power-manager. * gnu/packages/xfce.scm (xfce)[propagated-inputs]: Add xfce4-power-manager. --- gnu/packages/xfce.scm | 1 + 1 file changed, 1 insertion(+) diff --git a/gnu/packages/xfce.scm b/gnu/packages/xfce.scm index c1a4328..03b49a8 100644 --- a/gnu/packages/xfce.scm +++ b/gnu/packages/xfce.scm @@ -705,6 +705,7 @@ on your desktop.") ("tumlber" ,tumbler) ("xfce4-appfinder" ,xfce4-appfinder) ("xfce4-panel" ,xfce4-panel) + ("xfce4-power-manager" ,xfce4-power-manager) ("xfce4-session" ,xfce4-session) ("xfce4-settings" ,xfce4-settings) ("xfce4-terminal" ,xfce4-terminal) -- 2.6.3 --fUYQa+Pmc3FrFX/N--