Re: [PATCH]: xfce4-power-manager: new variable

[Leo Famulari <leo@famulari.name>]

[-- Attachment #1: Type: text/plain, Size: 1452 bytes --]

On Mon, Mar 07, 2016 at 02:38:03PM +0100, Ludovic Courtès wrote:
> Leo Famulari <leo@famulari.name> skribis:
> 
> > On Thu, Dec 03, 2015 at 03:04:55PM +0100, Florian Paul Schmidt wrote:
> >> Hi,
> >> 
> >> attached is a patch for a first stab at packaging xfce4-power-manager. Since
> >> I used a different package as a base for this one there might be some
> >> unneeded inputs. I wonder if you guys have a tip for creating a little
> >> scheme snippet that would try all combinations of inputs to determine the
> >> minimal set for which ones the package build still succeeds? ;) [lazy flo]
> >
> > The potential issue with this approach is that a lot of software will
> > build successfully even if some dependencies are missing. And then it
> > will fail at runtime, sometimes only in certain scenarios. Not that I
> > haven't thought about doing the same thing... :)
> >
> > Ideally each program would have a test suite that exercised every code
> > path. Maybe AFL would be useful there? That sounds expensive but for
> > very complex systems, it would be worth it, because in my limited
> > experience packaging software, I have found that many upstream
> > developers are not aware of the dependency graph of their software. It's
> > fun to send them the output of "guix graph".
> 
> Looks like the xfce4-power-manager patch fell through the cracks.  Leo,
> could you maybe do a final polishing pass and commit it?

And here are the patches...

[-- Attachment #2: 0001-gnu-Add-xfce4-power-manager.patch --]
[-- Type: text/x-diff, Size: 2515 bytes --]

From 2ef9d0fae7dd04cfb25691411b5afec76cb3eb5b Mon Sep 17 00:00:00 2001
From: Florian Paul Schmidt <mista.tapas@gmx.net>
Date: Thu, 3 Dec 2015 14:57:10 +0100
Subject: [PATCH 1/2] gnu: Add xfce4-power-manager.

* gnu/packages/xfce.scm (xfce4-power-manager): New variable.

Signed-off-by: Leo Famulari <leo@famulari.name>
---
 gnu/packages/xfce.scm | 35 +++++++++++++++++++++++++++++++++++
 1 file changed, 35 insertions(+)

diff --git a/gnu/packages/xfce.scm b/gnu/packages/xfce.scm
index b627396..c1a4328 100644
--- a/gnu/packages/xfce.scm
+++ b/gnu/packages/xfce.scm
@@ -2,6 +2,7 @@
 ;;; Copyright © 2014, 2015 Sou Bunnbu <iyzsong@gmail.com>
 ;;; Copyright © 2014, 2015 Mark H Weaver <mhw@netris.org>
 ;;; Copyright © 2016 Andreas Enge <andreas@enge.fr>
+;;; Copyright © 2016 Florian Paul Schmidt <mista.tapas@gmx.net>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -721,3 +722,37 @@ on your desktop.")
      "Xfce is a lightweight desktop environment.  It aims to be fast and low on
 system resources, while still being visually appealing and user friendly.")
     (license gpl2+)))
+
+(define-public xfce4-power-manager
+  (package
+    (name "xfce4-power-manager")
+    (version "1.4.3")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append "http://archive.xfce.org/xfce/4.12"
+                                  "/src/" name "-" version ".tar.bz2"))
+              (sha256
+               (base32
+                "04909sfc2nrj2wg9cw6y9y2r9yrp3l3vc201sy1gaiap67fi33h1"))))
+    (build-system gnu-build-system)
+    (arguments
+     '(#:configure-flags '("--enable-gtk3")))
+    (native-inputs
+     `(("pkg-config" ,pkg-config)
+       ("intltool" ,intltool)))
+    (inputs
+     `(("lbxrandr" ,libxrandr)
+       ("upower" ,upower)
+       ("libnotify" ,libnotify)
+       ("libxfce4ui" ,libxfce4ui)))
+    (home-page "http://www.xfce.org/")
+    (synopsis "Xfce Power Manager")
+    (description
+     "This is a power manager for the Xfce desktop.  It manages the power
+sources on the computer and the devices that can be controlled to reduce their
+power consumption (such as LCD brightness level, monitor sleep, CPU frequency
+scaling, etc).  In addition, xfce4-power-manager provides a set of
+freedesktop-compliant DBus interfaces to inform other applications about current
+power level so that they can adjust their power consumption, and it provides the
+inhibit interface which allows applications to prevent automatic sleep.")
+    (license gpl2+)))
-- 
2.6.3


[-- Attachment #3: 0002-gnu-xfce-Add-xfce4-power-manager.patch --]
[-- Type: text/x-diff, Size: 880 bytes --]

From 24d1a433fb793433fcea78cc115cb3d89bdd0ebe Mon Sep 17 00:00:00 2001
From: Leo Famulari <leo@famulari.name>
Date: Mon, 7 Mar 2016 23:00:35 -0500
Subject: [PATCH 2/2] gnu: xfce: Add xfce4-power-manager.

* gnu/packages/xfce.scm (xfce)[propagated-inputs]: Add xfce4-power-manager.
---
 gnu/packages/xfce.scm | 1 +
 1 file changed, 1 insertion(+)

diff --git a/gnu/packages/xfce.scm b/gnu/packages/xfce.scm
index c1a4328..03b49a8 100644
--- a/gnu/packages/xfce.scm
+++ b/gnu/packages/xfce.scm
@@ -705,6 +705,7 @@ on your desktop.")
        ("tumlber"              ,tumbler)
        ("xfce4-appfinder"      ,xfce4-appfinder)
        ("xfce4-panel"          ,xfce4-panel)
+       ("xfce4-power-manager"  ,xfce4-power-manager)
        ("xfce4-session"        ,xfce4-session)
        ("xfce4-settings"       ,xfce4-settings)
        ("xfce4-terminal"       ,xfce4-terminal)
-- 
2.6.3