From mboxrd@z Thu Jan 1 00:00:00 1970 From: Leo Famulari Subject: Re: [PATCH]: xfce4-power-manager: new variable Date: Mon, 7 Mar 2016 23:37:38 -0500 Message-ID: <20160308043738.GA11420@jasmine> References: <56604C07.2040900@gmx.net> <20151203190120.GA18176@jasmine> <87si02s91g.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:58022) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ad9Ox-0006C2-UY for guix-devel@gnu.org; Mon, 07 Mar 2016 23:37:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ad9Ot-0001JU-KQ for guix-devel@gnu.org; Mon, 07 Mar 2016 23:37:43 -0500 Received: from out5-smtp.messagingengine.com ([66.111.4.29]:53248) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ad9Ot-0001JG-HJ for guix-devel@gnu.org; Mon, 07 Mar 2016 23:37:39 -0500 Content-Disposition: inline In-Reply-To: <87si02s91g.fsf@gnu.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Ludovic =?iso-8859-1?Q?Court=E8s?= Cc: guix-devel@gnu.org On Mon, Mar 07, 2016 at 02:38:03PM +0100, Ludovic Courtès wrote: > Leo Famulari skribis: > > > On Thu, Dec 03, 2015 at 03:04:55PM +0100, Florian Paul Schmidt wrote: > >> Hi, > >> > >> attached is a patch for a first stab at packaging xfce4-power-manager. Since > >> I used a different package as a base for this one there might be some > >> unneeded inputs. I wonder if you guys have a tip for creating a little > >> scheme snippet that would try all combinations of inputs to determine the > >> minimal set for which ones the package build still succeeds? ;) [lazy flo] > > > > The potential issue with this approach is that a lot of software will > > build successfully even if some dependencies are missing. And then it > > will fail at runtime, sometimes only in certain scenarios. Not that I > > haven't thought about doing the same thing... :) > > > > Ideally each program would have a test suite that exercised every code > > path. Maybe AFL would be useful there? That sounds expensive but for > > very complex systems, it would be worth it, because in my limited > > experience packaging software, I have found that many upstream > > developers are not aware of the dependency graph of their software. It's > > fun to send them the output of "guix graph". > > Looks like the xfce4-power-manager patch fell through the cracks. Leo, > could you maybe do a final polishing pass and commit it? Sure. I separated the addition of the package and its use in the xfce meta-packaged into two patches. I know you asked me to commit, but since I don't have a system where I can test Xfce with power, I'm submitting the patches. Does anyone want to test? It does pass its test suite. I will go ahead and commit the patches if you confirm it's okay without having tested them.