[PATCH]: xfce4-power-manager: new variable

[PATCH]: xfce4-power-manager: new variable

[Florian Paul Schmidt]

[-- Attachment #1: Type: text/plain, Size: 2708 bytes --]

Hi,

attached is a patch for a first stab at packaging xfce4-power-manager. 
Since I used a different package as a base for this one there might be 
some unneeded inputs. I wonder if you guys have a tip for creating a 
little scheme snippet that would try all combinations of inputs to 
determine the minimal set for which ones the package build still 
succeeds? ;) [lazy flo]

 From 5ca12ed7fd62792b856aa686e66dfc224e16bf35 Mon Sep 17 00:00:00 2001
From: Florian Paul Schmidt <mista.tapas@gmx.net>
Date: Thu, 3 Dec 2015 14:57:10 +0100
Subject: [PATCH] xfce4-power-manager: new variable

---
  gnu/packages/xfce.scm | 38 ++++++++++++++++++++++++++++++++++++++
  1 file changed, 38 insertions(+)

diff --git a/gnu/packages/xfce.scm b/gnu/packages/xfce.scm
index e213fb6..41e193a 100644
--- a/gnu/packages/xfce.scm
+++ b/gnu/packages/xfce.scm
@@ -646,6 +646,43 @@ menubar and the window decorations are hidden) that 
helps you to save space
  on your desktop.")
      (license gpl2+)))

+(define-public xfce4-power-manager
+  (package
+    (name "xfce4-power-manager")
+    (version "1.4.3")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append "http://archive.xfce.org/xfce/4.12"
+                                  "/src/" name "-" version ".tar.bz2"))
+              (sha256
+               (base32
+ "04909sfc2nrj2wg9cw6y9y2r9yrp3l3vc201sy1gaiap67fi33h1"))))
+    (build-system gnu-build-system)
+    (arguments
+     '(#:configure-flags '("--enable-gtk3")))
+    (native-inputs
+     `(("pkg-config" ,pkg-config)
+       ("intltool" ,intltool)))
+    (inputs
+     `(("exo" ,exo)
+       ("garcon", garcon)
+       ("lbxrandr" ,libxrandr)
+       ("libwnck" ,libwnck-1)
+       ("upower" ,upower)
+       ("libnotify" ,libnotify)
+       ("libxfce4ui" ,libxfce4ui)))
+    (native-search-paths
+     (list (search-path-specification
+            (variable "X_XFCE4_LIB_DIRS")
+            (files '("lib/xfce4")))))
+    (home-page "http://www.xfce.org/")
+    (synopsis "Xfce Power Manager")
+    (description
+     "Power manager daemon for Xfce and associated settings page.
+Controls backlight, power saving, etc.")
+    ;; Libraries are under LGPLv2.1+, and programs under GPLv2+.
+    (license (list gpl2+ lgpl2.1+))))
+
  (define-public xfce
    (package
      (name "xfce")
@@ -689,6 +726,7 @@ on your desktop.")
         ("xfce4-session"        ,xfce4-session)
         ("xfce4-settings"       ,xfce4-settings)
         ("xfce4-terminal"       ,xfce4-terminal)
+       ("xfce4-power-manager"  ,xfce4-power-manager)
         ("xfconf"               ,xfconf)
         ("xfdesktop"            ,xfdesktop)
         ("xfwm4"                ,xfwm4)
-- 
2.5.0


Flo




[-- Attachment #2: 0001-xfce4-power-manager-new-variable.patch --]
[-- Type: text/plain, Size: 2324 bytes --]

From 5ca12ed7fd62792b856aa686e66dfc224e16bf35 Mon Sep 17 00:00:00 2001
From: Florian Paul Schmidt <mista.tapas@gmx.net>
Date: Thu, 3 Dec 2015 14:57:10 +0100
Subject: [PATCH] xfce4-power-manager: new variable

---
 gnu/packages/xfce.scm | 38 ++++++++++++++++++++++++++++++++++++++
 1 file changed, 38 insertions(+)

diff --git a/gnu/packages/xfce.scm b/gnu/packages/xfce.scm
index e213fb6..41e193a 100644
--- a/gnu/packages/xfce.scm
+++ b/gnu/packages/xfce.scm
@@ -646,6 +646,43 @@ menubar and the window decorations are hidden) that helps you to save space
 on your desktop.")
     (license gpl2+)))
 
+(define-public xfce4-power-manager
+  (package
+    (name "xfce4-power-manager")
+    (version "1.4.3")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append "http://archive.xfce.org/xfce/4.12"
+                                  "/src/" name "-" version ".tar.bz2"))
+              (sha256
+               (base32
+                "04909sfc2nrj2wg9cw6y9y2r9yrp3l3vc201sy1gaiap67fi33h1"))))
+    (build-system gnu-build-system)
+    (arguments
+     '(#:configure-flags '("--enable-gtk3")))
+    (native-inputs
+     `(("pkg-config" ,pkg-config)
+       ("intltool" ,intltool)))
+    (inputs
+     `(("exo" ,exo)
+       ("garcon", garcon)
+       ("lbxrandr" ,libxrandr)
+       ("libwnck" ,libwnck-1)
+       ("upower" ,upower)
+       ("libnotify" ,libnotify)
+       ("libxfce4ui" ,libxfce4ui)))
+    (native-search-paths
+     (list (search-path-specification
+            (variable "X_XFCE4_LIB_DIRS")
+            (files '("lib/xfce4")))))
+    (home-page "http://www.xfce.org/")
+    (synopsis "Xfce Power Manager")
+    (description
+     "Power manager daemon for Xfce and associated settings page. 
+Controls backlight, power saving, etc.")
+    ;; Libraries are under LGPLv2.1+, and programs under GPLv2+.
+    (license (list gpl2+ lgpl2.1+))))
+
 (define-public xfce
   (package
     (name "xfce")
@@ -689,6 +726,7 @@ on your desktop.")
        ("xfce4-session"        ,xfce4-session)
        ("xfce4-settings"       ,xfce4-settings)
        ("xfce4-terminal"       ,xfce4-terminal)
+       ("xfce4-power-manager"  ,xfce4-power-manager)
        ("xfconf"               ,xfconf)
        ("xfdesktop"            ,xfdesktop)
        ("xfwm4"                ,xfwm4)
-- 
2.5.0

Re: [PATCH]: xfce4-power-manager: new variable

[Leo Famulari]

On Thu, Dec 03, 2015 at 03:04:55PM +0100, Florian Paul Schmidt wrote:
> Hi,
> 
> attached is a patch for a first stab at packaging xfce4-power-manager. Since
> I used a different package as a base for this one there might be some
> unneeded inputs. I wonder if you guys have a tip for creating a little
> scheme snippet that would try all combinations of inputs to determine the
> minimal set for which ones the package build still succeeds? ;) [lazy flo]

The potential issue with this approach is that a lot of software will
build successfully even if some dependencies are missing. And then it
will fail at runtime, sometimes only in certain scenarios. Not that I
haven't thought about doing the same thing... :)

Ideally each program would have a test suite that exercised every code
path. Maybe AFL would be useful there? That sounds expensive but for
very complex systems, it would be worth it, because in my limited
experience packaging software, I have found that many upstream
developers are not aware of the dependency graph of their software. It's
fun to send them the output of "guix graph".

> 
> From 5ca12ed7fd62792b856aa686e66dfc224e16bf35 Mon Sep 17 00:00:00 2001
> From: Florian Paul Schmidt <mista.tapas@gmx.net>
> Date: Thu, 3 Dec 2015 14:57:10 +0100
> Subject: [PATCH] xfce4-power-manager: new variable
> 
> ---
>  gnu/packages/xfce.scm | 38 ++++++++++++++++++++++++++++++++++++++
>  1 file changed, 38 insertions(+)
> 
> diff --git a/gnu/packages/xfce.scm b/gnu/packages/xfce.scm
> index e213fb6..41e193a 100644
> --- a/gnu/packages/xfce.scm
> +++ b/gnu/packages/xfce.scm
> @@ -646,6 +646,43 @@ menubar and the window decorations are hidden) that
> helps you to save space
>  on your desktop.")
>      (license gpl2+)))
> 
> +(define-public xfce4-power-manager
> +  (package
> +    (name "xfce4-power-manager")
> +    (version "1.4.3")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append "http://archive.xfce.org/xfce/4.12"
> +                                  "/src/" name "-" version ".tar.bz2"))
> +              (sha256
> +               (base32
> + "04909sfc2nrj2wg9cw6y9y2r9yrp3l3vc201sy1gaiap67fi33h1"))))
> +    (build-system gnu-build-system)
> +    (arguments
> +     '(#:configure-flags '("--enable-gtk3")))
> +    (native-inputs
> +     `(("pkg-config" ,pkg-config)
> +       ("intltool" ,intltool)))
> +    (inputs
> +     `(("exo" ,exo)
> +       ("garcon", garcon)
> +       ("lbxrandr" ,libxrandr)
> +       ("libwnck" ,libwnck-1)
> +       ("upower" ,upower)
> +       ("libnotify" ,libnotify)
> +       ("libxfce4ui" ,libxfce4ui)))
> +    (native-search-paths
> +     (list (search-path-specification
> +            (variable "X_XFCE4_LIB_DIRS")
> +            (files '("lib/xfce4")))))
> +    (home-page "http://www.xfce.org/")
> +    (synopsis "Xfce Power Manager")
> +    (description
> +     "Power manager daemon for Xfce and associated settings page.
> +Controls backlight, power saving, etc.")
> +    ;; Libraries are under LGPLv2.1+, and programs under GPLv2+.
> +    (license (list gpl2+ lgpl2.1+))))
> +
>  (define-public xfce
>    (package
>      (name "xfce")
> @@ -689,6 +726,7 @@ on your desktop.")
>         ("xfce4-session"        ,xfce4-session)
>         ("xfce4-settings"       ,xfce4-settings)
>         ("xfce4-terminal"       ,xfce4-terminal)
> +       ("xfce4-power-manager"  ,xfce4-power-manager)
>         ("xfconf"               ,xfconf)
>         ("xfdesktop"            ,xfdesktop)
>         ("xfwm4"                ,xfwm4)
> -- 
> 2.5.0
> 
> 
> Flo
> 
> 
> 

> From 5ca12ed7fd62792b856aa686e66dfc224e16bf35 Mon Sep 17 00:00:00 2001
> From: Florian Paul Schmidt <mista.tapas@gmx.net>
> Date: Thu, 3 Dec 2015 14:57:10 +0100
> Subject: [PATCH] xfce4-power-manager: new variable
> 
> ---
>  gnu/packages/xfce.scm | 38 ++++++++++++++++++++++++++++++++++++++
>  1 file changed, 38 insertions(+)
> 
> diff --git a/gnu/packages/xfce.scm b/gnu/packages/xfce.scm
> index e213fb6..41e193a 100644
> --- a/gnu/packages/xfce.scm
> +++ b/gnu/packages/xfce.scm
> @@ -646,6 +646,43 @@ menubar and the window decorations are hidden) that helps you to save space
>  on your desktop.")
>      (license gpl2+)))
>  
> +(define-public xfce4-power-manager
> +  (package
> +    (name "xfce4-power-manager")
> +    (version "1.4.3")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append "http://archive.xfce.org/xfce/4.12"
> +                                  "/src/" name "-" version ".tar.bz2"))
> +              (sha256
> +               (base32
> +                "04909sfc2nrj2wg9cw6y9y2r9yrp3l3vc201sy1gaiap67fi33h1"))))
> +    (build-system gnu-build-system)
> +    (arguments
> +     '(#:configure-flags '("--enable-gtk3")))
> +    (native-inputs
> +     `(("pkg-config" ,pkg-config)
> +       ("intltool" ,intltool)))
> +    (inputs
> +     `(("exo" ,exo)
> +       ("garcon", garcon)
> +       ("lbxrandr" ,libxrandr)
> +       ("libwnck" ,libwnck-1)
> +       ("upower" ,upower)
> +       ("libnotify" ,libnotify)
> +       ("libxfce4ui" ,libxfce4ui)))
> +    (native-search-paths
> +     (list (search-path-specification
> +            (variable "X_XFCE4_LIB_DIRS")
> +            (files '("lib/xfce4")))))
> +    (home-page "http://www.xfce.org/")
> +    (synopsis "Xfce Power Manager")
> +    (description
> +     "Power manager daemon for Xfce and associated settings page. 
> +Controls backlight, power saving, etc.")
> +    ;; Libraries are under LGPLv2.1+, and programs under GPLv2+.
> +    (license (list gpl2+ lgpl2.1+))))
> +
>  (define-public xfce
>    (package
>      (name "xfce")
> @@ -689,6 +726,7 @@ on your desktop.")
>         ("xfce4-session"        ,xfce4-session)
>         ("xfce4-settings"       ,xfce4-settings)
>         ("xfce4-terminal"       ,xfce4-terminal)
> +       ("xfce4-power-manager"  ,xfce4-power-manager)
>         ("xfconf"               ,xfconf)
>         ("xfdesktop"            ,xfdesktop)
>         ("xfwm4"                ,xfwm4)
> -- 
> 2.5.0
> 

Re: [PATCH]: xfce4-power-manager: new variable

[Florian Paul Schmidt]

[-- Attachment #1: Type: text/plain, Size: 2952 bytes --]

Removed some inputs (see attached patch). Seems to still build and run..

Flo

On 12/03/2015 03:04 PM, Florian Paul Schmidt wrote:
> Hi,
>
> attached is a patch for a first stab at packaging xfce4-power-manager. 
> Since I used a different package as a base for this one there might be 
> some unneeded inputs. I wonder if you guys have a tip for creating a 
> little scheme snippet that would try all combinations of inputs to 
> determine the minimal set for which ones the package build still 
> succeeds? ;) [lazy flo]
>
> From 5ca12ed7fd62792b856aa686e66dfc224e16bf35 Mon Sep 17 00:00:00 2001
> From: Florian Paul Schmidt <mista.tapas@gmx.net>
> Date: Thu, 3 Dec 2015 14:57:10 +0100
> Subject: [PATCH] xfce4-power-manager: new variable
>
> ---
>  gnu/packages/xfce.scm | 38 ++++++++++++++++++++++++++++++++++++++
>  1 file changed, 38 insertions(+)
>
> diff --git a/gnu/packages/xfce.scm b/gnu/packages/xfce.scm
> index e213fb6..41e193a 100644
> --- a/gnu/packages/xfce.scm
> +++ b/gnu/packages/xfce.scm
> @@ -646,6 +646,43 @@ menubar and the window decorations are hidden) 
> that helps you to save space
>  on your desktop.")
>      (license gpl2+)))
>
> +(define-public xfce4-power-manager
> +  (package
> +    (name "xfce4-power-manager")
> +    (version "1.4.3")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append "http://archive.xfce.org/xfce/4.12"
> +                                  "/src/" name "-" version ".tar.bz2"))
> +              (sha256
> +               (base32
> + "04909sfc2nrj2wg9cw6y9y2r9yrp3l3vc201sy1gaiap67fi33h1"))))
> +    (build-system gnu-build-system)
> +    (arguments
> +     '(#:configure-flags '("--enable-gtk3")))
> +    (native-inputs
> +     `(("pkg-config" ,pkg-config)
> +       ("intltool" ,intltool)))
> +    (inputs
> +     `(("exo" ,exo)
> +       ("garcon", garcon)
> +       ("lbxrandr" ,libxrandr)
> +       ("libwnck" ,libwnck-1)
> +       ("upower" ,upower)
> +       ("libnotify" ,libnotify)
> +       ("libxfce4ui" ,libxfce4ui)))
> +    (native-search-paths
> +     (list (search-path-specification
> +            (variable "X_XFCE4_LIB_DIRS")
> +            (files '("lib/xfce4")))))
> +    (home-page "http://www.xfce.org/")
> +    (synopsis "Xfce Power Manager")
> +    (description
> +     "Power manager daemon for Xfce and associated settings page.
> +Controls backlight, power saving, etc.")
> +    ;; Libraries are under LGPLv2.1+, and programs under GPLv2+.
> +    (license (list gpl2+ lgpl2.1+))))
> +
>  (define-public xfce
>    (package
>      (name "xfce")
> @@ -689,6 +726,7 @@ on your desktop.")
>         ("xfce4-session"        ,xfce4-session)
>         ("xfce4-settings"       ,xfce4-settings)
>         ("xfce4-terminal"       ,xfce4-terminal)
> +       ("xfce4-power-manager"  ,xfce4-power-manager)
>         ("xfconf"               ,xfconf)
>         ("xfdesktop"            ,xfdesktop)
>         ("xfwm4"                ,xfwm4)


[-- Attachment #2: 0001-xfce4-power-manager-remove-some-inputs.patch --]
[-- Type: text/plain, Size: 818 bytes --]

From e2a998d93fe2f9ea3089e343e55dbb0bedf7a0d8 Mon Sep 17 00:00:00 2001
From: Florian Paul Schmidt <mista.tapas@gmx.net>
Date: Thu, 3 Dec 2015 22:39:16 +0100
Subject: [PATCH] xfce4-power-manager: remove some inputs

---
 gnu/packages/xfce.scm | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/gnu/packages/xfce.scm b/gnu/packages/xfce.scm
index 41e193a..e569169 100644
--- a/gnu/packages/xfce.scm
+++ b/gnu/packages/xfce.scm
@@ -664,10 +664,7 @@ on your desktop.")
      `(("pkg-config" ,pkg-config)
        ("intltool" ,intltool)))
     (inputs
-     `(("exo" ,exo)
-       ("garcon", garcon)
-       ("lbxrandr" ,libxrandr)
-       ("libwnck" ,libwnck-1)
+     `(("lbxrandr" ,libxrandr)
        ("upower" ,upower)
        ("libnotify" ,libnotify)
        ("libxfce4ui" ,libxfce4ui)))
-- 
2.5.0

Re: [PATCH]: xfce4-power-manager: new variable

[Florian Paul Schmidt]

[-- Attachment #1: Type: text/plain, Size: 153 bytes --]

Make lint happy

On 12/03/2015 10:40 PM, Florian Paul Schmidt wrote:
> Removed some inputs (see attached patch). Seems to still build and run..
>
> Flo


[-- Attachment #2: 0001-xfe4-power-manager-make-lint-happy.patch --]
[-- Type: text/plain, Size: 865 bytes --]

From be4925c1fb459ef02965a771dc0689f5dc23b2e3 Mon Sep 17 00:00:00 2001
From: Florian Paul Schmidt <mista.tapas@gmx.net>
Date: Thu, 3 Dec 2015 22:43:06 +0100
Subject: [PATCH] xfe4-power-manager: make lint happy

---
 gnu/packages/xfce.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/xfce.scm b/gnu/packages/xfce.scm
index e569169..89feb8e 100644
--- a/gnu/packages/xfce.scm
+++ b/gnu/packages/xfce.scm
@@ -675,7 +675,7 @@ on your desktop.")
     (home-page "http://www.xfce.org/")
     (synopsis "Xfce Power Manager")
     (description
-     "Power manager daemon for Xfce and associated settings page. 
+     "Power manager daemon for Xfce and associated settings page.
 Controls backlight, power saving, etc.")
     ;; Libraries are under LGPLv2.1+, and programs under GPLv2+.
     (license (list gpl2+ lgpl2.1+))))
-- 
2.5.0

Re: [PATCH]: xfce4-power-manager: new variable

[Andreas Enge]

On Thu, Dec 03, 2015 at 10:40:50PM +0100, Florian Paul Schmidt wrote:
> Removed some inputs (see attached patch). Seems to still build and run..

I usually work the other way round. I start with empty inputs and look at
the output of the configure phase, then add inputs one by one. This leads
to cleaner packages, I think.

Notice that it is not enough to make the binary distinction between building
and not building. Sometimes optional inputs are useful to have (I tend to be
maximalist and add as many optional inputs as possible).

Andreas

Re: [PATCH]: xfce4-power-manager: new variable

[Florian Paul Schmidt]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

On 12/04/2015 06:16 PM, Andreas Enge wrote:
> On Thu, Dec 03, 2015 at 10:40:50PM +0100, Florian Paul Schmidt
> wrote:
>> Removed some inputs (see attached patch). Seems to still build
>> and run..
> 
> I usually work the other way round. I start with empty inputs and
> look at the output of the configure phase, then add inputs one by
> one. This leads to cleaner packages, I think.
> 
> Notice that it is not enough to make the binary distinction between
> building and not building. Sometimes optional inputs are useful to
> have (I tend to be maximalist and add as many optional inputs as
> possible).

Yeah, in the current state the basically the only inputs that remain
are those I had to add in the first place to get it to build (the ones
I now removed are leftovers from the original xfce4-related package).

I guess the native-search-path thing might go away safely, too. Will
test and update the patch..

Flo


- -- 
https://fps.io
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQEcBAEBCAAGBQJWYeM+AAoJEA5f4Coltk8ZJFkH/2XZLjsYYgz4fBsvboxTEwVk
DiMb+6pT9pvAkte3nrboeVJn9SVZAogVlSUvhwsDOs3JZC9g52j3u+25kO4whtHU
ah59hUxiflpK9wEdQHEinXnv6ej8VDvbbthg9y2L0LCTmm7Ww49JWNqwLEKnFlND
YaNrzAsjzvPsFGGL5velCD1V+2ukw99Wqlx+0b0cz6bHbRReYsfQk3e6OTkaDBtQ
t4W0pX9jHUZT9/YJmpjid38HACX66QprQTw+3HGcO01VMy8sSJKlFeYIRsvh8xib
zH+ynIitAw150K1yFHZoGHGgGFN6XnxuR0LJs2iQihHkS5sCxcn3sbbR1zqqhuw=
=8Iat
-----END PGP SIGNATURE-----

Re: [PATCH]: xfce4-power-manager: new variable

[Florian Paul Schmidt]

[-- Attachment #1: Type: text/plain, Size: 241 bytes --]

Remove some more crud.



On 12/03/2015 10:43 PM, Florian Paul Schmidt wrote:
> Make lint happy
>
> On 12/03/2015 10:40 PM, Florian Paul Schmidt wrote:
>> Removed some inputs (see attached patch). Seems to still build and run..
>>
>> Flo
>


[-- Attachment #2: 0001-xfce4-power-manager-remove-native-search-paths.patch --]
[-- Type: text/plain, Size: 827 bytes --]

From 6d4ce3ad7a0298bdf8b445e9384c00727800ded3 Mon Sep 17 00:00:00 2001
From: Florian Paul Schmidt <mista.tapas@gmx.net>
Date: Sat, 5 Dec 2015 00:03:15 +0100
Subject: [PATCH] xfce4-power-manager: remove native-search-paths

---
 gnu/packages/xfce.scm | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/gnu/packages/xfce.scm b/gnu/packages/xfce.scm
index 89feb8e..c08394e 100644
--- a/gnu/packages/xfce.scm
+++ b/gnu/packages/xfce.scm
@@ -668,10 +668,6 @@ on your desktop.")
        ("upower" ,upower)
        ("libnotify" ,libnotify)
        ("libxfce4ui" ,libxfce4ui)))
-    (native-search-paths
-     (list (search-path-specification
-            (variable "X_XFCE4_LIB_DIRS")
-            (files '("lib/xfce4")))))
     (home-page "http://www.xfce.org/")
     (synopsis "Xfce Power Manager")
     (description
-- 
2.5.0

Re: [PATCH]: xfce4-power-manager: new variable

[Ludovic Courtès]

Florian Paul Schmidt <mista.tapas@gmx.net> skribis:

> From 6d4ce3ad7a0298bdf8b445e9384c00727800ded3 Mon Sep 17 00:00:00 2001
> From: Florian Paul Schmidt <mista.tapas@gmx.net>
> Date: Sat, 5 Dec 2015 00:03:15 +0100
> Subject: [PATCH] xfce4-power-manager: remove native-search-paths
>
> ---
>  gnu/packages/xfce.scm | 4 ----
>  1 file changed, 4 deletions(-)
>
> diff --git a/gnu/packages/xfce.scm b/gnu/packages/xfce.scm
> index 89feb8e..c08394e 100644
> --- a/gnu/packages/xfce.scm
> +++ b/gnu/packages/xfce.scm
> @@ -668,10 +668,6 @@ on your desktop.")
>         ("upower" ,upower)
>         ("libnotify" ,libnotify)
>         ("libxfce4ui" ,libxfce4ui)))
> -    (native-search-paths
> -     (list (search-path-specification
> -            (variable "X_XFCE4_LIB_DIRS")
> -            (files '("lib/xfce4")))))
>      (home-page "http://www.xfce.org/")

Could you send the full patch in one go?  Also please include a
ChangeLog-style commit entry, and make sure ‘guix lint’ is happy before
posting.  :-)

See <https://www.gnu.org/software/guix/manual/html_node/Submitting-Patches.html>.

Thanks for helping out!

Ludo’.

Re: [PATCH]: xfce4-power-manager: new variable

[Florian Paul Schmidt]

On 12/06/2015 10:51 PM, Ludovic Courtès wrote:
> Could you send the full patch in one go? Also please include a 
> ChangeLog-style commit entry, and make sure ‘guix lint’ is happy 
> before posting. :-) See 
> <https://www.gnu.org/software/guix/manual/html_node/Submitting-Patches.html>. 
> Thanks for helping out! Ludo’. 

Sure, once I'm happy with it (and others are, too) I'll do that. Still 
needs some testing love anyways. Thanks for making guix[sd] :)

Flo

Re: [PATCH]: xfce4-power-manager: new variable

[Ludovic Courtès]

Leo Famulari <leo@famulari.name> skribis:

> On Thu, Dec 03, 2015 at 03:04:55PM +0100, Florian Paul Schmidt wrote:
>> Hi,
>> 
>> attached is a patch for a first stab at packaging xfce4-power-manager. Since
>> I used a different package as a base for this one there might be some
>> unneeded inputs. I wonder if you guys have a tip for creating a little
>> scheme snippet that would try all combinations of inputs to determine the
>> minimal set for which ones the package build still succeeds? ;) [lazy flo]
>
> The potential issue with this approach is that a lot of software will
> build successfully even if some dependencies are missing. And then it
> will fail at runtime, sometimes only in certain scenarios. Not that I
> haven't thought about doing the same thing... :)
>
> Ideally each program would have a test suite that exercised every code
> path. Maybe AFL would be useful there? That sounds expensive but for
> very complex systems, it would be worth it, because in my limited
> experience packaging software, I have found that many upstream
> developers are not aware of the dependency graph of their software. It's
> fun to send them the output of "guix graph".

Looks like the xfce4-power-manager patch fell through the cracks.  Leo,
could you maybe do a final polishing pass and commit it?

Thanks,  :-)
Ludo’.

Re: [PATCH]: xfce4-power-manager: new variable

[Leo Famulari]

On Mon, Mar 07, 2016 at 02:38:03PM +0100, Ludovic Courtès wrote:
> Leo Famulari <leo@famulari.name> skribis:
> 
> > On Thu, Dec 03, 2015 at 03:04:55PM +0100, Florian Paul Schmidt wrote:
> >> Hi,
> >> 
> >> attached is a patch for a first stab at packaging xfce4-power-manager. Since
> >> I used a different package as a base for this one there might be some
> >> unneeded inputs. I wonder if you guys have a tip for creating a little
> >> scheme snippet that would try all combinations of inputs to determine the
> >> minimal set for which ones the package build still succeeds? ;) [lazy flo]
> >
> > The potential issue with this approach is that a lot of software will
> > build successfully even if some dependencies are missing. And then it
> > will fail at runtime, sometimes only in certain scenarios. Not that I
> > haven't thought about doing the same thing... :)
> >
> > Ideally each program would have a test suite that exercised every code
> > path. Maybe AFL would be useful there? That sounds expensive but for
> > very complex systems, it would be worth it, because in my limited
> > experience packaging software, I have found that many upstream
> > developers are not aware of the dependency graph of their software. It's
> > fun to send them the output of "guix graph".
> 
> Looks like the xfce4-power-manager patch fell through the cracks.  Leo,
> could you maybe do a final polishing pass and commit it?

Sure. I separated the addition of the package and its use in the xfce
meta-packaged into two patches.

I know you asked me to commit, but since I don't have a system where I
can test Xfce with power, I'm submitting the patches.

Does anyone want to test? It does pass its test suite.

I will go ahead and commit the patches if you confirm it's okay without
having tested them.

Re: [PATCH]: xfce4-power-manager: new variable

[Leo Famulari]

[-- Attachment #1: Type: text/plain, Size: 1452 bytes --]

On Mon, Mar 07, 2016 at 02:38:03PM +0100, Ludovic Courtès wrote:
> Leo Famulari <leo@famulari.name> skribis:
> 
> > On Thu, Dec 03, 2015 at 03:04:55PM +0100, Florian Paul Schmidt wrote:
> >> Hi,
> >> 
> >> attached is a patch for a first stab at packaging xfce4-power-manager. Since
> >> I used a different package as a base for this one there might be some
> >> unneeded inputs. I wonder if you guys have a tip for creating a little
> >> scheme snippet that would try all combinations of inputs to determine the
> >> minimal set for which ones the package build still succeeds? ;) [lazy flo]
> >
> > The potential issue with this approach is that a lot of software will
> > build successfully even if some dependencies are missing. And then it
> > will fail at runtime, sometimes only in certain scenarios. Not that I
> > haven't thought about doing the same thing... :)
> >
> > Ideally each program would have a test suite that exercised every code
> > path. Maybe AFL would be useful there? That sounds expensive but for
> > very complex systems, it would be worth it, because in my limited
> > experience packaging software, I have found that many upstream
> > developers are not aware of the dependency graph of their software. It's
> > fun to send them the output of "guix graph".
> 
> Looks like the xfce4-power-manager patch fell through the cracks.  Leo,
> could you maybe do a final polishing pass and commit it?

And here are the patches...

[-- Attachment #2: 0001-gnu-Add-xfce4-power-manager.patch --]
[-- Type: text/x-diff, Size: 2515 bytes --]

From 2ef9d0fae7dd04cfb25691411b5afec76cb3eb5b Mon Sep 17 00:00:00 2001
From: Florian Paul Schmidt <mista.tapas@gmx.net>
Date: Thu, 3 Dec 2015 14:57:10 +0100
Subject: [PATCH 1/2] gnu: Add xfce4-power-manager.

* gnu/packages/xfce.scm (xfce4-power-manager): New variable.

Signed-off-by: Leo Famulari <leo@famulari.name>
---
 gnu/packages/xfce.scm | 35 +++++++++++++++++++++++++++++++++++
 1 file changed, 35 insertions(+)

diff --git a/gnu/packages/xfce.scm b/gnu/packages/xfce.scm
index b627396..c1a4328 100644
--- a/gnu/packages/xfce.scm
+++ b/gnu/packages/xfce.scm
@@ -2,6 +2,7 @@
 ;;; Copyright © 2014, 2015 Sou Bunnbu <iyzsong@gmail.com>
 ;;; Copyright © 2014, 2015 Mark H Weaver <mhw@netris.org>
 ;;; Copyright © 2016 Andreas Enge <andreas@enge.fr>
+;;; Copyright © 2016 Florian Paul Schmidt <mista.tapas@gmx.net>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -721,3 +722,37 @@ on your desktop.")
      "Xfce is a lightweight desktop environment.  It aims to be fast and low on
 system resources, while still being visually appealing and user friendly.")
     (license gpl2+)))
+
+(define-public xfce4-power-manager
+  (package
+    (name "xfce4-power-manager")
+    (version "1.4.3")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append "http://archive.xfce.org/xfce/4.12"
+                                  "/src/" name "-" version ".tar.bz2"))
+              (sha256
+               (base32
+                "04909sfc2nrj2wg9cw6y9y2r9yrp3l3vc201sy1gaiap67fi33h1"))))
+    (build-system gnu-build-system)
+    (arguments
+     '(#:configure-flags '("--enable-gtk3")))
+    (native-inputs
+     `(("pkg-config" ,pkg-config)
+       ("intltool" ,intltool)))
+    (inputs
+     `(("lbxrandr" ,libxrandr)
+       ("upower" ,upower)
+       ("libnotify" ,libnotify)
+       ("libxfce4ui" ,libxfce4ui)))
+    (home-page "http://www.xfce.org/")
+    (synopsis "Xfce Power Manager")
+    (description
+     "This is a power manager for the Xfce desktop.  It manages the power
+sources on the computer and the devices that can be controlled to reduce their
+power consumption (such as LCD brightness level, monitor sleep, CPU frequency
+scaling, etc).  In addition, xfce4-power-manager provides a set of
+freedesktop-compliant DBus interfaces to inform other applications about current
+power level so that they can adjust their power consumption, and it provides the
+inhibit interface which allows applications to prevent automatic sleep.")
+    (license gpl2+)))
-- 
2.6.3


[-- Attachment #3: 0002-gnu-xfce-Add-xfce4-power-manager.patch --]
[-- Type: text/x-diff, Size: 880 bytes --]

From 24d1a433fb793433fcea78cc115cb3d89bdd0ebe Mon Sep 17 00:00:00 2001
From: Leo Famulari <leo@famulari.name>
Date: Mon, 7 Mar 2016 23:00:35 -0500
Subject: [PATCH 2/2] gnu: xfce: Add xfce4-power-manager.

* gnu/packages/xfce.scm (xfce)[propagated-inputs]: Add xfce4-power-manager.
---
 gnu/packages/xfce.scm | 1 +
 1 file changed, 1 insertion(+)

diff --git a/gnu/packages/xfce.scm b/gnu/packages/xfce.scm
index c1a4328..03b49a8 100644
--- a/gnu/packages/xfce.scm
+++ b/gnu/packages/xfce.scm
@@ -705,6 +705,7 @@ on your desktop.")
        ("tumlber"              ,tumbler)
        ("xfce4-appfinder"      ,xfce4-appfinder)
        ("xfce4-panel"          ,xfce4-panel)
+       ("xfce4-power-manager"  ,xfce4-power-manager)
        ("xfce4-session"        ,xfce4-session)
        ("xfce4-settings"       ,xfce4-settings)
        ("xfce4-terminal"       ,xfce4-terminal)
-- 
2.6.3

Re: [PATCH]: xfce4-power-manager: new variable

[Ludovic Courtès]

Leo Famulari <leo@famulari.name> skribis:


[...]

>> Looks like the xfce4-power-manager patch fell through the cracks.  Leo,
>> could you maybe do a final polishing pass and commit it?
>
> And here are the patches...
>
> From 2ef9d0fae7dd04cfb25691411b5afec76cb3eb5b Mon Sep 17 00:00:00 2001
> From: Florian Paul Schmidt <mista.tapas@gmx.net>
> Date: Thu, 3 Dec 2015 14:57:10 +0100
> Subject: [PATCH 1/2] gnu: Add xfce4-power-manager.
>
> * gnu/packages/xfce.scm (xfce4-power-manager): New variable.
>
> Signed-off-by: Leo Famulari <leo@famulari.name>

[...]

> From 24d1a433fb793433fcea78cc115cb3d89bdd0ebe Mon Sep 17 00:00:00 2001
> From: Leo Famulari <leo@famulari.name>
> Date: Mon, 7 Mar 2016 23:00:35 -0500
> Subject: [PATCH 2/2] gnu: xfce: Add xfce4-power-manager.
>
> * gnu/packages/xfce.scm (xfce)[propagated-inputs]: Add xfce4-power-manager.

Perfect, go for it!

Ludo’, who feels guilty for his ever-increasing review delays.