Re: [PATCH]: xfce4-power-manager: new variable

[Leo Famulari <leo@famulari.name>]

On Mon, Mar 07, 2016 at 02:38:03PM +0100, Ludovic Courtès wrote:
> Leo Famulari <leo@famulari.name> skribis:
> 
> > On Thu, Dec 03, 2015 at 03:04:55PM +0100, Florian Paul Schmidt wrote:
> >> Hi,
> >> 
> >> attached is a patch for a first stab at packaging xfce4-power-manager. Since
> >> I used a different package as a base for this one there might be some
> >> unneeded inputs. I wonder if you guys have a tip for creating a little
> >> scheme snippet that would try all combinations of inputs to determine the
> >> minimal set for which ones the package build still succeeds? ;) [lazy flo]
> >
> > The potential issue with this approach is that a lot of software will
> > build successfully even if some dependencies are missing. And then it
> > will fail at runtime, sometimes only in certain scenarios. Not that I
> > haven't thought about doing the same thing... :)
> >
> > Ideally each program would have a test suite that exercised every code
> > path. Maybe AFL would be useful there? That sounds expensive but for
> > very complex systems, it would be worth it, because in my limited
> > experience packaging software, I have found that many upstream
> > developers are not aware of the dependency graph of their software. It's
> > fun to send them the output of "guix graph".
> 
> Looks like the xfce4-power-manager patch fell through the cracks.  Leo,
> could you maybe do a final polishing pass and commit it?

Sure. I separated the addition of the package and its use in the xfce
meta-packaged into two patches.

I know you asked me to commit, but since I don't have a system where I
can test Xfce with power, I'm submitting the patches.

Does anyone want to test? It does pass its test suite.

I will go ahead and commit the patches if you confirm it's okay without
having tested them.