From mboxrd@z Thu Jan  1 00:00:00 1970
From: Leo Famulari <leo@famulari.name>
Subject: Re: [PATCH 2/6] gnu: mdds: Update to 1.1.0.
Date: Mon, 7 Mar 2016 14:41:22 -0500
Message-ID: <20160307194122.GB10097@jasmine>
References: <1457347327-13748-1-git-send-email-efraim@flashner.co.il>
	<1457347327-13748-3-git-send-email-efraim@flashner.co.il>
Mime-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 8bit
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48795)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1ad11y-0006Gm-C1
	for guix-devel@gnu.org; Mon, 07 Mar 2016 14:41:27 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1ad11v-0007hX-4b
	for guix-devel@gnu.org; Mon, 07 Mar 2016 14:41:26 -0500
Received: from out5-smtp.messagingengine.com ([66.111.4.29]:53513)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1ad11v-0007hT-1W
	for guix-devel@gnu.org; Mon, 07 Mar 2016 14:41:23 -0500
Content-Disposition: inline
In-Reply-To: <1457347327-13748-3-git-send-email-efraim@flashner.co.il>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Efraim Flashner <efraim@flashner.co.il>
Cc: guix-devel@gnu.org

On Mon, Mar 07, 2016 at 12:42:03PM +0200, Efraim Flashner wrote:
> * gnu/packages/boost.scm (mdds): Update to 1.1.0.
> [home-page]: Update to new homepage.
> (mdds-0.12.1): Keep for libreoffice.

While I wait for the build to finish, here is a superficial review.

[...]

>  ;;; Copyright © 2014, 2015 Mark H Weaver <mhw@netris.org>
>  ;;; Copyright © 2015 Andreas Enge <andreas@enge.fr>
> -;;; Copyright © 2016 Eric Bavier <bavier@member.fsf.org>
>  ;;; Copyright © 2015 Ludovic Courtès <ludo@gnu.org>
> +;;; Copyright © 2016 Eric Bavier <bavier@member.fsf.org>
> +;;; Copyright © 2016 Efraim Flashner <efraim@flashner.co.il>

Is it possible to keep Eric's line in place, just to reduce noise in the
logs?

>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -107,21 +108,36 @@ across a broad spectrum of applications.")
>  (define-public mdds
>    (package
>      (name "mdds")
> -    (version "0.12.1")
> +    (version "1.1.0")
>      (source (origin
>               (method url-fetch)
>               (uri (string-append
> -                   "http://kohei.us/files/mdds/src/mdds_" version ".tar.bz2"))
> +                   "http://kohei.us/files/mdds/src/mdds-" version ".tar.bz2"))

I can't figure out what the difference is between these lines...

[...]

> +;; Libreoffice needs mdds-0.12.1 to build, but its dependancies need mdds-1.0+.
> +;; Rather than use an external binary while building libreoffice, it's better
> +;; to keep this version around until Libreoffice updates its dependancy.
> +(define-public mdds-0.12.1

Could this be a private variable in libreoffice.scm?

> +  (package
> +    (inherit mdds)
> +    (version "0.12.1")
> +    (source
> +      (origin
> +        (method url-fetch)
> +        (uri (string-append "http://kohei.us/files/mdds/src/mdds_" version ".tar.bz2"))
> +        (sha256
> +         (base32
> +          "0gg8mb9kxh3wggh7njj1gf90xy27p0yq2cw88wqar9hhg2fmwmi3"))))))
> -- 
> 2.7.0
> 
>