From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andreas Enge Subject: Re: [PATCH 0/1] Remove an unused patch? Date: Sat, 5 Mar 2016 17:14:56 +0100 Message-ID: <20160305161456.GA25823@solar> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:52051) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1acErB-0000rj-Kc for guix-devel@gnu.org; Sat, 05 Mar 2016 11:15:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1acEr7-00029T-7v for guix-devel@gnu.org; Sat, 05 Mar 2016 11:15:05 -0500 Received: from mailrelay1.public.one.com ([91.198.169.124]:30869) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1acEr6-00029O-S0 for guix-devel@gnu.org; Sat, 05 Mar 2016 11:15:01 -0500 Content-Disposition: inline In-Reply-To: List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Leo Famulari Cc: guix-devel@gnu.org On Fri, Feb 19, 2016 at 11:22:30PM -0500, Leo Famulari wrote: > The patch file 'cpio-gets-undeclared.patch' was "de-applied" to the cpio > sources when we upgraded cpio to 2.12 (92d0fcb6dc5). But, it was never > deleted or removed from gnu-system.am. I think it can be safely removed. The patch itself mentions that the upstream sources have been fixed, so with the update that removed the "patches" field, this one has become obsolete also. Apparently the patch was required for building with newer glibc; the fact that it now builds without the patch is further proof that the patch is not needed. Thanks for spotting this! Andreas