From: Andreas Enge <andreas@enge.fr>
To: Leo Famulari <leo@famulari.name>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 0/1] Remove an unused patch?
Date: Sat, 5 Mar 2016 17:14:56 +0100 [thread overview]
Message-ID: <20160305161456.GA25823@solar> (raw)
In-Reply-To: <cover.1455942085.git.leo@famulari.name>
On Fri, Feb 19, 2016 at 11:22:30PM -0500, Leo Famulari wrote:
> The patch file 'cpio-gets-undeclared.patch' was "de-applied" to the cpio
> sources when we upgraded cpio to 2.12 (92d0fcb6dc5). But, it was never
> deleted or removed from gnu-system.am.
I think it can be safely removed. The patch itself mentions that the upstream
sources have been fixed, so with the update that removed the "patches" field,
this one has become obsolete also. Apparently the patch was required for
building with newer glibc; the fact that it now builds without the patch is
further proof that the patch is not needed.
Thanks for spotting this!
Andreas
next prev parent reply other threads:[~2016-03-05 16:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-20 4:22 [PATCH 0/1] Remove an unused patch? Leo Famulari
2016-02-20 4:22 ` [PATCH 1/1] gnu: cpio: Remove unused patch Leo Famulari
2016-02-26 0:20 ` Mark H Weaver
2016-02-26 1:32 ` Leo Famulari
2016-03-05 16:14 ` Andreas Enge [this message]
2016-03-05 21:57 ` [PATCH 0/1] Remove an unused patch? Ludovic Courtès
2016-03-05 22:08 ` Leo Famulari
2016-03-06 12:49 ` Andreas Enge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160305161456.GA25823@solar \
--to=andreas@enge.fr \
--cc=guix-devel@gnu.org \
--cc=leo@famulari.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.